From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B1E4C2FC14 for ; Thu, 17 Aug 2023 06:45:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238264AbjHQGpA (ORCPT ); Thu, 17 Aug 2023 02:45:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348304AbjHQGom (ORCPT ); Thu, 17 Aug 2023 02:44:42 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2EC52705; Wed, 16 Aug 2023 23:44:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1692254679; bh=Wx3nMILiB1NeGS4OwS92O58JvJol6RuBMilPby1aexs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=pz9ElAbaHeW1WlM6FirXgpjKbRPGtcW5zyN9pjls0kdL5arkLwqzNAVC2PRn8qBwa H7IIeZkTzubrcVySUgmaLN+TVRI99448w/43xEZmkedXGjwkQqUrLNaZmEExYUZ3Bm XYqMrfLSaC1FaZ8/j+tbrK639d5HhNFaWXxueq9xAh/P7BTLPTGv/ijFYQk9ork8Cb 7zE2UxOOMfQgPJPLpx84Pc0eVfEe3/KQ1eFlSzHg8H0DaTxISTWpBmNsNlo6kT5kM5 tD6xpCigM1TCzd9uFuB1hn9Zb+Zagh9PO32Di7yumRtEJRKfvGIKl80K3hYIMqRr7g AGomz3KsKnWEA== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4RRFqC2jtTz4wZn; Thu, 17 Aug 2023 16:44:39 +1000 (AEST) From: Michael Ellerman To: mahesh@linux.ibm.com Cc: linuxppc-dev , Tyrel Datwyler , Nathan Lynch , Oliver O'Halloran , linux-pci , Bjorn Helgaas , Linux Kernel Subject: Re: [PATCH v8 1/2] powerpc/rtas: Rename rtas_error_rc to rtas_generic_errno In-Reply-To: References: <169138864808.65607.6576358707894823512.stgit@jupiter> <877cpxdksx.fsf@mail.lhotse> Date: Thu, 17 Aug 2023 16:44:38 +1000 Message-ID: <87zg2q5fs9.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Mahesh J Salgaonkar writes: > On 2023-08-15 13:52:14 Tue, Michael Ellerman wrote: >> Mahesh Salgaonkar writes: ... >> > diff --git a/arch/powerpc/include/asm/rtas.h b/arch/powerpc/include/asm/rtas.h >> > index 3abe15ac79db1..5572a0a2f6e18 100644 >> > --- a/arch/powerpc/include/asm/rtas.h >> > +++ b/arch/powerpc/include/asm/rtas.h >> > @@ -202,7 +202,9 @@ typedef struct { >> > #define RTAS_USER_REGION_SIZE (64 * 1024) >> > >> > /* RTAS return status codes */ >> > -#define RTAS_BUSY -2 /* RTAS Busy */ >> > +#define RTAS_HARDWARE_ERROR (-1) /* Hardware Error */ >> > +#define RTAS_BUSY (-2) /* RTAS Busy */ >> >> Are the brackets necessary? > > During v5 changset I received offline review comment to add brackets, > hence continued here as well. I can take it away if Nathan is fine with > it. OK. I can't think of a context where the brackets are useful, but I'm probably just not thinking hard enough. I don't really mind adding them, I was just curious what the justification for them was. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0FFAC27C7A for ; Thu, 17 Aug 2023 06:45:39 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=pz9ElAba; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RRFrL02xtz3cLj for ; Thu, 17 Aug 2023 16:45:38 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=pz9ElAba; dkim-atps=neutral Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RRFqN0B2tz2yVd for ; Thu, 17 Aug 2023 16:44:48 +1000 (AEST) Received: by gandalf.ozlabs.org (Postfix) id 4RRFqC5H8lz4wy3; Thu, 17 Aug 2023 16:44:39 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1692254679; bh=Wx3nMILiB1NeGS4OwS92O58JvJol6RuBMilPby1aexs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=pz9ElAbaHeW1WlM6FirXgpjKbRPGtcW5zyN9pjls0kdL5arkLwqzNAVC2PRn8qBwa H7IIeZkTzubrcVySUgmaLN+TVRI99448w/43xEZmkedXGjwkQqUrLNaZmEExYUZ3Bm XYqMrfLSaC1FaZ8/j+tbrK639d5HhNFaWXxueq9xAh/P7BTLPTGv/ijFYQk9ork8Cb 7zE2UxOOMfQgPJPLpx84Pc0eVfEe3/KQ1eFlSzHg8H0DaTxISTWpBmNsNlo6kT5kM5 tD6xpCigM1TCzd9uFuB1hn9Zb+Zagh9PO32Di7yumRtEJRKfvGIKl80K3hYIMqRr7g AGomz3KsKnWEA== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4RRFqC2jtTz4wZn; Thu, 17 Aug 2023 16:44:39 +1000 (AEST) From: Michael Ellerman To: mahesh@linux.ibm.com Subject: Re: [PATCH v8 1/2] powerpc/rtas: Rename rtas_error_rc to rtas_generic_errno In-Reply-To: References: <169138864808.65607.6576358707894823512.stgit@jupiter> <877cpxdksx.fsf@mail.lhotse> Date: Thu, 17 Aug 2023 16:44:38 +1000 Message-ID: <87zg2q5fs9.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nathan Lynch , Tyrel Datwyler , linux-pci , Linux Kernel , linuxppc-dev , Oliver O'Halloran , Bjorn Helgaas Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Mahesh J Salgaonkar writes: > On 2023-08-15 13:52:14 Tue, Michael Ellerman wrote: >> Mahesh Salgaonkar writes: ... >> > diff --git a/arch/powerpc/include/asm/rtas.h b/arch/powerpc/include/asm/rtas.h >> > index 3abe15ac79db1..5572a0a2f6e18 100644 >> > --- a/arch/powerpc/include/asm/rtas.h >> > +++ b/arch/powerpc/include/asm/rtas.h >> > @@ -202,7 +202,9 @@ typedef struct { >> > #define RTAS_USER_REGION_SIZE (64 * 1024) >> > >> > /* RTAS return status codes */ >> > -#define RTAS_BUSY -2 /* RTAS Busy */ >> > +#define RTAS_HARDWARE_ERROR (-1) /* Hardware Error */ >> > +#define RTAS_BUSY (-2) /* RTAS Busy */ >> >> Are the brackets necessary? > > During v5 changset I received offline review comment to add brackets, > hence continued here as well. I can take it away if Nathan is fine with > it. OK. I can't think of a context where the brackets are useful, but I'm probably just not thinking hard enough. I don't really mind adding them, I was just curious what the justification for them was. cheers