From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Robert Marko <robimarko@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/mhz: add new package
Date: Mon, 31 Jul 2023 15:24:14 +0300 [thread overview]
Message-ID: <87zg3c1d1e.fsf@tarshish> (raw)
In-Reply-To: <20230731122022.1686951-1-robimarko@gmail.com>
Hi Robert,
On Mon, Jul 31 2023, Robert Marko wrote:
> mhz is a tool to mathematically calculate the real running CPU frequency
> and as such has proved as invaluable tool for developing CPUFreq and
> similar features in the kernel.
>
> Its source finally got a license recently so it can be packaged.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
> Changes in v2:
> * Use the Makefile from source and override CC and CFLAGS
> ---
> package/Config.in | 1 +
> package/mhz/Config.in | 6 ++++++
> package/mhz/mhz.hash | 2 ++
> package/mhz/mhz.mk | 21 +++++++++++++++++++++
> 4 files changed, 30 insertions(+)
> create mode 100644 package/mhz/Config.in
> create mode 100644 package/mhz/mhz.hash
> create mode 100644 package/mhz/mhz.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index a60a1a8858..b9b6dd2580 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -549,6 +549,7 @@ endmenu
> source "package/memtest86/Config.in"
> source "package/memtester/Config.in"
> source "package/memtool/Config.in"
> + source "package/mhz/Config.in"
> source "package/minicom/Config.in"
> source "package/msr-tools/Config.in"
> source "package/nanocom/Config.in"
> diff --git a/package/mhz/Config.in b/package/mhz/Config.in
> new file mode 100644
> index 0000000000..2f4af5026e
> --- /dev/null
> +++ b/package/mhz/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_MHZ
> + bool "mhz"
> + help
> + CPU frequency measurement utility.
> +
> + https://github.com/wtarreau/mhz.git
> diff --git a/package/mhz/mhz.hash b/package/mhz/mhz.hash
> new file mode 100644
> index 0000000000..6b39eb4bb7
> --- /dev/null
> +++ b/package/mhz/mhz.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256 1e07bb0d455d63fd33fb87a24f65a803c7c2d920fde4e5b5378b8c1b07de3b47 mhz-11aac2399780a1f7ea9f007b14af0464797d5cf1-br1.tar.gz
License file hash is missing here.
> diff --git a/package/mhz/mhz.mk b/package/mhz/mhz.mk
> new file mode 100644
> index 0000000000..924bf0793e
> --- /dev/null
> +++ b/package/mhz/mhz.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# mhz
> +#
> +################################################################################
> +
> +MHZ_VERSION = 11aac2399780a1f7ea9f007b14af0464797d5cf1
> +MHZ_SITE = https://github.com/wtarreau/mhz.git
> +MHZ_SITE_METHOD = git
You should use the github helper instead. Something like
MHZ_SITE = $(call github,wtarreau,mhz,$(MHZ_VERSION))
> +MHZ_LICENSE = MIT/X11
> +MHZ_LICENSE_FILES = LICENSE
> +
> +define MHZ_BUILD_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS) $(TARGET_LDFLAGS)" -C $(@D)
Are you sure you need TARGET_LDFLAGS here?
baruch
> +endef
> +
> +define MHZ_INSTALL_TARGET_CMDS
> + $(INSTALL) $(@D)/mhz $(TARGET_DIR)/usr/bin/mhz
> +endef
> +
> +$(eval $(generic-package))
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-07-31 12:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 12:20 [Buildroot] [PATCH v2] package/mhz: add new package Robert Marko
2023-07-31 12:24 ` Baruch Siach via buildroot [this message]
2023-07-31 12:51 ` Thomas Petazzoni via buildroot
2023-07-31 12:49 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg3c1d1e.fsf@tarshish \
--to=buildroot@buildroot.org \
--cc=baruch@tkos.co.il \
--cc=robimarko@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.