From: Marc Zyngier <maz@kernel.org>
To: Kunkun Jiang <jiangkunkun@huawei.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Zenghui Yu <yuzenghui@huawei.com>,
"open list:IRQCHIP DRIVERS" <linux-kernel@vger.kernel.org>,
<wanghaibin.wang@huawei.com>, <chenxiang66@hisilicon.com>,
<tangnianyao@huawei.com>
Subject: Re: [PATCH] irqchipi/gic-v4: Ensure accessing the correct RD when and writing INVLPIR
Date: Sat, 17 Jun 2023 08:35:45 +0100 [thread overview]
Message-ID: <87zg4ypmlq.wl-maz@kernel.org> (raw)
In-Reply-To: <b073b1f7-0567-eb45-dec9-dcd2054e41c9@huawei.com>
On Tue, 16 May 2023 13:01:59 +0100,
Kunkun Jiang <jiangkunkun@huawei.com> wrote:
>
> Hi Marc,
>
> On 2023/5/16 18:15, Marc Zyngier wrote:
> > On Thu, 13 Apr 2023 04:57:17 +0100,
> > Kunkun Jiang <jiangkunkun@huawei.com> wrote:
> >>> Wouldn't it be nice if irq_to_cpuid() could work out whether it is
> >>> dealing with a LPI or a VLPI like it does today, but also directly
> >>> with a VPE? We could then use the same code as derect_lpi_inv(). I
> >>> came up with this the hack below, which is totally untested as I don't
> >>> have access to GICv4.1 HW.
> >>>
> >>> Could you give it a spin?
> >> Nice, I will test it as soon as possible.
> > Did you ever managed to test this?
> Sorry,I've only been coordinating the GICv4.1 environment in the last
> few days. I have tested it with GICv4 many times, and it doesn't recur.
> However, another call trace occurs with GICv4.1 when the device driver
> is loaded in Guest. I haven't found out why. Maybe you can help analyze it.
I also went back to my patch, and it is a bit bogus (it doesn't even
compile to start with). I've now posted new version[1] that should at
least fix the bug you initially reported.
Can you please test it and reply to it?
Thanks,
M.
[1] https://lore.kernel.org/r/20230617073242.3199746-1-maz@kernel.org
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2023-06-17 7:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 4:15 [PATCH] irqchipi/gic-v4: Ensure accessing the correct RD when and writing INVLPIR Kunkun Jiang
2023-04-12 9:42 ` Marc Zyngier
[not found] ` <f618c540-879c-ca5b-31af-e55472d8208c@huawei.com>
2023-04-13 7:35 ` Marc Zyngier
2023-05-16 10:15 ` Marc Zyngier
2023-05-16 12:01 ` Kunkun Jiang
2023-06-17 7:02 ` Marc Zyngier
2023-06-17 7:35 ` Marc Zyngier [this message]
2023-06-21 12:30 ` Kunkun Jiang
2023-06-30 10:37 ` Kunkun Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg4ypmlq.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=chenxiang66@hisilicon.com \
--cc=jiangkunkun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tangnianyao@huawei.com \
--cc=tglx@linutronix.de \
--cc=wanghaibin.wang@huawei.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.