From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, michael.roth@amd.com, jsnow@redhat.com
Subject: Re: [PATCH] qapi/parser: Fix type hints
Date: Mon, 22 May 2023 09:51:48 +0200 [thread overview]
Message-ID: <87zg5wolbf.fsf@pond.sub.org> (raw)
In-Reply-To: <053b071d-9a57-f4c5-b2bd-c2b26ff67c52@redhat.com> (Paolo Bonzini's message of "Wed, 17 May 2023 19:14:48 +0200")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 5/16/23 07:22, Markus Armbruster wrote:
>>> File "/builds/qemu-project/qemu/scripts/qapi/parser.py", line 566, in QAPIDoc
>>> def _match_at_name_colon(string: str) -> Optional[re.Match[str]]:
>>> TypeError: 'type' object is not subscriptable
>>
>> Life's too short for wrestling with such pigs. Unless John has better
>> ideas, I'll *remove* these return type annotations. Maybe these pigs
>> will behave after John's Python venv work lands.
>
> re.Match[str] is new in 3.9. However, typing.Match[str] should work.
We'll try that after John's venv work is in. Thank you!
prev parent reply other threads:[~2023-05-22 7:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 11:17 [PATCH] qapi/parser: Fix type hints Markus Armbruster
2023-05-16 0:30 ` Richard Henderson
2023-05-16 5:22 ` Markus Armbruster
2023-05-16 13:29 ` Richard Henderson
2023-05-17 6:19 ` Markus Armbruster
2023-05-17 17:14 ` Paolo Bonzini
2023-05-22 7:51 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg5wolbf.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.