From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pQTgw-00082H-Bl for mharc-qemu-trivial@gnu.org; Fri, 10 Feb 2023 08:43:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQTgu-0007zG-2u for qemu-trivial@nongnu.org; Fri, 10 Feb 2023 08:43:52 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQTgs-0000Mf-21 for qemu-trivial@nongnu.org; Fri, 10 Feb 2023 08:43:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676036628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EL5rrRPFH49W9UBSKsqsaxrZkA2Iu8IOm+DsRbOGSqQ=; b=bco0FlWqrL9k6vBaN9ROF4C3eVrC962AybAf4SNqALrzDoUybUgqaXtIDXFTHdEmi/2WTg tA5lAyrql5zlGOMi7vYYinPlF3dKfX3trducUZrwU84+njCodKZkWfu83gmNwRrwNAINK9 qq4mDnNNF67bgiokwNMT4PeCJn+gjWc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-136-Xuv2iYDuMpeXP8pNnXx8Ew-1; Fri, 10 Feb 2023 08:43:45 -0500 X-MC-Unique: Xuv2iYDuMpeXP8pNnXx8Ew-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C4FE097108A; Fri, 10 Feb 2023 13:43:44 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.101]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 99B0B400DEF3; Fri, 10 Feb 2023 13:43:44 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 87A3021E6A1F; Fri, 10 Feb 2023 14:43:43 +0100 (CET) From: Markus Armbruster To: Thomas Huth Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-trivial@nongnu.org, Beniamino Galvani , Peter Maydell , Strahinja Jankovic , Coiby Xu , Gerd Hoffmann , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Subject: Re: [RFC PATCH] Do not include "qemu/error-report.h" in headers that do not need it References: <20230210111931.1115489-1-thuth@redhat.com> Date: Fri, 10 Feb 2023 14:43:43 +0100 In-Reply-To: <20230210111931.1115489-1-thuth@redhat.com> (Thomas Huth's message of "Fri, 10 Feb 2023 12:19:31 +0100") Message-ID: <87zg9lpre8.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2023 13:43:52 -0000 Thomas Huth writes: > Include it in the .c files instead that use the error reporting > functions. > > Signed-off-by: Thomas Huth > --- > RFC since it's more lines of code - but I think it's still cleaner > this way. Yes, please! Reviewed-by: Markus Armbruster