From: "Alex Bennée" <alex.bennee@linaro.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Alexander Bulekov <alxndr@bu.edu>,
Chris Friedt <chrisfriedt@gmail.com>,
cfriedt@meta.com, qemu-devel@nongnu.org
Subject: Re: [v2] hw: misc: edu: fix 2 off-by-one errors
Date: Tue, 18 Oct 2022 10:18:49 +0100 [thread overview]
Message-ID: <87zgdtcwrv.fsf@linaro.org> (raw)
In-Reply-To: <380c1527-e664-f7c5-6d18-bf53d99aed33@kernel.org>
Jiri Slaby <jirislaby@kernel.org> writes:
> On 17. 10. 22, 16:13, Peter Maydell wrote:
>> * for situations where the guest has misprogrammed the device,
>> log that with qemu_log_mask(LOG_GUEST_ERROR, ...)
>> and continue with whatever the real hardware would do, or
>> some reasonable choice if the h/w spec is vague
>
> As I wrote in the previous mail, can we stop the machine after the
> print somehow, for example? So that the students have to "cont" in the
> qemu console as an acknowledgment when this happens.
You can bring the system to a halt with vm_stop(RUN_STATE_PAUSED) or
possible RUN_STATE_DEBUG?
I don't know how obnoxious the message should be at this point (i.e.
should it be masked by LOG_GUEST_ERROR) because if the system halts the
user might not notice. However I guess with this device they would be
expecting to check this sort of thing.
>
> thanks,
--
Alex Bennée
next prev parent reply other threads:[~2022-10-18 9:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 21:10 [v2] hw: misc: edu: fix 2 off-by-one errors Chris Friedt
2022-10-17 6:22 ` Jiri Slaby
2022-10-17 16:36 ` Christopher Friedt
2022-11-01 18:59 ` Christopher Friedt
2022-10-17 13:44 ` Alexander Bulekov
2022-10-17 14:13 ` Peter Maydell
2022-10-17 17:21 ` Alex Bennée
2022-10-17 22:05 ` Chris Friedt
2022-10-18 6:11 ` Alex Bennée
2022-10-18 6:30 ` Jiri Slaby
2022-10-18 9:18 ` Alex Bennée [this message]
2022-10-18 9:30 ` Peter Maydell
2022-10-18 12:11 ` Alex Bennée
2022-10-18 6:27 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgdtcwrv.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=alxndr@bu.edu \
--cc=cfriedt@meta.com \
--cc=chrisfriedt@gmail.com \
--cc=jirislaby@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.