From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2309C433FE for ; Tue, 4 Oct 2022 10:46:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:Subject:CC:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mw7L+ZAAzoaZ3BrQEoEPM1Dt58OlCawWHsUkUs09ulU=; b=HHQDxacc3nw47x tN11zOkCKPdm3qgUbTia2mLJXhhBfv2Pnbkj4mPQ5/DQCfaA/Jm3SxpT6mvep+dpLPrKoDmhz+52W dLdlIRGQODLsM910x0yG+lvIzORo1f0IZz/i0Bo8MbCVCkFDa7LL2Kmy6TWGLQIIrETQI6QQ7M1Ni 5Nws1tSIj//I75Gl6MWZPdtJrJiH+UN2nbaUqmRqSbrsID+s++s8TNmZ7SxKY3nba5jXZlVazD0AQ siu++dqijIYG5tha3yyt4zQjPVnJHNA4eXD10VA6++SAHBIss2T8p1A3M3V4x3SbdMZwFsqyPXm2f 8tlV0wRY0emMWctf1N4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1offQ2-009Ohv-E9; Tue, 04 Oct 2022 10:44:58 +0000 Received: from mail-dm6nam10on2051.outbound.protection.outlook.com ([40.107.93.51] helo=NAM10-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1offPz-009OhV-NV for linux-arm-kernel@lists.infradead.org; Tue, 04 Oct 2022 10:44:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UA+i9byxm459dPQb3RvNzCAUWLUNQ9lWVav9gVIlJ+5+LP70YXmCm9OR6KFN77bpy7fCv+j7Gz4eSINXRSWSY3CDrWAeztpBpghxGNQRGL6OpuLS21aJG86RQVSmI4KpQsBs4T7H7m/vi4FNPPSN43WULDf6w1arjEnVa64c35XBsab/yRJyle8AORfAohgtBsYrgAmlnvFgyh44NVMAqHYNp5t7D6TE4eIYSNICJEuwC9TO+Ty/oq0nH09VXqagJgh8m17NfGHfEK3EeNk6u3GvcRXLHNw8wiW5+L8vOR0nuNazg3795sNVzb+HlI5PhSnVRbBZOUGfTpbHxv6few== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BewjoptCVNNNylIM027ZWvyajObLnBKEI78+BWD2Y+k=; b=SGlthqEVRGF2Ea0uNM9PWm27An9zWo9NkXkw4xoHa96CM/VFFd7Gd4bfwdn+/CpJhBYw+w9gxlwGzqA/fqe4icymwUoZiLkrT9qGHAgUJ+vm01mq+52XRsK8XC2hlfyBnzGoLUdh8yuwNcjQEXziVNR+EDpWEpaKSZTKBATsA0ClK6mWLyDs4rojrLUbWdkPROg5QRkCmDY25EubTCLi7bdBXePenKU0hZHiea4FZD7HM6L7f8dlMb23NIch70LHmXRe4c++DrQXPUw8WGtYdcBL6MejmtOsblHwgHA7yfH8CUgmCcO6/6d7khikhahHu5qvDZT/991xa/mEcqGjKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BewjoptCVNNNylIM027ZWvyajObLnBKEI78+BWD2Y+k=; b=RGQAwaQLdYMKjTbAwOewdE16qd4yCpnw/jKk5Lph5XEQMacQ9QaACJOIxTbfVsMmuVDcv0OgSCVOGURLr/tksRyQIgVUKa6oWs7hhjuhetpPSj/VVwQOtEw6MNd5R3aZez7Io5OISE2CMgEXcMHqIy3fRXh+FuglvnvLm2YqbEmPf8N3lg4yJRXstMQyIg6CktVx+KPM8BItdiFM4Z6jVLR8RddHU0YMCs5UtXi0UIONrn9XWJrLFYba4JHa0lL2OvGB8mRIepEZNfSgs2d6yzxmQ0i763me/b1s81Zah2fV7o9EAmeaMt3NRh5ypEuHsBu9HPbwclfxEhlqqgAuWA== Received: from BN9PR03CA0629.namprd03.prod.outlook.com (2603:10b6:408:106::34) by PH7PR12MB7020.namprd12.prod.outlook.com (2603:10b6:510:1ba::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Tue, 4 Oct 2022 10:44:52 +0000 Received: from BN8NAM11FT100.eop-nam11.prod.protection.outlook.com (2603:10b6:408:106:cafe::c9) by BN9PR03CA0629.outlook.office365.com (2603:10b6:408:106::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.26 via Frontend Transport; Tue, 4 Oct 2022 10:44:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT100.mail.protection.outlook.com (10.13.177.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Tue, 4 Oct 2022 10:44:51 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Tue, 4 Oct 2022 03:44:47 -0700 Received: from yaviefel (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Tue, 4 Oct 2022 03:44:42 -0700 References: <20220929185207.2183473-1-daniel.machon@microchip.com> <20220929185207.2183473-2-daniel.machon@microchip.com> <87leq1uiyc.fsf@nvidia.com> <20220930175452.1937dadd@kernel.org> <87pmf9xrrd.fsf@nvidia.com> <20221003092522.6aaa6d55@kernel.org> User-agent: mu4e 1.6.6; emacs 28.1 From: Petr Machata To: Jakub Kicinski CC: Petr Machata , Daniel Machon , , , , , , , , , , , , , , , , Subject: Re: [PATCH net-next v2 1/6] net: dcb: add new pcp selector to app object Date: Tue, 4 Oct 2022 12:20:04 +0200 In-Reply-To: <20221003092522.6aaa6d55@kernel.org> Message-ID: <87zgebx3zb.fsf@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT100:EE_|PH7PR12MB7020:EE_ X-MS-Office365-Filtering-Correlation-Id: c4fe5a54-0dc2-44d5-00cc-08daa5f577aa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DXlD1Xb2V3GYvEV4rz5ftnWH1ZC/ak0VLKJNenr1pAlPxjjTr8L4sp+jMV92Zrnx/Z1tfJefY2i1iE6kx1GYvA63GAddspO2jeg6Mq3wE0mxm8ECq0bMRcgk/P5caP1q/BXUIydekNihB986r42/gqey4tWvufOVXnLoiYVTEE6rJ04mKYdj9P1KjUPt/QTKbXJV4mMY+YVQNHcxlLiTyMCew28zbnrOy0bkq2Gvfe4ibqtrgmIcmOjBOWAKTvHdB8+2Jh+SGspnZk8F3ZLMk2IGk73omLbUyRk7Ue/eEbIg4f6zBMlFflIIba3jNko+PPIhrmF+HhcrKXKTHUeTe0Q8MKzp9+2qX8iLlHwOFoYBqI055U68jZEGzEG6NDmp+eYOtZnhbTd8uZi6ySY1q7b58X+gshgBKjHavdXbRM2NLgpeedwRHfx4r7v+FRbdJ8+UXh3eygnte8CqB8Yts9nvpdy+f2FYgt9fjsXYF3l6gLkwUhguRNInCW6Nj2141VcLxfXojfX46GM3RmVWOKlSDCTnvS6nVuXxQ/mcelwcAcMnB3H+uBtNidtrXIiRtNGSM+JJBx4/zNOUTPN+tHuEcOQ6cgn9YKeYk6cfHcmd6GyB++vAjJVtr8xN2AYLNfBF7CeX8gTao7PVkoS/bvVFmPY4ezZD7D50HGQpr6obM2NtekGIhyEJh7cpyNzPHsXRmADvSr9gk7SSKjqaZ164ONfp1BBJKChx13fLhxtc1wxlYJOeMY97jHbIcRUVu/XaUJ34Twk7Mff49kIT/Q== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(396003)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(54906003)(478600001)(82310400005)(8936002)(41300700001)(36756003)(7416002)(4326008)(316002)(8676002)(4744005)(70206006)(5660300002)(70586007)(36860700001)(2616005)(40460700003)(82740400003)(7636003)(40480700001)(356005)(6666004)(86362001)(26005)(6916009)(336012)(16526019)(47076005)(426003)(186003)(2906002)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 10:44:51.7672 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c4fe5a54-0dc2-44d5-00cc-08daa5f577aa X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT100.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7020 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221004_034456_017144_B3BE6BE9 X-CRM114-Status: GOOD ( 14.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Jakub Kicinski writes: > On Mon, 3 Oct 2022 09:52:59 +0200 Petr Machata wrote: >> I assumed the policy is much more strict with changes like this. If you >> think it's OK, I'm fine with it as well. >> >> The userspace (lldpad in particular) is doing the opposite thing BTW: >> assuming everything in the nest is a DCB_ATTR_IEEE_APP. When we start >> emitting the new attribute, it will get confused. > > Can you add an attribute or a flag to the request which would turn > emitting the new attrs on? The question is whether it's better to do it anyway. My opinion is that if a userspace decides to make assumptions about the contents of a TLV, and neglects to validate the actual TLV type, it's on them, and I'm not obligated to keep them working. We know about this case, but really any attribute addition at all could potentially trip some userspace if they expected something else at this offset. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09671C433FE for ; Tue, 4 Oct 2022 10:45:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229684AbiJDKpA (ORCPT ); Tue, 4 Oct 2022 06:45:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbiJDKo4 (ORCPT ); Tue, 4 Oct 2022 06:44:56 -0400 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2075.outbound.protection.outlook.com [40.107.93.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A98A512601; Tue, 4 Oct 2022 03:44:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UA+i9byxm459dPQb3RvNzCAUWLUNQ9lWVav9gVIlJ+5+LP70YXmCm9OR6KFN77bpy7fCv+j7Gz4eSINXRSWSY3CDrWAeztpBpghxGNQRGL6OpuLS21aJG86RQVSmI4KpQsBs4T7H7m/vi4FNPPSN43WULDf6w1arjEnVa64c35XBsab/yRJyle8AORfAohgtBsYrgAmlnvFgyh44NVMAqHYNp5t7D6TE4eIYSNICJEuwC9TO+Ty/oq0nH09VXqagJgh8m17NfGHfEK3EeNk6u3GvcRXLHNw8wiW5+L8vOR0nuNazg3795sNVzb+HlI5PhSnVRbBZOUGfTpbHxv6few== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BewjoptCVNNNylIM027ZWvyajObLnBKEI78+BWD2Y+k=; b=SGlthqEVRGF2Ea0uNM9PWm27An9zWo9NkXkw4xoHa96CM/VFFd7Gd4bfwdn+/CpJhBYw+w9gxlwGzqA/fqe4icymwUoZiLkrT9qGHAgUJ+vm01mq+52XRsK8XC2hlfyBnzGoLUdh8yuwNcjQEXziVNR+EDpWEpaKSZTKBATsA0ClK6mWLyDs4rojrLUbWdkPROg5QRkCmDY25EubTCLi7bdBXePenKU0hZHiea4FZD7HM6L7f8dlMb23NIch70LHmXRe4c++DrQXPUw8WGtYdcBL6MejmtOsblHwgHA7yfH8CUgmCcO6/6d7khikhahHu5qvDZT/991xa/mEcqGjKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BewjoptCVNNNylIM027ZWvyajObLnBKEI78+BWD2Y+k=; b=RGQAwaQLdYMKjTbAwOewdE16qd4yCpnw/jKk5Lph5XEQMacQ9QaACJOIxTbfVsMmuVDcv0OgSCVOGURLr/tksRyQIgVUKa6oWs7hhjuhetpPSj/VVwQOtEw6MNd5R3aZez7Io5OISE2CMgEXcMHqIy3fRXh+FuglvnvLm2YqbEmPf8N3lg4yJRXstMQyIg6CktVx+KPM8BItdiFM4Z6jVLR8RddHU0YMCs5UtXi0UIONrn9XWJrLFYba4JHa0lL2OvGB8mRIepEZNfSgs2d6yzxmQ0i763me/b1s81Zah2fV7o9EAmeaMt3NRh5ypEuHsBu9HPbwclfxEhlqqgAuWA== Received: from BN9PR03CA0629.namprd03.prod.outlook.com (2603:10b6:408:106::34) by PH7PR12MB7020.namprd12.prod.outlook.com (2603:10b6:510:1ba::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Tue, 4 Oct 2022 10:44:52 +0000 Received: from BN8NAM11FT100.eop-nam11.prod.protection.outlook.com (2603:10b6:408:106:cafe::c9) by BN9PR03CA0629.outlook.office365.com (2603:10b6:408:106::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.26 via Frontend Transport; Tue, 4 Oct 2022 10:44:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT100.mail.protection.outlook.com (10.13.177.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Tue, 4 Oct 2022 10:44:51 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Tue, 4 Oct 2022 03:44:47 -0700 Received: from yaviefel (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Tue, 4 Oct 2022 03:44:42 -0700 References: <20220929185207.2183473-1-daniel.machon@microchip.com> <20220929185207.2183473-2-daniel.machon@microchip.com> <87leq1uiyc.fsf@nvidia.com> <20220930175452.1937dadd@kernel.org> <87pmf9xrrd.fsf@nvidia.com> <20221003092522.6aaa6d55@kernel.org> User-agent: mu4e 1.6.6; emacs 28.1 From: Petr Machata To: Jakub Kicinski CC: Petr Machata , Daniel Machon , , , , , , , , , , , , , , , , Subject: Re: [PATCH net-next v2 1/6] net: dcb: add new pcp selector to app object Date: Tue, 4 Oct 2022 12:20:04 +0200 In-Reply-To: <20221003092522.6aaa6d55@kernel.org> Message-ID: <87zgebx3zb.fsf@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT100:EE_|PH7PR12MB7020:EE_ X-MS-Office365-Filtering-Correlation-Id: c4fe5a54-0dc2-44d5-00cc-08daa5f577aa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DXlD1Xb2V3GYvEV4rz5ftnWH1ZC/ak0VLKJNenr1pAlPxjjTr8L4sp+jMV92Zrnx/Z1tfJefY2i1iE6kx1GYvA63GAddspO2jeg6Mq3wE0mxm8ECq0bMRcgk/P5caP1q/BXUIydekNihB986r42/gqey4tWvufOVXnLoiYVTEE6rJ04mKYdj9P1KjUPt/QTKbXJV4mMY+YVQNHcxlLiTyMCew28zbnrOy0bkq2Gvfe4ibqtrgmIcmOjBOWAKTvHdB8+2Jh+SGspnZk8F3ZLMk2IGk73omLbUyRk7Ue/eEbIg4f6zBMlFflIIba3jNko+PPIhrmF+HhcrKXKTHUeTe0Q8MKzp9+2qX8iLlHwOFoYBqI055U68jZEGzEG6NDmp+eYOtZnhbTd8uZi6ySY1q7b58X+gshgBKjHavdXbRM2NLgpeedwRHfx4r7v+FRbdJ8+UXh3eygnte8CqB8Yts9nvpdy+f2FYgt9fjsXYF3l6gLkwUhguRNInCW6Nj2141VcLxfXojfX46GM3RmVWOKlSDCTnvS6nVuXxQ/mcelwcAcMnB3H+uBtNidtrXIiRtNGSM+JJBx4/zNOUTPN+tHuEcOQ6cgn9YKeYk6cfHcmd6GyB++vAjJVtr8xN2AYLNfBF7CeX8gTao7PVkoS/bvVFmPY4ezZD7D50HGQpr6obM2NtekGIhyEJh7cpyNzPHsXRmADvSr9gk7SSKjqaZ164ONfp1BBJKChx13fLhxtc1wxlYJOeMY97jHbIcRUVu/XaUJ34Twk7Mff49kIT/Q== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(396003)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(54906003)(478600001)(82310400005)(8936002)(41300700001)(36756003)(7416002)(4326008)(316002)(8676002)(4744005)(70206006)(5660300002)(70586007)(36860700001)(2616005)(40460700003)(82740400003)(7636003)(40480700001)(356005)(6666004)(86362001)(26005)(6916009)(336012)(16526019)(47076005)(426003)(186003)(2906002)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 10:44:51.7672 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c4fe5a54-0dc2-44d5-00cc-08daa5f577aa X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT100.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7020 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jakub Kicinski writes: > On Mon, 3 Oct 2022 09:52:59 +0200 Petr Machata wrote: >> I assumed the policy is much more strict with changes like this. If you >> think it's OK, I'm fine with it as well. >> >> The userspace (lldpad in particular) is doing the opposite thing BTW: >> assuming everything in the nest is a DCB_ATTR_IEEE_APP. When we start >> emitting the new attribute, it will get confused. > > Can you add an attribute or a flag to the request which would turn > emitting the new attrs on? The question is whether it's better to do it anyway. My opinion is that if a userspace decides to make assumptions about the contents of a TLV, and neglects to validate the actual TLV type, it's on them, and I'm not obligated to keep them working. We know about this case, but really any attribute addition at all could potentially trip some userspace if they expected something else at this offset.