All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Jakub Kicinski <kuba@kernel.org>, menglong8.dong@gmail.com
Cc: sfr@canb.auug.org.au, bagasdotme@gmail.com,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Menglong Dong <imagedong@tencent.com>
Subject: Re: [PATCH net-next v2] docs/conf.py: add function attribute '__fix_address' to conf.py
Date: Fri, 26 Aug 2022 16:14:45 -0600	[thread overview]
Message-ID: <87zgfqsld6.fsf@meer.lwn.net> (raw)
In-Reply-To: <874jxyu32m.fsf@meer.lwn.net>

Jonathan Corbet <corbet@lwn.net> writes:

> Jakub Kicinski <kuba@kernel.org> writes:
>
>> On Sat, 27 Aug 2022 00:01:50 +0800 menglong8.dong@gmail.com wrote:
>>> From: Menglong Dong <imagedong@tencent.com>
>>> 
>>> Stephen Rothwell reported htmldocs warning when merging net-next:
>>> 
>>> Documentation/networking/kapi:26: net/core/skbuff.c:780: WARNING: Error in declarator or parameters
>>> Invalid C declaration: Expecting "(" in parameters. [error at 19]
>>>   void __fix_address kfree_skb_reason (struct sk_buff *skb, enum skb_drop_reason reason)
>>>   -------------------^
>>> 
>>> Add __fix_address keyword to c_id_attributes array in conf.py to fix
>>> the warning.
>>
>> You'll need to CC netdev@ for the patch to get into the net-next tree.
>> Since this is a pure Documentation/ patch get_maintainer.pl did not
>> produce netdev@ in the recommended addresses.
>>
>> Please wait for a review/ack from Jon before reposting, we need his
>> permission to apply this patch.
>
> I could also just carry it through docs; I'm about to send a set of
> fixes Linusward in any case.  I wanted to run a couple of tests to be
> sure, but I don't expect any problems with it...

The patch is clearly correct, it can go in via whatever path seems most
suitable.  Let me know if you'd like me to push it; otherwise:

Acked-by: Jonathan Corbet <corbet@lwn.net>

Thanks,

jon

  reply	other threads:[~2022-08-26 22:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-26 16:01 [PATCH net-next v2] docs/conf.py: add function attribute '__fix_address' to conf.py menglong8.dong
2022-08-26 20:58 ` Jakub Kicinski
2022-08-26 21:06   ` Jonathan Corbet
2022-08-26 22:14     ` Jonathan Corbet [this message]
2022-08-26 22:27       ` Jakub Kicinski
2022-08-26 22:43         ` Jonathan Corbet
2022-08-27  4:21           ` Menglong Dong
2022-08-27 15:08             ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgfqsld6.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=bagasdotme@gmail.com \
    --cc=imagedong@tencent.com \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menglong8.dong@gmail.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.