From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DAC6C433F5 for ; Fri, 6 May 2022 10:24:12 +0000 (UTC) Received: from localhost ([::1]:54238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmv87-0005Mn-5M for qemu-devel@archiver.kernel.org; Fri, 06 May 2022 06:24:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmv6g-0004Id-W1 for qemu-devel@nongnu.org; Fri, 06 May 2022 06:22:43 -0400 Received: from us-smtp-delivery-74.mimecast.com ([170.10.129.74]:46569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmv6e-0001aB-9c for qemu-devel@nongnu.org; Fri, 06 May 2022 06:22:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651832559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QLAt8uHQIXVw3MeEE0ofEdVrn3hA1PKzNYAemKQSYkE=; b=O4hepMEdmAsMtF9SHemmFhUKF5dsgNC+5f+czwRRKUeNl1YxocfJNp0ypelu0Rl6b3+UTM Kj7zzr3URCfGYyVMQT6SdIEPAk7CDGGfIMCqGgW5Nkx/sgMklb0XVw2QVdX8ZuD979f8yH WbgDooz2UbhYAlXnY1EhFMrZnIUQtTg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-475-s9wVikOdNPC1gima8J6f0g-1; Fri, 06 May 2022 06:22:35 -0400 X-MC-Unique: s9wVikOdNPC1gima8J6f0g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E63F786B8BE; Fri, 6 May 2022 10:22:34 +0000 (UTC) Received: from localhost (unknown [10.39.193.152]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8826740CFD34; Fri, 6 May 2022 10:22:34 +0000 (UTC) From: Cornelia Huck To: Thomas Huth , qemu-s390x@nongnu.org, Eric Farman , Christian Borntraeger , Halil Pasic Cc: qemu-devel@nongnu.org, David Hildenbrand Subject: Re: [PATCH] hw/s390x/s390-virtio-ccw: Improve the machine description string In-Reply-To: <27272743-d039-e30e-0f5d-1062f7fdb23a@redhat.com> Organization: Red Hat GmbH References: <20220506065026.513590-1-thuth@redhat.com> <878rrf5dkw.fsf@redhat.com> <27272743-d039-e30e-0f5d-1062f7fdb23a@redhat.com> User-Agent: Notmuch/0.34 (https://notmuchmail.org) Date: Fri, 06 May 2022 12:22:32 +0200 Message-ID: <87zgjv3qqf.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Received-SPF: pass client-ip=170.10.129.74; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-74.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, May 06 2022, Thomas Huth wrote: > On 06/05/2022 09.23, Cornelia Huck wrote: >> On Fri, May 06 2022, Thomas Huth wrote: >> >>> The machine name already contains the words "ccw" and "virtio", so >>> using "VirtIO-ccw" in the description likely does not really help >>> the average user to get an idea what this machine type is about. >>> Thus let's switch to "Virtual s390x machine" now, since "virtual >>> machine" should be a familiar term, and "s390x" signals that this >>> is about 64-bit guests (unlike S390 which could mean that it is >>> 31-bit only). >> >> Do we foresee any s390x machines that don't default to ccw virtio >> devices in the future? > > I don't think so. And if we ever get another type of para-virtualized > machine, we still can change the description again to be more specific to > distinguish them. Fair enough. Acked-by: Cornelia Huck > >>> Also expand "v" to "version, since this makes it easier to use >> >> s/"version/"version"/ :) > > Thanks! > >>> this macro also with non-numeric machine names in downstream. >>> >>> Signed-off-by: Thomas Huth >>> --- >>> hw/s390x/s390-virtio-ccw.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c >>> index 8fa488d13a..11a942a325 100644 >>> --- a/hw/s390x/s390-virtio-ccw.c >>> +++ b/hw/s390x/s390-virtio-ccw.c >>> @@ -768,7 +768,7 @@ bool css_migration_enabled(void) >>> { \ >>> MachineClass *mc = MACHINE_CLASS(oc); \ >>> ccw_machine_##suffix##_class_options(mc); \ >>> - mc->desc = "VirtIO-ccw based S390 machine v" verstr; \ >>> + mc->desc = "Virtual s390x machine (version " verstr ")"; \ >>> if (latest) { \ >>> mc->alias = "s390-ccw-virtio"; \ >>> mc->is_default = true; \ >> > > Thomas