From: Kurt Kanzenbach <kurt@linutronix.de>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
Kamil Alkhouri <kamil.alkhouri@hs-offenburg.de>,
netdev@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: hellcreek: Allow PTP on blocked ports
Date: Tue, 14 Dec 2021 09:13:34 +0100 [thread overview]
Message-ID: <87zgp338pd.fsf@kurt> (raw)
In-Reply-To: <20211213121406.GB14042@hoboy.vegasvil.org>
[-- Attachment #1: Type: text/plain, Size: 785 bytes --]
Hi Richard,
On Mon Dec 13 2021, Richard Cochran wrote:
> On Mon, Dec 13, 2021 at 11:18:10AM +0100, Kurt Kanzenbach wrote:
>
>> @@ -1055,7 +1058,7 @@ static int hellcreek_setup_fdb(struct hellcreek *hellcreek)
>> .portmask = 0x03, /* Management ports */
>> .age = 0,
>> .is_obt = 0,
>> - .pass_blocked = 0,
>> + .pass_blocked = 1,
>
> This one should stay blocked.
You're right. I confirmed with Hirschmann. Only peer delay measurements
should be allowed on blocked ports. In addition, we also have to add
static entries for STP with pass_blocked bit set. Furthermore, the UDP
entries are missing as well. Currently it only works for 802.1AS even
though the driver happily announces V2_EVENT capability.
I'll clean it up and resend properly.
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
prev parent reply other threads:[~2021-12-14 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 10:18 [PATCH net] net: dsa: hellcreek: Allow PTP on blocked ports Kurt Kanzenbach
2021-12-13 12:14 ` Richard Cochran
2021-12-14 8:13 ` Kurt Kanzenbach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgp338pd.fsf@kurt \
--to=kurt@linutronix.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kamil.alkhouri@hs-offenburg.de \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=richardcochran@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.