From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Thiago Perrotta <tbperrotta@gmail.com>
Cc: carenas@gmail.com, gitster@pobox.com, bagasdotme@gmail.com,
git@vger.kernel.org
Subject: Re: [PATCH v4 0/3] send-email: shell completion improvements
Date: Thu, 23 Sep 2021 16:02:50 +0200 [thread overview]
Message-ID: <87zgs34ccx.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20210921155152.4215-1-tbperrotta@gmail.com>
On Tue, Sep 21 2021, Thiago Perrotta wrote:
Note: using --in-reply-to to the previous version in "git format-patch"
helps keep track of the context.
> Carlo suggests to generate the flags programatically from the perl
> script. I am looking into this and already have a proof-of-concept
> working and plan to submit it as a separate patch series. I would like
> to get this series checked in first though.
Isn't this just:
my @params = <getopts list>;
GetOptions(@params);
And then doing some light parsing/slicinng of the @params list to get
the keys you've duplicated here?
I for one would much prefer to see that go in right away than the churn
of first hardcoding these, then removing the hardcoding etc.
next prev parent reply other threads:[~2021-09-23 14:04 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 0:46 [PATCH v2 0/3] send-email: shell completion improvements Thiago Perrotta
2021-08-20 0:46 ` [PATCH v2 1/3] send-email: print newline for --git-completion-helper Thiago Perrotta
2021-08-20 20:17 ` Junio C Hamano
2021-08-28 3:08 ` [PATCH v3 0/3] send-email: shell completion improvements Thiago Perrotta
2021-08-28 3:08 ` [PATCH v3 1/3] send-email: terminate --git-completion-helper with LF Thiago Perrotta
2021-08-28 3:08 ` [PATCH v3 2/3] send-email: move bash completions to core script Thiago Perrotta
2021-08-28 5:25 ` Carlo Arenas
2021-09-07 0:16 ` [PATCH] " Thiago Perrotta
2021-09-07 1:28 ` Carlo Arenas
2021-09-21 15:51 ` [PATCH v4 0/3] send-email: shell completion improvements Thiago Perrotta
2021-09-21 15:51 ` [PATCH v4 1/3] send-email: terminate --git-completion-helper with LF Thiago Perrotta
2021-09-21 15:51 ` [PATCH v4 2/3] send-email: move bash completions to core script Thiago Perrotta
2021-09-21 15:51 ` [PATCH v4 3/3] send-email docs: add format-patch options Thiago Perrotta
2021-09-23 14:02 ` Ævar Arnfjörð Bjarmason [this message]
2021-09-24 2:46 ` [PATCH v5 0/3] send-email: shell completion improvements Thiago Perrotta
2021-09-24 20:02 ` Ævar Arnfjörð Bjarmason
2021-09-30 3:10 ` Thiago Perrotta
2021-10-07 3:36 ` [PATCH v6 " Thiago Perrotta
2021-10-07 3:36 ` [PATCH v6 1/3] send-email: terminate --git-completion-helper with LF Thiago Perrotta
2021-10-07 3:36 ` [PATCH v6 2/3] send-email: programmatically generate bash completions Thiago Perrotta
2021-10-09 6:38 ` Carlo Marcelo Arenas Belón
2021-10-11 4:10 ` [PATCH v7 0/3] send-email: shell completion improvements Thiago Perrotta
2021-10-11 13:46 ` Ævar Arnfjörð Bjarmason
2021-10-11 17:12 ` [DRAFT/WIP PATCH] send-email: programmatically generate bash completions Thiago Perrotta
2021-10-25 21:27 ` [PATCH v8 0/2] send-email: shell completion improvements Thiago Perrotta
2021-10-25 22:44 ` Ævar Arnfjörð Bjarmason
2021-10-26 0:48 ` Ævar Arnfjörð Bjarmason
2021-10-28 16:31 ` Junio C Hamano
2021-10-25 21:27 ` [PATCH v8 1/2] send-email: programmatically generate bash completions Thiago Perrotta
2021-10-25 21:27 ` [PATCH v8 2/2] send-email docs: add format-patch options Thiago Perrotta
2021-10-11 4:10 ` [PATCH v7 1/3] send-email: terminate --git-completion-helper with LF Thiago Perrotta
2021-10-11 4:10 ` [PATCH v7 2/3] send-email: programmatically generate bash completions Thiago Perrotta
2021-10-11 4:10 ` [PATCH v7 3/3] send-email docs: add format-patch options Thiago Perrotta
2021-10-07 3:36 ` [PATCH v6 " Thiago Perrotta
2021-10-09 8:31 ` [RFC PATCH] Documentation: better document format-patch options in send-email Carlo Marcelo Arenas Belón
2021-10-09 8:57 ` Bagas Sanjaya
2021-10-09 9:32 ` Carlo Arenas
2021-10-09 11:04 ` Bagas Sanjaya
2021-10-10 21:33 ` Junio C Hamano
2021-09-24 2:46 ` [PATCH v5 1/3] send-email: terminate --git-completion-helper with LF Thiago Perrotta
2021-09-24 2:46 ` [PATCH v5 2/3] send-email: programmatically generate bash completions Thiago Perrotta
2021-09-24 2:46 ` [PATCH v5 3/3] send-email docs: add format-patch options Thiago Perrotta
2021-09-24 4:36 ` Bagas Sanjaya
2021-09-24 4:53 ` Carlo Arenas
2021-09-24 6:19 ` Bagas Sanjaya
2021-09-24 6:56 ` Carlo Arenas
2021-09-24 15:33 ` Junio C Hamano
2021-09-24 17:34 ` Carlo Arenas
2021-09-24 20:03 ` Junio C Hamano
2021-09-25 3:03 ` Bagas Sanjaya
2021-09-25 4:07 ` Junio C Hamano
2021-09-25 6:13 ` Carlo Marcelo Arenas Belón
2021-09-29 21:20 ` Junio C Hamano
2021-08-28 3:08 ` [PATCH v3 " Thiago Perrotta
2021-08-28 5:22 ` Bagas Sanjaya
2021-08-20 0:46 ` [PATCH v2 2/3] send-email: move bash completions to the perl script Thiago Perrotta
2021-08-20 0:46 ` [PATCH v2 3/3] send-email docs: mention format-patch options Thiago Perrotta
2021-08-20 20:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgs34ccx.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tbperrotta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.