From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADDCDC4338F for ; Mon, 23 Aug 2021 16:57:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83A9A61368 for ; Mon, 23 Aug 2021 16:57:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229977AbhHWQ5y convert rfc822-to-8bit (ORCPT ); Mon, 23 Aug 2021 12:57:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:43906 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbhHWQ5x (ORCPT ); Mon, 23 Aug 2021 12:57:53 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3536061284; Mon, 23 Aug 2021 16:57:11 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mIDG1-006hjB-5c; Mon, 23 Aug 2021 17:57:09 +0100 Date: Mon, 23 Aug 2021 17:57:08 +0100 Message-ID: <87zgt8p09n.wl-maz@kernel.org> From: Marc Zyngier To: Pali =?UTF-8?B?Um9ow6Fy?= , Kunihiko Hayashi Cc: Lorenzo Pieralisi , Rob Herring , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Bjorn Helgaas , Masami Hiramatsu , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: uniphier: Serialize INTx masking/unmasking In-Reply-To: <20210823150927.jhobzfxy6e4s663r@pali> References: <1629717500-19396-1-git-send-email-hayashi.kunihiko@socionext.com> <20210823150927.jhobzfxy6e4s663r@pali> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: pali@kernel.org, hayashi.kunihiko@socionext.com, lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com, bhelgaas@google.com, mhiramat@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, 23 Aug 2021 16:09:27 +0100, Pali Rohár wrote: > > + Marc (who originally reported this issue) > > On Monday 23 August 2021 20:18:20 Kunihiko Hayashi wrote: > > The condition register PCI_RCV_INTX is used in irq_mask(), irq_unmask() > > and irq_ack() callbacks. Accesses to register can occur at the same time > > without a lock. > > Add a lock into each callback to prevent the issue. > > > > Fixes: 7e6d5cd88a6f ("PCI: uniphier: Add UniPhier PCIe host controller support") > > Suggested-by: Pali Rohár > > Signed-off-by: Kunihiko Hayashi > > Acked-by: Pali Rohár > > > --- > > drivers/pci/controller/dwc/pcie-uniphier.c | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > The previous patch is as follows: > > https://lore.kernel.org/linux-pci/1629370566-29984-1-git-send-email-hayashi.kunihiko@socionext.com/ > > > > Changes in the previous patch: > > - Change the subject and commit message > > > > diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c b/drivers/pci/controller/dwc/pcie-uniphier.c > > index ebe43e9..5075714 100644 > > --- a/drivers/pci/controller/dwc/pcie-uniphier.c > > +++ b/drivers/pci/controller/dwc/pcie-uniphier.c > > @@ -186,12 +186,17 @@ static void uniphier_pcie_irq_ack(struct irq_data *d) > > struct pcie_port *pp = irq_data_get_irq_chip_data(d); > > struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > > struct uniphier_pcie_priv *priv = to_uniphier_pcie(pci); > > + unsigned long flags; > > u32 val; > > > > + raw_spin_lock_irqsave(&pp->lock, flags); > > + > > val = readl(priv->base + PCL_RCV_INTX); > > val &= ~PCL_RCV_INTX_ALL_STATUS; > > val |= BIT(irqd_to_hwirq(d) + PCL_RCV_INTX_STATUS_SHIFT); > > writel(val, priv->base + PCL_RCV_INTX); > > + > > + raw_spin_unlock_irqrestore(&pp->lock, flags); > > } > > > > static void uniphier_pcie_irq_mask(struct irq_data *d) > > @@ -199,12 +204,17 @@ static void uniphier_pcie_irq_mask(struct irq_data *d) > > struct pcie_port *pp = irq_data_get_irq_chip_data(d); > > struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > > struct uniphier_pcie_priv *priv = to_uniphier_pcie(pci); > > + unsigned long flags; > > u32 val; > > > > + raw_spin_lock_irqsave(&pp->lock, flags); > > + > > val = readl(priv->base + PCL_RCV_INTX); > > val &= ~PCL_RCV_INTX_ALL_MASK; > > val |= BIT(irqd_to_hwirq(d) + PCL_RCV_INTX_MASK_SHIFT); This looks extremely suspicious. You clear all the INTX mask bits, and only set the one you need. How about the pre-existing bits? > > writel(val, priv->base + PCL_RCV_INTX); > > + > > + raw_spin_unlock_irqrestore(&pp->lock, flags); > > } > > > > static void uniphier_pcie_irq_unmask(struct irq_data *d) > > @@ -212,12 +222,17 @@ static void uniphier_pcie_irq_unmask(struct irq_data *d) > > struct pcie_port *pp = irq_data_get_irq_chip_data(d); > > struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > > struct uniphier_pcie_priv *priv = to_uniphier_pcie(pci); > > + unsigned long flags; > > u32 val; > > > > + raw_spin_lock_irqsave(&pp->lock, flags); > > + > > val = readl(priv->base + PCL_RCV_INTX); > > val &= ~PCL_RCV_INTX_ALL_MASK; > > val &= ~BIT(irqd_to_hwirq(d) + PCL_RCV_INTX_MASK_SHIFT); And by the same token, this second line is totally useless. I think masking/unmasking is broken in this driver, locking or not. M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43DC7C4338F for ; Mon, 23 Aug 2021 16:59:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D92A61368 for ; Mon, 23 Aug 2021 16:59:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0D92A61368 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8RNvlvLnHw8wNyvh0W46N1LM1To/v8zI05Q04lD29qo=; b=VcHmuUr6HO53mY Oy9+Aha2hBlzTr/snrTjpaNeqBxr8Q58Bab+txQGTdFxkRpL50Zh5JTBqHpW1tjMK+3auWV8OyD2A YEaBNl4XS5wZkgjmCDgxMTUWr5rr8EMWIVBeORNnqLzUSf3KJ1SiLwNEz+z1D398Cej6+Ti/OhCbO lWlPoRsR0R3Gobh9pGrKSb29qaUAYAvul1vBAP9HGaBvpTzpAZFEkqOve2/TNSh5Z9/bJT/VrFEQU LyVGpJTbi9AlSBxWVoDGLzEbBwMBBwNk3sEx5V8c1Hvg0YrEy4kWH94RL7ig+xRT/kxaeDNByqfUP RDH8JMyNHolFnrdl/tng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIDG7-00041I-CR; Mon, 23 Aug 2021 16:57:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIDG3-00040Y-HE for linux-arm-kernel@lists.infradead.org; Mon, 23 Aug 2021 16:57:13 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3536061284; Mon, 23 Aug 2021 16:57:11 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mIDG1-006hjB-5c; Mon, 23 Aug 2021 17:57:09 +0100 Date: Mon, 23 Aug 2021 17:57:08 +0100 Message-ID: <87zgt8p09n.wl-maz@kernel.org> From: Marc Zyngier To: Pali =?UTF-8?B?Um9ow6Fy?= , Kunihiko Hayashi Cc: Lorenzo Pieralisi , Rob Herring , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Bjorn Helgaas , Masami Hiramatsu , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: uniphier: Serialize INTx masking/unmasking In-Reply-To: <20210823150927.jhobzfxy6e4s663r@pali> References: <1629717500-19396-1-git-send-email-hayashi.kunihiko@socionext.com> <20210823150927.jhobzfxy6e4s663r@pali> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: pali@kernel.org, hayashi.kunihiko@socionext.com, lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com, bhelgaas@google.com, mhiramat@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210823_095711_646693_A7E9D0D9 X-CRM114-Status: GOOD ( 27.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyMyBBdWcgMjAyMSAxNjowOToyNyArMDEwMCwKUGFsaSBSb2jDoXIgPHBhbGlAa2Vy bmVsLm9yZz4gd3JvdGU6Cj4gCj4gKyBNYXJjICh3aG8gb3JpZ2luYWxseSByZXBvcnRlZCB0aGlz IGlzc3VlKQo+IAo+IE9uIE1vbmRheSAyMyBBdWd1c3QgMjAyMSAyMDoxODoyMCBLdW5paGlrbyBI YXlhc2hpIHdyb3RlOgo+ID4gVGhlIGNvbmRpdGlvbiByZWdpc3RlciBQQ0lfUkNWX0lOVFggaXMg dXNlZCBpbiBpcnFfbWFzaygpLCBpcnFfdW5tYXNrKCkKPiA+IGFuZCBpcnFfYWNrKCkgY2FsbGJh Y2tzLiBBY2Nlc3NlcyB0byByZWdpc3RlciBjYW4gb2NjdXIgYXQgdGhlIHNhbWUgdGltZQo+ID4g d2l0aG91dCBhIGxvY2suCj4gPiBBZGQgYSBsb2NrIGludG8gZWFjaCBjYWxsYmFjayB0byBwcmV2 ZW50IHRoZSBpc3N1ZS4KPiA+IAo+ID4gRml4ZXM6IDdlNmQ1Y2Q4OGE2ZiAoIlBDSTogdW5pcGhp ZXI6IEFkZCBVbmlQaGllciBQQ0llIGhvc3QgY29udHJvbGxlciBzdXBwb3J0IikKPiA+IFN1Z2dl c3RlZC1ieTogUGFsaSBSb2jDoXIgPHBhbGlAa2VybmVsLm9yZz4KPiA+IFNpZ25lZC1vZmYtYnk6 IEt1bmloaWtvIEhheWFzaGkgPGhheWFzaGkua3VuaWhpa29Ac29jaW9uZXh0LmNvbT4KPiAKPiBB Y2tlZC1ieTogUGFsaSBSb2jDoXIgPHBhbGlAa2VybmVsLm9yZz4KPiAKPiA+IC0tLQo+ID4gIGRy aXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtdW5pcGhpZXIuYyB8IDE1ICsrKysrKysrKysr KysrKwo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspCj4gPiAKPiA+IFRoZSBw cmV2aW91cyBwYXRjaCBpcyBhcyBmb2xsb3dzOgo+ID4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcv bGludXgtcGNpLzE2MjkzNzA1NjYtMjk5ODQtMS1naXQtc2VuZC1lbWFpbC1oYXlhc2hpLmt1bmlo aWtvQHNvY2lvbmV4dC5jb20vCj4gPiAKPiA+IENoYW5nZXMgaW4gdGhlIHByZXZpb3VzIHBhdGNo Ogo+ID4gLSBDaGFuZ2UgdGhlIHN1YmplY3QgYW5kIGNvbW1pdCBtZXNzYWdlCj4gPiAKPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLXVuaXBoaWVyLmMgYi9k cml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLXVuaXBoaWVyLmMKPiA+IGluZGV4IGViZTQz ZTkuLjUwNzU3MTQgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9w Y2llLXVuaXBoaWVyLmMKPiA+ICsrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUt dW5pcGhpZXIuYwo+ID4gQEAgLTE4NiwxMiArMTg2LDE3IEBAIHN0YXRpYyB2b2lkIHVuaXBoaWVy X3BjaWVfaXJxX2FjayhzdHJ1Y3QgaXJxX2RhdGEgKmQpCj4gPiAgCXN0cnVjdCBwY2llX3BvcnQg KnBwID0gaXJxX2RhdGFfZ2V0X2lycV9jaGlwX2RhdGEoZCk7Cj4gPiAgCXN0cnVjdCBkd19wY2ll ICpwY2kgPSB0b19kd19wY2llX2Zyb21fcHAocHApOwo+ID4gIAlzdHJ1Y3QgdW5pcGhpZXJfcGNp ZV9wcml2ICpwcml2ID0gdG9fdW5pcGhpZXJfcGNpZShwY2kpOwo+ID4gKwl1bnNpZ25lZCBsb25n IGZsYWdzOwo+ID4gIAl1MzIgdmFsOwo+ID4gIAo+ID4gKwlyYXdfc3Bpbl9sb2NrX2lycXNhdmUo JnBwLT5sb2NrLCBmbGFncyk7Cj4gPiArCj4gPiAgCXZhbCA9IHJlYWRsKHByaXYtPmJhc2UgKyBQ Q0xfUkNWX0lOVFgpOwo+ID4gIAl2YWwgJj0gflBDTF9SQ1ZfSU5UWF9BTExfU1RBVFVTOwo+ID4g IAl2YWwgfD0gQklUKGlycWRfdG9faHdpcnEoZCkgKyBQQ0xfUkNWX0lOVFhfU1RBVFVTX1NISUZU KTsKPiA+ICAJd3JpdGVsKHZhbCwgcHJpdi0+YmFzZSArIFBDTF9SQ1ZfSU5UWCk7Cj4gPiArCj4g PiArCXJhd19zcGluX3VubG9ja19pcnFyZXN0b3JlKCZwcC0+bG9jaywgZmxhZ3MpOwo+ID4gIH0K PiA+ICAKPiA+ICBzdGF0aWMgdm9pZCB1bmlwaGllcl9wY2llX2lycV9tYXNrKHN0cnVjdCBpcnFf ZGF0YSAqZCkKPiA+IEBAIC0xOTksMTIgKzIwNCwxNyBAQCBzdGF0aWMgdm9pZCB1bmlwaGllcl9w Y2llX2lycV9tYXNrKHN0cnVjdCBpcnFfZGF0YSAqZCkKPiA+ICAJc3RydWN0IHBjaWVfcG9ydCAq cHAgPSBpcnFfZGF0YV9nZXRfaXJxX2NoaXBfZGF0YShkKTsKPiA+ICAJc3RydWN0IGR3X3BjaWUg KnBjaSA9IHRvX2R3X3BjaWVfZnJvbV9wcChwcCk7Cj4gPiAgCXN0cnVjdCB1bmlwaGllcl9wY2ll X3ByaXYgKnByaXYgPSB0b191bmlwaGllcl9wY2llKHBjaSk7Cj4gPiArCXVuc2lnbmVkIGxvbmcg ZmxhZ3M7Cj4gPiAgCXUzMiB2YWw7Cj4gPiAgCj4gPiArCXJhd19zcGluX2xvY2tfaXJxc2F2ZSgm cHAtPmxvY2ssIGZsYWdzKTsKPiA+ICsKPiA+ICAJdmFsID0gcmVhZGwocHJpdi0+YmFzZSArIFBD TF9SQ1ZfSU5UWCk7Cj4gPiAgCXZhbCAmPSB+UENMX1JDVl9JTlRYX0FMTF9NQVNLOwo+ID4gIAl2 YWwgfD0gQklUKGlycWRfdG9faHdpcnEoZCkgKyBQQ0xfUkNWX0lOVFhfTUFTS19TSElGVCk7CgpU aGlzIGxvb2tzIGV4dHJlbWVseSBzdXNwaWNpb3VzLiBZb3UgY2xlYXIgYWxsIHRoZSBJTlRYIG1h c2sgYml0cywgYW5kCm9ubHkgc2V0IHRoZSBvbmUgeW91IG5lZWQuIEhvdyBhYm91dCB0aGUgcHJl LWV4aXN0aW5nIGJpdHM/Cgo+ID4gIAl3cml0ZWwodmFsLCBwcml2LT5iYXNlICsgUENMX1JDVl9J TlRYKTsKPiA+ICsKPiA+ICsJcmF3X3NwaW5fdW5sb2NrX2lycXJlc3RvcmUoJnBwLT5sb2NrLCBm bGFncyk7Cj4gPiAgfQo+ID4gIAo+ID4gIHN0YXRpYyB2b2lkIHVuaXBoaWVyX3BjaWVfaXJxX3Vu bWFzayhzdHJ1Y3QgaXJxX2RhdGEgKmQpCj4gPiBAQCAtMjEyLDEyICsyMjIsMTcgQEAgc3RhdGlj IHZvaWQgdW5pcGhpZXJfcGNpZV9pcnFfdW5tYXNrKHN0cnVjdCBpcnFfZGF0YSAqZCkKPiA+ICAJ c3RydWN0IHBjaWVfcG9ydCAqcHAgPSBpcnFfZGF0YV9nZXRfaXJxX2NoaXBfZGF0YShkKTsKPiA+ ICAJc3RydWN0IGR3X3BjaWUgKnBjaSA9IHRvX2R3X3BjaWVfZnJvbV9wcChwcCk7Cj4gPiAgCXN0 cnVjdCB1bmlwaGllcl9wY2llX3ByaXYgKnByaXYgPSB0b191bmlwaGllcl9wY2llKHBjaSk7Cj4g PiArCXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4gPiAgCXUzMiB2YWw7Cj4gPiAgCj4gPiArCXJhd19z cGluX2xvY2tfaXJxc2F2ZSgmcHAtPmxvY2ssIGZsYWdzKTsKPiA+ICsKPiA+ICAJdmFsID0gcmVh ZGwocHJpdi0+YmFzZSArIFBDTF9SQ1ZfSU5UWCk7Cj4gPiAgCXZhbCAmPSB+UENMX1JDVl9JTlRY X0FMTF9NQVNLOwo+ID4gIAl2YWwgJj0gfkJJVChpcnFkX3RvX2h3aXJxKGQpICsgUENMX1JDVl9J TlRYX01BU0tfU0hJRlQpOwoKQW5kIGJ5IHRoZSBzYW1lIHRva2VuLCB0aGlzIHNlY29uZCBsaW5l IGlzIHRvdGFsbHkgdXNlbGVzcy4KCkkgdGhpbmsgbWFza2luZy91bm1hc2tpbmcgaXMgYnJva2Vu IGluIHRoaXMgZHJpdmVyLCBsb2NraW5nIG9yIG5vdC4KCglNLgoKLS0gCldpdGhvdXQgZGV2aWF0 aW9uIGZyb20gdGhlIG5vcm0sIHByb2dyZXNzIGlzIG5vdCBwb3NzaWJsZS4KCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK