From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6531BC4338F for ; Wed, 11 Aug 2021 08:11:53 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id CE2AC60EB5 for ; Wed, 11 Aug 2021 08:11:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CE2AC60EB5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5339B49F82; Wed, 11 Aug 2021 04:11:52 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CzwiagCPL7-d; Wed, 11 Aug 2021 04:11:46 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9C7964A19F; Wed, 11 Aug 2021 04:11:46 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 6E61549F82 for ; Wed, 11 Aug 2021 04:11:45 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2dw4gE0YOnWc for ; Wed, 11 Aug 2021 04:11:41 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id E955149DE3 for ; Wed, 11 Aug 2021 04:11:40 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D436F60EB5; Wed, 11 Aug 2021 08:11:39 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mDjKr-004GBi-IT; Wed, 11 Aug 2021 09:11:37 +0100 Date: Wed, 11 Aug 2021 09:11:37 +0100 Message-ID: <87zgto9z9i.wl-maz@kernel.org> From: Marc Zyngier To: Anshuman Khandual Subject: Re: [PATCH 1/5] KVM: arm64: Drop direct PAGE_[SHIFT|SIZE] usage as page size In-Reply-To: <0b47c654-7e9b-a7ca-bdf4-f9607062200e@arm.com> References: <1628578961-29097-1-git-send-email-anshuman.khandual@arm.com> <1628578961-29097-2-git-send-email-anshuman.khandual@arm.com> <25ee7799069492f2501003faec7f9732@kernel.org> <0b47c654-7e9b-a7ca-bdf4-f9607062200e@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: Will Deacon , linux-kernel@vger.kernel.org, Catalin Marinas , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gV2VkLCAxMSBBdWcgMjAyMSAwNjozNDo0NiArMDEwMCwKQW5zaHVtYW4gS2hhbmR1YWwgPGFu c2h1bWFuLmtoYW5kdWFsQGFybS5jb20+IHdyb3RlOgo+IAo+IAo+IAo+IE9uIDgvMTAvMjEgNzow MyBQTSwgTWFyYyBaeW5naWVyIHdyb3RlOgo+ID4gT24gMjAyMS0wOC0xMCAwODowMiwgQW5zaHVt YW4gS2hhbmR1YWwgd3JvdGU6Cj4gPj4gQWxsIGluc3RhbmNlcyBoZXJlIGNvdWxkIGp1c3QgZGly ZWN0bHkgdGVzdCBhZ2FpbnN0IENPTkZJR19BUk02NF9YWEtfUEFHRVMKPiA+PiBpbnN0ZWFkIG9m IGV2YWx1YXRpbmcgdmlhIFBBR0VfU0hJRlQgb3IgUEFHRV9TSVpFLiBXaXRoIHRoaXMgY2hhbmdl LCB0aGVyZQo+ID4+IHdpbGwgYmUgbm8gc3VjaCB1c2FnZSBsZWZ0Lgo+ID4+Cj4gPj4gQ2M6IE1h cmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+Cj4gPj4gQ2M6IEphbWVzIE1vcnNlIDxqYW1lcy5t b3JzZUBhcm0uY29tPgo+ID4+IENjOiBBbGV4YW5kcnUgRWxpc2VpIDxhbGV4YW5kcnUuZWxpc2Vp QGFybS5jb20+Cj4gPj4gQ2M6IFN1enVraSBLIFBvdWxvc2UgPHN1enVraS5wb3Vsb3NlQGFybS5j b20+Cj4gPj4gQ2M6IENhdGFsaW4gTWFyaW5hcyA8Y2F0YWxpbi5tYXJpbmFzQGFybS5jb20+Cj4g Pj4gQ2M6IFdpbGwgRGVhY29uIDx3aWxsQGtlcm5lbC5vcmc+Cj4gPj4gQ2M6IGxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwo+ID4+IENjOiBrdm1hcm1AbGlzdHMuY3MuY29sdW1i aWEuZWR1Cj4gPj4gQ2M6IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcKPiA+PiBTaWduZWQt b2ZmLWJ5OiBBbnNodW1hbiBLaGFuZHVhbCA8YW5zaHVtYW4ua2hhbmR1YWxAYXJtLmNvbT4KPiA+ PiAtLS0KPiA+PiDCoGFyY2gvYXJtNjQva3ZtL2h5cC9wZ3RhYmxlLmMgfCA2ICsrKy0tLQo+ID4+ IMKgYXJjaC9hcm02NC9tbS9tbXUuY8KgwqDCoMKgwqDCoMKgwqDCoCB8IDIgKy0KPiA+PiDCoDIg ZmlsZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+ID4+Cj4gPj4g ZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQva3ZtL2h5cC9wZ3RhYmxlLmMgYi9hcmNoL2FybTY0L2t2 bS9oeXAvcGd0YWJsZS5jCj4gPj4gaW5kZXggMDUzMjFmNDE2NWUzLi5hNjExMmI2ZDZlZjYgMTAw NjQ0Cj4gPj4gLS0tIGEvYXJjaC9hcm02NC9rdm0vaHlwL3BndGFibGUuYwo+ID4+ICsrKyBiL2Fy Y2gvYXJtNjQva3ZtL2h5cC9wZ3RhYmxlLmMKPiA+PiBAQCAtODUsNyArODUsNyBAQCBzdGF0aWMg Ym9vbCBrdm1fbGV2ZWxfc3VwcG9ydHNfYmxvY2tfbWFwcGluZyh1MzIgbGV2ZWwpCj4gPj4gwqDC oMKgwqDCoCAqIFJlamVjdCBpbnZhbGlkIGJsb2NrIG1hcHBpbmdzIGFuZCBkb24ndCBib3RoZXIg d2l0aCA0VEIgbWFwcGluZ3MgZm9yCj4gPj4gwqDCoMKgwqDCoCAqIDUyLWJpdCBQQXMuCj4gPj4g wqDCoMKgwqDCoCAqLwo+ID4+IC3CoMKgwqAgcmV0dXJuICEobGV2ZWwgPT0gMCB8fCAoUEFHRV9T SVpFICE9IFNaXzRLICYmIGxldmVsID09IDEpKTsKPiA+PiArwqDCoMKgIHJldHVybiAhKGxldmVs ID09IDAgfHwgKCFJU19FTkFCTEVEKENPTkZJR19BUk02NF80S19QQUdFUykgJiYgbGV2ZWwgPT0g MSkpOwo+ID4+IMKgfQo+ID4+Cj4gPj4gwqBzdGF0aWMgYm9vbCBrdm1fYmxvY2tfbWFwcGluZ19z dXBwb3J0ZWQodTY0IGFkZHIsIHU2NCBlbmQsIHU2NCBwaHlzLCB1MzIgbGV2ZWwpCj4gPj4gQEAg LTE1NSw3ICsxNTUsNyBAQCBzdGF0aWMgdTY0IGt2bV9wdGVfdG9fcGh5cyhrdm1fcHRlX3QgcHRl KQo+ID4+IMKgewo+ID4+IMKgwqDCoMKgIHU2NCBwYSA9IHB0ZSAmIEtWTV9QVEVfQUREUl9NQVNL Owo+ID4+Cj4gPj4gLcKgwqDCoCBpZiAoUEFHRV9TSElGVCA9PSAxNikKPiA+PiArwqDCoMKgIGlm IChJU19FTkFCTEVEKENPTkZJR19BUk02NF82NEtfUEFHRVMpKQo+ID4+IMKgwqDCoMKgwqDCoMKg wqAgcGEgfD0gRklFTERfR0VUKEtWTV9QVEVfQUREUl81MV80OCwgcHRlKSA8PCA0ODsKPiA+Pgo+ ID4+IMKgwqDCoMKgIHJldHVybiBwYTsKPiA+PiBAQCAtMTY1LDcgKzE2NSw3IEBAIHN0YXRpYyBr dm1fcHRlX3Qga3ZtX3BoeXNfdG9fcHRlKHU2NCBwYSkKPiA+PiDCoHsKPiA+PiDCoMKgwqDCoCBr dm1fcHRlX3QgcHRlID0gcGEgJiBLVk1fUFRFX0FERFJfTUFTSzsKPiA+Pgo+ID4+IC3CoMKgwqAg aWYgKFBBR0VfU0hJRlQgPT0gMTYpCj4gPj4gK8KgwqDCoCBpZiAoSVNfRU5BQkxFRChDT05GSUdf QVJNNjRfNjRLX1BBR0VTKSkKPiA+PiDCoMKgwqDCoMKgwqDCoMKgIHB0ZSB8PSBGSUVMRF9QUkVQ KEtWTV9QVEVfQUREUl81MV80OCwgcGEgPj4gNDgpOwo+ID4+Cj4gPj4gwqDCoMKgwqAgcmV0dXJu IHB0ZTsKPiA+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9tbS9tbXUuYyBiL2FyY2gvYXJtNjQv bW0vbW11LmMKPiA+PiBpbmRleCA5ZmYwZGUxYjJiOTMuLjhmZGZjYTE3OTgxNSAxMDA2NDQKPiA+ PiAtLS0gYS9hcmNoL2FybTY0L21tL21tdS5jCj4gPj4gKysrIGIvYXJjaC9hcm02NC9tbS9tbXUu Ywo+ID4+IEBAIC0yOTYsNyArMjk2LDcgQEAgc3RhdGljIHZvaWQgYWxsb2NfaW5pdF9jb250X3Bt ZChwdWRfdCAqcHVkcCwKPiA+PiB1bnNpZ25lZCBsb25nIGFkZHIsCj4gPj4gwqBzdGF0aWMgaW5s aW5lIGJvb2wgdXNlXzFHX2Jsb2NrKHVuc2lnbmVkIGxvbmcgYWRkciwgdW5zaWduZWQgbG9uZyBu ZXh0LAo+ID4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIHBoeXMpCj4g Pj4gwqB7Cj4gPj4gLcKgwqDCoCBpZiAoUEFHRV9TSElGVCAhPSAxMikKPiA+PiArwqDCoMKgIGlm ICghSVNfRU5BQkxFRChDT05GSUdfQVJNNjRfNEtfUEFHRVMpKQo+ID4+IMKgwqDCoMKgwqDCoMKg wqAgcmV0dXJuIGZhbHNlOwo+ID4+Cj4gPj4gwqDCoMKgwqAgaWYgKCgoYWRkciB8IG5leHQgfCBw aHlzKSAmIH5QVURfTUFTSykgIT0gMCkKPiA+IAo+ID4gSSBwZXJzb25hbGx5IGZpbmQgaXQgYSBs b3QgbGVzcyByZWFkYWJsZS4KPiA+IAo+ID4gQWxzbywgdGhlcmUgaXMgbm8gZXZhbHVhdGlvbiB3 aGF0c29ldmVyLiBBbGwgdGhlIGNvZGUgZ3VhcmRlZAo+ID4gYnkgYSBQQUdFX1NJWkUvUEFHRV9T SElGVCB0aGF0IGRvZXNuJ3QgbWF0Y2ggdGhlIGNvbmZpZ3VyYXRpb24KPiA+IGlzIGRyb3BwZWQg YXQgY29tcGlsZSB0aW1lLgo+IAo+IFRoZSBwcmltYXJ5IGlkZWEgaGVyZSBpcyB0byB1bmlmeSBh cm91bmQgSVNfRU5BQkxFRChDT05GSUdfQVJNNjRfWFhLX1BBR0VTKQo+IHVzYWdlIGluIGFybTY0 LCByYXRoZXIgdGhhbiBoYXZpbmcgbXVsdGlwbGUgbWV0aG9kcyB0byB0ZXN0IHBhZ2Ugc2l6ZSB3 aGVuCj4gZXZlciByZXF1aXJlZC4KCkknbSBzb3JyeSwgYnV0IEkgZmluZCB0aGUgaWRpb20gZXh0 cmVtZWx5IHBhaW5mdWwgdG8gcGFyc2UuIElmIHlvdSBhcmUKYW5ub3llZCB3aXRoIHRoZSAnUEFH RV9TSElGVCA9PSAxMi8xNC8xNicsIGNvbnNpZGVyIHJlcGxhY2luZyBpdCB3aXRoCidQQUdFX1NJ WkUgPT0gU1pfNC8xNi82NEsnIGluc3RlYWQuCgpJU19FTkFCTEVEKENPTkZJR19BUk02NF9YWEtf UEFHRVMpIGFsc28gZ2l2ZXMgdGhlIHdyb25nIGltcHJlc3Npb24KdGhhdCAqbXVsdGlwbGUqIHBh Z2Ugc2l6ZXMgY2FuIGJlIHNlbGVjdGVkIGF0IGFueSBnaXZlbiB0aW1lLiBUaGF0J3MKb2J2aW91 c2x5IG5vdCB0aGUgY2FzZSwgd2hpY2ggYWN0dWFsbHkgbWFrZXMgUEFHRV9TSVpFIGEgbXVjaCBi ZXR0ZXIKY2hvaWNlLgoKQXMgdGhpbmdzIHN0YW5kLCBJIGRvbid0IHBsYW4gdG8gdGFrZSBzdWNo IGEgcGF0Y2guCgpUaGFua3MsCgoJTS4KCi0tIApXaXRob3V0IGRldmlhdGlvbiBmcm9tIHRoZSBu b3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmt2bWFybSBtYWlsaW5nIGxpc3QKa3ZtYXJtQGxpc3RzLmNz LmNvbHVtYmlhLmVkdQpodHRwczovL2xpc3RzLmNzLmNvbHVtYmlhLmVkdS9tYWlsbWFuL2xpc3Rp bmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AFD8C4338F for ; Wed, 11 Aug 2021 08:13:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5AF660F41 for ; Wed, 11 Aug 2021 08:13:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B5AF660F41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GgbsxLhQkJlCbo3LD6Y7KimGm402eglcIJwCmy9UJYQ=; b=eIAdNeYCJW+iPf nfo2F6zXhQMdjNkTG+0W55L0gKWlgVPIjstsHl4JZBO3PzWb1LjcQrJtLjuDbioDY3pl3Eu2epaVL vapNe9qpd24LaqakZ/DJpQ546yHdJGSzy/0S5WnvaF0bzJHKyEMsHBNCZ9QAzBVkGgq7I/ieT/WDD fvGpgg4TFAEXZKrffIG5+FdC2OkDbBCbY2RYHI2fpDIUP8KyGwacyl8urxu9M8Mc4IcQtP01Wj9jv AEnCeRSTeX2otQVJbTn7Qyo44Ilwz0PGhs4eLCTo5CFGdzWxj86EIfJOO6Nkpbjn/8fdSAcpfga/2 eE2hjLVB7DeSHnIbulWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDjKx-00607K-LB; Wed, 11 Aug 2021 08:11:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDjKu-00606q-5B for linux-arm-kernel@lists.infradead.org; Wed, 11 Aug 2021 08:11:41 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D436F60EB5; Wed, 11 Aug 2021 08:11:39 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mDjKr-004GBi-IT; Wed, 11 Aug 2021 09:11:37 +0100 Date: Wed, 11 Aug 2021 09:11:37 +0100 Message-ID: <87zgto9z9i.wl-maz@kernel.org> From: Marc Zyngier To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] KVM: arm64: Drop direct PAGE_[SHIFT|SIZE] usage as page size In-Reply-To: <0b47c654-7e9b-a7ca-bdf4-f9607062200e@arm.com> References: <1628578961-29097-1-git-send-email-anshuman.khandual@arm.com> <1628578961-29097-2-git-send-email-anshuman.khandual@arm.com> <25ee7799069492f2501003faec7f9732@kernel.org> <0b47c654-7e9b-a7ca-bdf4-f9607062200e@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210811_011140_270032_E86A5843 X-CRM114-Status: GOOD ( 27.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAxMSBBdWcgMjAyMSAwNjozNDo0NiArMDEwMCwKQW5zaHVtYW4gS2hhbmR1YWwgPGFu c2h1bWFuLmtoYW5kdWFsQGFybS5jb20+IHdyb3RlOgo+IAo+IAo+IAo+IE9uIDgvMTAvMjEgNzow MyBQTSwgTWFyYyBaeW5naWVyIHdyb3RlOgo+ID4gT24gMjAyMS0wOC0xMCAwODowMiwgQW5zaHVt YW4gS2hhbmR1YWwgd3JvdGU6Cj4gPj4gQWxsIGluc3RhbmNlcyBoZXJlIGNvdWxkIGp1c3QgZGly ZWN0bHkgdGVzdCBhZ2FpbnN0IENPTkZJR19BUk02NF9YWEtfUEFHRVMKPiA+PiBpbnN0ZWFkIG9m IGV2YWx1YXRpbmcgdmlhIFBBR0VfU0hJRlQgb3IgUEFHRV9TSVpFLiBXaXRoIHRoaXMgY2hhbmdl LCB0aGVyZQo+ID4+IHdpbGwgYmUgbm8gc3VjaCB1c2FnZSBsZWZ0Lgo+ID4+Cj4gPj4gQ2M6IE1h cmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+Cj4gPj4gQ2M6IEphbWVzIE1vcnNlIDxqYW1lcy5t b3JzZUBhcm0uY29tPgo+ID4+IENjOiBBbGV4YW5kcnUgRWxpc2VpIDxhbGV4YW5kcnUuZWxpc2Vp QGFybS5jb20+Cj4gPj4gQ2M6IFN1enVraSBLIFBvdWxvc2UgPHN1enVraS5wb3Vsb3NlQGFybS5j b20+Cj4gPj4gQ2M6IENhdGFsaW4gTWFyaW5hcyA8Y2F0YWxpbi5tYXJpbmFzQGFybS5jb20+Cj4g Pj4gQ2M6IFdpbGwgRGVhY29uIDx3aWxsQGtlcm5lbC5vcmc+Cj4gPj4gQ2M6IGxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwo+ID4+IENjOiBrdm1hcm1AbGlzdHMuY3MuY29sdW1i aWEuZWR1Cj4gPj4gQ2M6IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcKPiA+PiBTaWduZWQt b2ZmLWJ5OiBBbnNodW1hbiBLaGFuZHVhbCA8YW5zaHVtYW4ua2hhbmR1YWxAYXJtLmNvbT4KPiA+ PiAtLS0KPiA+PiDCoGFyY2gvYXJtNjQva3ZtL2h5cC9wZ3RhYmxlLmMgfCA2ICsrKy0tLQo+ID4+ IMKgYXJjaC9hcm02NC9tbS9tbXUuY8KgwqDCoMKgwqDCoMKgwqDCoCB8IDIgKy0KPiA+PiDCoDIg ZmlsZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+ID4+Cj4gPj4g ZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQva3ZtL2h5cC9wZ3RhYmxlLmMgYi9hcmNoL2FybTY0L2t2 bS9oeXAvcGd0YWJsZS5jCj4gPj4gaW5kZXggMDUzMjFmNDE2NWUzLi5hNjExMmI2ZDZlZjYgMTAw NjQ0Cj4gPj4gLS0tIGEvYXJjaC9hcm02NC9rdm0vaHlwL3BndGFibGUuYwo+ID4+ICsrKyBiL2Fy Y2gvYXJtNjQva3ZtL2h5cC9wZ3RhYmxlLmMKPiA+PiBAQCAtODUsNyArODUsNyBAQCBzdGF0aWMg Ym9vbCBrdm1fbGV2ZWxfc3VwcG9ydHNfYmxvY2tfbWFwcGluZyh1MzIgbGV2ZWwpCj4gPj4gwqDC oMKgwqDCoCAqIFJlamVjdCBpbnZhbGlkIGJsb2NrIG1hcHBpbmdzIGFuZCBkb24ndCBib3RoZXIg d2l0aCA0VEIgbWFwcGluZ3MgZm9yCj4gPj4gwqDCoMKgwqDCoCAqIDUyLWJpdCBQQXMuCj4gPj4g wqDCoMKgwqDCoCAqLwo+ID4+IC3CoMKgwqAgcmV0dXJuICEobGV2ZWwgPT0gMCB8fCAoUEFHRV9T SVpFICE9IFNaXzRLICYmIGxldmVsID09IDEpKTsKPiA+PiArwqDCoMKgIHJldHVybiAhKGxldmVs ID09IDAgfHwgKCFJU19FTkFCTEVEKENPTkZJR19BUk02NF80S19QQUdFUykgJiYgbGV2ZWwgPT0g MSkpOwo+ID4+IMKgfQo+ID4+Cj4gPj4gwqBzdGF0aWMgYm9vbCBrdm1fYmxvY2tfbWFwcGluZ19z dXBwb3J0ZWQodTY0IGFkZHIsIHU2NCBlbmQsIHU2NCBwaHlzLCB1MzIgbGV2ZWwpCj4gPj4gQEAg LTE1NSw3ICsxNTUsNyBAQCBzdGF0aWMgdTY0IGt2bV9wdGVfdG9fcGh5cyhrdm1fcHRlX3QgcHRl KQo+ID4+IMKgewo+ID4+IMKgwqDCoMKgIHU2NCBwYSA9IHB0ZSAmIEtWTV9QVEVfQUREUl9NQVNL Owo+ID4+Cj4gPj4gLcKgwqDCoCBpZiAoUEFHRV9TSElGVCA9PSAxNikKPiA+PiArwqDCoMKgIGlm IChJU19FTkFCTEVEKENPTkZJR19BUk02NF82NEtfUEFHRVMpKQo+ID4+IMKgwqDCoMKgwqDCoMKg wqAgcGEgfD0gRklFTERfR0VUKEtWTV9QVEVfQUREUl81MV80OCwgcHRlKSA8PCA0ODsKPiA+Pgo+ ID4+IMKgwqDCoMKgIHJldHVybiBwYTsKPiA+PiBAQCAtMTY1LDcgKzE2NSw3IEBAIHN0YXRpYyBr dm1fcHRlX3Qga3ZtX3BoeXNfdG9fcHRlKHU2NCBwYSkKPiA+PiDCoHsKPiA+PiDCoMKgwqDCoCBr dm1fcHRlX3QgcHRlID0gcGEgJiBLVk1fUFRFX0FERFJfTUFTSzsKPiA+Pgo+ID4+IC3CoMKgwqAg aWYgKFBBR0VfU0hJRlQgPT0gMTYpCj4gPj4gK8KgwqDCoCBpZiAoSVNfRU5BQkxFRChDT05GSUdf QVJNNjRfNjRLX1BBR0VTKSkKPiA+PiDCoMKgwqDCoMKgwqDCoMKgIHB0ZSB8PSBGSUVMRF9QUkVQ KEtWTV9QVEVfQUREUl81MV80OCwgcGEgPj4gNDgpOwo+ID4+Cj4gPj4gwqDCoMKgwqAgcmV0dXJu IHB0ZTsKPiA+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9tbS9tbXUuYyBiL2FyY2gvYXJtNjQv bW0vbW11LmMKPiA+PiBpbmRleCA5ZmYwZGUxYjJiOTMuLjhmZGZjYTE3OTgxNSAxMDA2NDQKPiA+ PiAtLS0gYS9hcmNoL2FybTY0L21tL21tdS5jCj4gPj4gKysrIGIvYXJjaC9hcm02NC9tbS9tbXUu Ywo+ID4+IEBAIC0yOTYsNyArMjk2LDcgQEAgc3RhdGljIHZvaWQgYWxsb2NfaW5pdF9jb250X3Bt ZChwdWRfdCAqcHVkcCwKPiA+PiB1bnNpZ25lZCBsb25nIGFkZHIsCj4gPj4gwqBzdGF0aWMgaW5s aW5lIGJvb2wgdXNlXzFHX2Jsb2NrKHVuc2lnbmVkIGxvbmcgYWRkciwgdW5zaWduZWQgbG9uZyBu ZXh0LAo+ID4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIHBoeXMpCj4g Pj4gwqB7Cj4gPj4gLcKgwqDCoCBpZiAoUEFHRV9TSElGVCAhPSAxMikKPiA+PiArwqDCoMKgIGlm ICghSVNfRU5BQkxFRChDT05GSUdfQVJNNjRfNEtfUEFHRVMpKQo+ID4+IMKgwqDCoMKgwqDCoMKg wqAgcmV0dXJuIGZhbHNlOwo+ID4+Cj4gPj4gwqDCoMKgwqAgaWYgKCgoYWRkciB8IG5leHQgfCBw aHlzKSAmIH5QVURfTUFTSykgIT0gMCkKPiA+IAo+ID4gSSBwZXJzb25hbGx5IGZpbmQgaXQgYSBs b3QgbGVzcyByZWFkYWJsZS4KPiA+IAo+ID4gQWxzbywgdGhlcmUgaXMgbm8gZXZhbHVhdGlvbiB3 aGF0c29ldmVyLiBBbGwgdGhlIGNvZGUgZ3VhcmRlZAo+ID4gYnkgYSBQQUdFX1NJWkUvUEFHRV9T SElGVCB0aGF0IGRvZXNuJ3QgbWF0Y2ggdGhlIGNvbmZpZ3VyYXRpb24KPiA+IGlzIGRyb3BwZWQg YXQgY29tcGlsZSB0aW1lLgo+IAo+IFRoZSBwcmltYXJ5IGlkZWEgaGVyZSBpcyB0byB1bmlmeSBh cm91bmQgSVNfRU5BQkxFRChDT05GSUdfQVJNNjRfWFhLX1BBR0VTKQo+IHVzYWdlIGluIGFybTY0 LCByYXRoZXIgdGhhbiBoYXZpbmcgbXVsdGlwbGUgbWV0aG9kcyB0byB0ZXN0IHBhZ2Ugc2l6ZSB3 aGVuCj4gZXZlciByZXF1aXJlZC4KCkknbSBzb3JyeSwgYnV0IEkgZmluZCB0aGUgaWRpb20gZXh0 cmVtZWx5IHBhaW5mdWwgdG8gcGFyc2UuIElmIHlvdSBhcmUKYW5ub3llZCB3aXRoIHRoZSAnUEFH RV9TSElGVCA9PSAxMi8xNC8xNicsIGNvbnNpZGVyIHJlcGxhY2luZyBpdCB3aXRoCidQQUdFX1NJ WkUgPT0gU1pfNC8xNi82NEsnIGluc3RlYWQuCgpJU19FTkFCTEVEKENPTkZJR19BUk02NF9YWEtf UEFHRVMpIGFsc28gZ2l2ZXMgdGhlIHdyb25nIGltcHJlc3Npb24KdGhhdCAqbXVsdGlwbGUqIHBh Z2Ugc2l6ZXMgY2FuIGJlIHNlbGVjdGVkIGF0IGFueSBnaXZlbiB0aW1lLiBUaGF0J3MKb2J2aW91 c2x5IG5vdCB0aGUgY2FzZSwgd2hpY2ggYWN0dWFsbHkgbWFrZXMgUEFHRV9TSVpFIGEgbXVjaCBi ZXR0ZXIKY2hvaWNlLgoKQXMgdGhpbmdzIHN0YW5kLCBJIGRvbid0IHBsYW4gdG8gdGFrZSBzdWNo IGEgcGF0Y2guCgpUaGFua3MsCgoJTS4KCi0tIApXaXRob3V0IGRldmlhdGlvbiBmcm9tIHRoZSBu b3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51FDAC4338F for ; Wed, 11 Aug 2021 08:11:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C3D260EB5 for ; Wed, 11 Aug 2021 08:11:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235837AbhHKIMF convert rfc822-to-8bit (ORCPT ); Wed, 11 Aug 2021 04:12:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:36304 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231178AbhHKIMD (ORCPT ); Wed, 11 Aug 2021 04:12:03 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D436F60EB5; Wed, 11 Aug 2021 08:11:39 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mDjKr-004GBi-IT; Wed, 11 Aug 2021 09:11:37 +0100 Date: Wed, 11 Aug 2021 09:11:37 +0100 Message-ID: <87zgto9z9i.wl-maz@kernel.org> From: Marc Zyngier To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] KVM: arm64: Drop direct PAGE_[SHIFT|SIZE] usage as page size In-Reply-To: <0b47c654-7e9b-a7ca-bdf4-f9607062200e@arm.com> References: <1628578961-29097-1-git-send-email-anshuman.khandual@arm.com> <1628578961-29097-2-git-send-email-anshuman.khandual@arm.com> <25ee7799069492f2501003faec7f9732@kernel.org> <0b47c654-7e9b-a7ca-bdf4-f9607062200e@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Aug 2021 06:34:46 +0100, Anshuman Khandual wrote: > > > > On 8/10/21 7:03 PM, Marc Zyngier wrote: > > On 2021-08-10 08:02, Anshuman Khandual wrote: > >> All instances here could just directly test against CONFIG_ARM64_XXK_PAGES > >> instead of evaluating via PAGE_SHIFT or PAGE_SIZE. With this change, there > >> will be no such usage left. > >> > >> Cc: Marc Zyngier > >> Cc: James Morse > >> Cc: Alexandru Elisei > >> Cc: Suzuki K Poulose > >> Cc: Catalin Marinas > >> Cc: Will Deacon > >> Cc: linux-arm-kernel@lists.infradead.org > >> Cc: kvmarm@lists.cs.columbia.edu > >> Cc: linux-kernel@vger.kernel.org > >> Signed-off-by: Anshuman Khandual > >> --- > >>  arch/arm64/kvm/hyp/pgtable.c | 6 +++--- > >>  arch/arm64/mm/mmu.c          | 2 +- > >>  2 files changed, 4 insertions(+), 4 deletions(-) > >> > >> diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > >> index 05321f4165e3..a6112b6d6ef6 100644 > >> --- a/arch/arm64/kvm/hyp/pgtable.c > >> +++ b/arch/arm64/kvm/hyp/pgtable.c > >> @@ -85,7 +85,7 @@ static bool kvm_level_supports_block_mapping(u32 level) > >>       * Reject invalid block mappings and don't bother with 4TB mappings for > >>       * 52-bit PAs. > >>       */ > >> -    return !(level == 0 || (PAGE_SIZE != SZ_4K && level == 1)); > >> +    return !(level == 0 || (!IS_ENABLED(CONFIG_ARM64_4K_PAGES) && level == 1)); > >>  } > >> > >>  static bool kvm_block_mapping_supported(u64 addr, u64 end, u64 phys, u32 level) > >> @@ -155,7 +155,7 @@ static u64 kvm_pte_to_phys(kvm_pte_t pte) > >>  { > >>      u64 pa = pte & KVM_PTE_ADDR_MASK; > >> > >> -    if (PAGE_SHIFT == 16) > >> +    if (IS_ENABLED(CONFIG_ARM64_64K_PAGES)) > >>          pa |= FIELD_GET(KVM_PTE_ADDR_51_48, pte) << 48; > >> > >>      return pa; > >> @@ -165,7 +165,7 @@ static kvm_pte_t kvm_phys_to_pte(u64 pa) > >>  { > >>      kvm_pte_t pte = pa & KVM_PTE_ADDR_MASK; > >> > >> -    if (PAGE_SHIFT == 16) > >> +    if (IS_ENABLED(CONFIG_ARM64_64K_PAGES)) > >>          pte |= FIELD_PREP(KVM_PTE_ADDR_51_48, pa >> 48); > >> > >>      return pte; > >> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > >> index 9ff0de1b2b93..8fdfca179815 100644 > >> --- a/arch/arm64/mm/mmu.c > >> +++ b/arch/arm64/mm/mmu.c > >> @@ -296,7 +296,7 @@ static void alloc_init_cont_pmd(pud_t *pudp, > >> unsigned long addr, > >>  static inline bool use_1G_block(unsigned long addr, unsigned long next, > >>              unsigned long phys) > >>  { > >> -    if (PAGE_SHIFT != 12) > >> +    if (!IS_ENABLED(CONFIG_ARM64_4K_PAGES)) > >>          return false; > >> > >>      if (((addr | next | phys) & ~PUD_MASK) != 0) > > > > I personally find it a lot less readable. > > > > Also, there is no evaluation whatsoever. All the code guarded > > by a PAGE_SIZE/PAGE_SHIFT that doesn't match the configuration > > is dropped at compile time. > > The primary idea here is to unify around IS_ENABLED(CONFIG_ARM64_XXK_PAGES) > usage in arm64, rather than having multiple methods to test page size when > ever required. I'm sorry, but I find the idiom extremely painful to parse. If you are annoyed with the 'PAGE_SHIFT == 12/14/16', consider replacing it with 'PAGE_SIZE == SZ_4/16/64K' instead. IS_ENABLED(CONFIG_ARM64_XXK_PAGES) also gives the wrong impression that *multiple* page sizes can be selected at any given time. That's obviously not the case, which actually makes PAGE_SIZE a much better choice. As things stand, I don't plan to take such a patch. Thanks, M. -- Without deviation from the norm, progress is not possible.