From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Sandipan Das <sandipan@linux.ibm.com>, mpe@ellerman.id.au
Cc: jniethe5@gmail.com, rashmica.g@gmail.com,
linuxppc-dev@lists.ozlabs.org, david@redhat.com
Subject: Re: [PATCH] powerpc/powernv/memtrace: Fix dcache flushing
Date: Fri, 30 Apr 2021 13:33:31 +0530 [thread overview]
Message-ID: <87zgxg8ai4.fsf@linux.ibm.com> (raw)
In-Reply-To: <20210430075557.893819-1-sandipan@linux.ibm.com>
Sandipan Das <sandipan@linux.ibm.com> writes:
> Trace memory is cleared and the corresponding dcache lines
> are flushed after allocation. However, this should not be
> done using the PFN. This adds the missing __va() conversion.
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
>
> Fixes: 2ac02e5ecec0 ("powerpc/mm: Remove dcache flush from memory remove.")
> Signed-off-by: Sandipan Das <sandipan@linux.ibm.com>
> ---
> arch/powerpc/platforms/powernv/memtrace.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/memtrace.c b/arch/powerpc/platforms/powernv/memtrace.c
> index 71c1262589fe..a31f13814f2e 100644
> --- a/arch/powerpc/platforms/powernv/memtrace.c
> +++ b/arch/powerpc/platforms/powernv/memtrace.c
> @@ -104,8 +104,8 @@ static void memtrace_clear_range(unsigned long start_pfn,
> * Before we go ahead and use this range as cache inhibited range
> * flush the cache.
> */
> - flush_dcache_range_chunked(PFN_PHYS(start_pfn),
> - PFN_PHYS(start_pfn + nr_pages),
> + flush_dcache_range_chunked((unsigned long)__va(PFN_PHYS(start_pfn)),
> + (unsigned long)__va(PFN_PHYS(start_pfn + nr_pages)),
> FLUSH_CHUNK_SIZE);
> }
>
> --
> 2.25.1
next prev parent reply other threads:[~2021-04-30 8:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 7:55 [PATCH] powerpc/powernv/memtrace: Fix dcache flushing Sandipan Das
2021-04-30 8:03 ` Aneesh Kumar K.V [this message]
2021-04-30 8:42 ` Christophe Leroy
2021-05-01 15:31 ` Sandipan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgxg8ai4.fsf@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=david@redhat.com \
--cc=jniethe5@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=rashmica.g@gmail.com \
--cc=sandipan@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.