All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Robert Hancock <robert.hancock@calian.com>
Cc: tglx@linutronix.de, michal.simek@xilinx.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip/xilinx: Expose Kconfig option
Date: Fri, 16 Apr 2021 14:41:08 +0100	[thread overview]
Message-ID: <87zgxys5xn.wl-maz@kernel.org> (raw)
In-Reply-To: <20210415233250.4071772-1-robert.hancock@calian.com>

On Fri, 16 Apr 2021 00:32:50 +0100,
Robert Hancock <robert.hancock@calian.com> wrote:
> 
> Previously the XILINX_INTC config option was hidden and only
> auto-selected on the MicroBlaze platform. However, this IP can also be
> used on other platforms. Allow this option to be user-enabled.
> 
> Signed-off-by: Robert Hancock <robert.hancock@calian.com>

I don't think this is a good idea. In general, people have no idea
which interrupt controller they need to select. So you either end-up
with a missing interrupt controller, or a bunch you really don't need.

This is essentially a platform constraint, and this should directly be
selected by the platform if you have this IP in your system.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

  reply	other threads:[~2021-04-16 13:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 23:32 [PATCH] irqchip/xilinx: Expose Kconfig option Robert Hancock
2021-04-16 13:41 ` Marc Zyngier [this message]
2021-04-16 16:05   ` Robert Hancock
2021-04-16 17:53     ` Marc Zyngier
2021-04-16 18:14       ` Robert Hancock
2021-04-19 11:23         ` Michal Simek
2021-04-19 17:54           ` Robert Hancock
2021-04-18  8:26 ` kernel test robot
2021-04-18  8:26   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgxys5xn.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=robert.hancock@calian.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.