All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/ebtables: install symlink to ebtables-legacy
Date: Tue, 16 Feb 2021 21:46:05 +0200	[thread overview]
Message-ID: <87zh037q4i.fsf@tarshish> (raw)
In-Reply-To: <20210216115802.32317-1-patrickdepinguin@gmail.com>

Hi Thomas,

On Tue, Feb 16 2021, Thomas De Schampheleire wrote:

> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
>
> Since the upgrade of ebtables from 2.0.10-4 to 2.0.11, there no longer is an
> 'ebtables' binary. It has been renamed to 'ebtables-legacy' and moved from
> '/sbin' to '/usr/sbin'. This change is part of the upstream change to
> integrate the functionality of ebtables (and arptables) in the iptables
> package, using the nf_tables kernel backend [1].
>
> Unfortunately, the renaming (and move) of the original 'ebtables' binary
> breaks existing scripts that are calling 'ebtables' or '/sbin/ebtables'.
> Therefore, add a symlink from the original path to 'ebtables-legacy'.
>
> However, do not provide this symlink if BR2_PACKAGE_IPTABLES_NFTABLES is
> enabled. In this case, the iptables package will build the new equivalent
> of ebtables -- a symlink to ebtables-legacy would cause conflicts.
>
> [1] https://wiki.nftables.org/wiki-nftables/index.php/Legacy_xtables_tools
>
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

Acked-by: Baruch Siach <baruch@tkos.co.il>

Thanks,
baruch

> ---
>  package/ebtables/ebtables.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/package/ebtables/ebtables.mk b/package/ebtables/ebtables.mk
> index 998f06f5f6..54932334c2 100644
> --- a/package/ebtables/ebtables.mk
> +++ b/package/ebtables/ebtables.mk
> @@ -33,4 +33,11 @@ endef
>  EBTABLES_POST_INSTALL_TARGET_HOOKS += EBTABLES_REMOVE_UTILS_RESTORE
>  endif
>  
> +ifeq ($(BR2_PACKAGE_IPTABLES_NFTABLES),)
> +define EBTABLES_INSTALL_LEGACY_SYMLINK
> +	ln -sf /usr/sbin/ebtables-legacy $(TARGET_DIR)/sbin/ebtables
> +endef
> +EBTABLES_POST_INSTALL_TARGET_HOOKS += EBTABLES_INSTALL_LEGACY_SYMLINK
> +endif
> +
>  $(eval $(autotools-package))


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2021-02-16 19:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 11:58 [Buildroot] [PATCH] package/ebtables: install symlink to ebtables-legacy Thomas De Schampheleire
2021-02-16 19:46 ` Baruch Siach [this message]
2021-02-16 19:47 ` Peter Korsgaard
2021-02-17  7:15 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zh037q4i.fsf@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.