From: Thomas Gleixner <tglx@linutronix.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] task_work: cleanup notification modes
Date: Sat, 17 Oct 2020 01:09:46 +0200 [thread overview]
Message-ID: <87zh4lix8l.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <aaed79d1-972f-e4bd-f3ac-d589cd729163@kernel.dk>
On Fri, Oct 16 2020 at 16:39, Jens Axboe wrote:
> On 10/16/20 3:44 PM, Thomas Gleixner wrote:
>>> - * @notify: send the notification if true
>>> + * @notify: send chosen notification, if any
>>
>> Is that really all you found to be wrong in that comment?
>
> There really is nothing wrong, but it's not very descriptive (wasn't
> before either).
* This is like the signal handler which runs in kernel mode, but it doesn't
* try to wake up the @task.
If find a lot of wrongs in that sentence in context of TWA_SIGNAL.
Agreed, it was hard to understand before that, but with TWA_SIGNAL it
does not make sense at all.
Thanks,
tglx
next prev parent reply other threads:[~2020-10-16 23:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 15:16 [PATCH] task_work: cleanup notification modes Jens Axboe
2020-10-16 21:44 ` Thomas Gleixner
2020-10-16 22:39 ` Jens Axboe
2020-10-16 23:09 ` Thomas Gleixner [this message]
2020-10-16 23:13 ` Jens Axboe
2020-10-16 23:38 ` Thomas Gleixner
2020-10-16 23:43 ` Jens Axboe
2020-10-17 15:31 ` Thomas Gleixner
2020-10-17 15:36 ` Jens Axboe
2020-10-17 20:18 ` Thomas Gleixner
2020-10-17 20:32 ` Jens Axboe
2020-10-17 21:01 ` Thomas Gleixner
2020-10-17 21:03 ` Jens Axboe
2020-10-17 21:17 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh4lix8l.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.