RE: [PATCH] usb: gadget: f_acm: don't disable disabled EP

[Felipe Balbi <balbi@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 917 bytes --]

Peter Chen <peter.chen@nxp.com> writes:

>  
>> > > @@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f, unsigned
>> intf, unsigned alt)
>> > >  	/* we know alt == 0, so this is an activation or a reset */
>> > >
>> > >  	if (intf == acm->ctrl_id) {
>> > > -		dev_vdbg(&cdev->gadget->dev,
>> > > -				"reset acm control interface %d\n", intf);
>> > > -		usb_ep_disable(acm->notify);
>> > > +		if (acm->notify->enabled) {
>> > > +			dev_vdbg(&cdev->gadget->dev,
>> > > +					"reset acm control interface %d\n", intf);
>> > > +			usb_ep_disable(acm->notify);
>> > > +		}
>> >
>> > But it does not fix any issues, the usb_ep_disable checks 'enabled' flag.
>> 
>> It generates spurious trace events if you enable them.
>> 
>
> You mean the trace events from core.c? If it is, we could try to improve it
> and indicate it is already enabled or disabled.

I agree :-)

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]