From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Andrii Nakryiko <andriin@fb.com>,
bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com,
daniel@iogearbox.net
Cc: andrii.nakryiko@gmail.com, kernel-team@fb.com,
Andrii Nakryiko <andriin@fb.com>
Subject: Re: [PATCH bpf-next] libbpf: add a bunch of attribute getters/setters for map definitions
Date: Mon, 22 Jun 2020 14:25:32 +0200 [thread overview]
Message-ID: <87zh8vthhf.fsf@toke.dk> (raw)
In-Reply-To: <20200621062112.3006313-1-andriin@fb.com>
Andrii Nakryiko <andriin@fb.com> writes:
> Add a bunch of getter for various aspects of BPF map. Some of these attribute
> (e.g., key_size, value_size, type, etc) are available right now in struct
> bpf_map_def, but this patch adds getter allowing to fetch them individually.
> bpf_map_def approach isn't very scalable, when ABI stability requirements are
> taken into account. It's much easier to extend libbpf and add support for new
> features, when each aspect of BPF map has separate getter/setter.
+1, good idea!
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
next prev parent reply other threads:[~2020-06-22 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-21 6:21 [PATCH bpf-next] libbpf: add a bunch of attribute getters/setters for map definitions Andrii Nakryiko
2020-06-22 12:25 ` Toke Høiland-Jørgensen [this message]
2020-06-22 22:04 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh8vthhf.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.