From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E2A1C11D3D for ; Thu, 27 Feb 2020 18:37:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D032B2469F for ; Thu, 27 Feb 2020 18:37:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RsfC3Z5P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D032B2469F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7O2C-0006ZE-2O for qemu-devel@archiver.kernel.org; Thu, 27 Feb 2020 13:37:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36577) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7O1Q-0005Xe-R1 for qemu-devel@nongnu.org; Thu, 27 Feb 2020 13:36:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7O1P-0002LR-Fu for qemu-devel@nongnu.org; Thu, 27 Feb 2020 13:36:32 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:36411 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7O1P-0002KA-B8 for qemu-devel@nongnu.org; Thu, 27 Feb 2020 13:36:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582828590; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nUpS01+e6nl1QK3mpdfHghJmTnRs5Y4WpdaiwEBB94A=; b=RsfC3Z5PI2plFqmLzmsY723QRnng9S0lf8ZHYBKxr63jwSAYJQomUYEzDeWEzyT4G2w9I4 oflc0NvPhiHMjIfa0MHCEo772LwP6o4UnQ3K73FuDSqoGK1XTgEUEc8uJpKlOrgzMOn/6e gymRIKgZcld/zhiSfkHBrS8KVol9Jbc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-443-Tz_X-rqHMyibLU5bdTWUwg-1; Thu, 27 Feb 2020 13:36:27 -0500 X-MC-Unique: Tz_X-rqHMyibLU5bdTWUwg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D339118FF661; Thu, 27 Feb 2020 18:36:25 +0000 (UTC) Received: from redhat.com (ovpn-116-72.ams2.redhat.com [10.36.116.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8BBAB5C28E; Thu, 27 Feb 2020 18:36:25 +0000 (UTC) From: Juan Quintela To: zhanghailiang Subject: Re: [PATCH V2 1/8] migration: fix COLO broken caused by a previous commit In-Reply-To: <20200224065414.36524-2-zhang.zhanghailiang@huawei.com> (zhanghailiang's message of "Mon, 24 Feb 2020 14:54:07 +0800") References: <20200224065414.36524-1-zhang.zhanghailiang@huawei.com> <20200224065414.36524-2-zhang.zhanghailiang@huawei.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Date: Thu, 27 Feb 2020 19:36:21 +0100 Message-ID: <87zhd3c1y2.fsf@secure.laptop> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: danielcho@qnap.com, qemu-devel@nongnu.org, dgilbert@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" zhanghailiang wrote: > This commit "migration: Create migration_is_running()" broke > COLO. Becuase there is a process broken by this commit. > > colo_process_checkpoint > ->colo_do_checkpoint_transaction > ->migrate_set_block_enabled > ->qmp_migrate_set_capabilities > > It can be fixed by make COLO process as an exception, > Maybe we need a better way to fix it. > > Cc: Juan Quintela > Signed-off-by: zhanghailiang oops sorry. Reviewed-by: Juan Quintela queued.