From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF821C2D0DB for ; Mon, 27 Jan 2020 15:14:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A815520716 for ; Mon, 27 Jan 2020 15:14:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HWXwX4ag" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A815520716 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iw65T-000532-QC for qemu-devel@archiver.kernel.org; Mon, 27 Jan 2020 10:14:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44256) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iw64f-0004FN-Fj for qemu-devel@nongnu.org; Mon, 27 Jan 2020 10:13:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iw64b-0000gS-IY for qemu-devel@nongnu.org; Mon, 27 Jan 2020 10:13:13 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:35315 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iw64b-0000fb-FD for qemu-devel@nongnu.org; Mon, 27 Jan 2020 10:13:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580137988; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zt3T7bz+ul8h69XUz30oxyR4ZIY7WPbFKCXQrJkEtEQ=; b=HWXwX4ag+0LJw5/GYnwR4229ebDMWlvGhkFKwgkw603LtI1DB7tfrx5382vVEuUp2kzV4Z PsyoW0PkxCV5Q6rawZYnjFnVbdz3NXX6zhm4RC5RhTR8jFEJ3Z77N3c5pSceYcNvviXVTF IvmwaDab1YW4t1/npraDKAZVaq2y9h8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-0Cc0QSi6NSuKPDWtp8khMw-1; Mon, 27 Jan 2020 10:13:06 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5F0809255A; Mon, 27 Jan 2020 15:13:05 +0000 (UTC) Received: from redhat.com (ovpn-116-91.ams2.redhat.com [10.36.116.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D56AB5C21A; Mon, 27 Jan 2020 15:13:04 +0000 (UTC) From: Juan Quintela To: Wei Yang Subject: Re: [PATCH 2/2] migration/compress: disable compress if failed to setup In-Reply-To: <20191012023932.1863-3-richardw.yang@linux.intel.com> (Wei Yang's message of "Sat, 12 Oct 2019 10:39:32 +0800") References: <20191012023932.1863-1-richardw.yang@linux.intel.com> <20191012023932.1863-3-richardw.yang@linux.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Date: Mon, 27 Jan 2020 16:13:02 +0100 Message-ID: <87zhe90w75.fsf@secure.laptop> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: 0Cc0QSi6NSuKPDWtp8khMw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: dgilbert@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Wei Yang wrote: > In current logic, if compress_threads_save_setup() returns -1 the whole > migration would fail, while we could handle it gracefully by disable > compress. > > Signed-off-by: Wei Yang Fully agree with Dave here. If user asks for compression, and compression fails, we fail migration. If user wants to continue without compression, it just have to disable compression. Thanks, Juan.