Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

["Alex Bennée" <alex.bennee@linaro.org>]

Markus Armbruster <armbru@redhat.com> writes:

> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>
>> On 8/9/19 8:46 AM, Markus Armbruster wrote:
>>> In my "build everything" tree, changing qemu/main-loop.h triggers a
>>> recompile of some 5600 out of 6600 objects (not counting tests and
>>> objects that don't depend on qemu/osdep.h).  It includes block/aio.h,
>>> which in turn includes qemu/event_notifier.h, qemu/notify.h,
>>> qemu/processor.h, qemu/qsp.h, qemu/queue.h, qemu/thread-posix.h,
>>> qemu/thread.h, qemu/timer.h, and a few more.
>>>
>>> Include qemu/main-loop.h only where it's needed.  Touching it now
>>> recompiles only some 1700 objects.  For block/aio.h and
>>> qemu/event_notifier.h, these numbers drop from 5600 to 2800.  For the
>>> others, they shrink only slightly.
>>>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>> ---
>> [...]
>>> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
>>> index 77f5df59b0..ac18a1184a 100644
>>> --- a/include/sysemu/sysemu.h
>>> +++ b/include/sysemu/sysemu.h
>>> @@ -5,7 +5,6 @@
>>>  #include "qapi/qapi-types-run-state.h"
>>>  #include "qemu/timer.h"
>>>  #include "qemu/notify.h"
>>> -#include "qemu/main-loop.h"
>>>  #include "qemu/bitmap.h"
>>>  #include "qemu/uuid.h"
>>>  #include "qom/object.h"
>>
>> netmap failing again :S
>>
>> $ make docker-image-debian-amd64 V=1 DEBUG=1
>> [...]
>>   CC      net/netmap.o
>> net/netmap.c: In function 'netmap_update_fd_handler':
>> net/netmap.c:109:5: error: implicit declaration of function
>> 'qemu_set_fd_handler' [-Werror=implicit-function-declaration]
>>      qemu_set_fd_handler(s->nmd->fd,
>>      ^~~~~~~~~~~~~~~~~~~
>> net/netmap.c:109:5: error: nested extern declaration of
>> 'qemu_set_fd_handler' [-Werror=nested-externs]
>
> I managed to lose the fix somehow.
>
> I admit I ran "make docker-test-build", realized docker needs root, and
> went "sod it, cross fingers & send out the patches".

I've sent some patches to make docker-test-build more closely resemble
what shippable exercises.

As for root you can setup a docker group and do it that way (see the
docs in docs/devel/testing.rst). It's not recommended for production
machines as it makes escalation fairly trivial (the daemon itself still
runs as root). Hopefully Marc's podman support:

  Subject: [PATCH v2 0/5] tests/docker: add podman support
  Date: Tue,  9 Jul 2019 23:43:25 +0400
  Message-Id: <20190709194330.837-1-marcandre.lureau@redhat.com>

will make these requirements a little less onerous.

> My need to get out
> the changes accumulated since v2 won over the prudence to run all
> available tests first.  Not my finest hour.


--
Alex Bennée