From: Richard Palethorpe <rpalethorpe@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 1/9] lib: Add support for guarded buffers
Date: Thu, 08 Aug 2019 17:41:52 +0200 [thread overview]
Message-ID: <87zhkjbr5r.fsf@rpws.prws.suse.cz> (raw)
In-Reply-To: <20190808090635.GA11500@rei.lan>
Hello,
Cyril Hrubis <chrubis@suse.cz> writes:
> Hi!
>> > +void tst_free_all(void)
>> > +{
>> > + struct map *i = maps;
>> > +
>> > + while (i) {
>> > + struct map *j = i;
>> > + tst_res(TINFO, "Freeing %p %zu", i->addr, i->size);
>>
>> This seems like debug info to me. Not really useful most of the time.
>
> Yes, this is a leftover.
>
> I do wonder if we should print a message first time the tst_alloc() is
> called so that it's clear that the test is using guarded buffers.
Maybe some summary info.
>
>> > + SAFE_MUNMAP(i->addr, i->size);
>> > + i = i->next;
>> > + free(j);
>> > + }
>> > +
>> > + maps = NULL;
>> > +}
>>
>> --
>> Thank you,
>> Richard.
>>
>> --
>> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Thank you,
Richard.
next prev parent reply other threads:[~2019-08-08 15:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 9:26 [LTP] [RFC PATCH 0/9] Introduce guarded buffers Cyril Hrubis
2019-08-01 9:26 ` [LTP] [RFC PATCH 1/9] lib: Add support for " Cyril Hrubis
2019-08-01 10:39 ` Jan Stancek
2019-08-01 11:45 ` Cyril Hrubis
2019-08-02 14:03 ` Richard Palethorpe
2019-08-02 13:57 ` Richard Palethorpe
2019-08-02 13:59 ` Cyril Hrubis
2019-08-02 14:23 ` Cyril Hrubis
2019-08-02 14:36 ` Richard Palethorpe
2019-08-02 14:50 ` Cyril Hrubis
2019-08-02 14:20 ` Cyril Hrubis
2019-08-03 12:55 ` Li Wang
2019-08-06 7:36 ` Richard Palethorpe
2019-08-06 9:03 ` Richard Palethorpe
2019-08-08 9:06 ` Cyril Hrubis
2019-08-08 9:13 ` Li Wang
2019-08-08 15:41 ` Richard Palethorpe [this message]
2019-08-01 9:26 ` [LTP] [RFC PATCH 2/9] lib: Add a canary " Cyril Hrubis
2019-08-01 10:43 ` Jan Stancek
2019-08-01 11:54 ` Cyril Hrubis
2019-08-01 16:32 ` Jan Stancek
2019-08-02 9:47 ` Cyril Hrubis
2019-08-02 10:54 ` Jan Stancek
2019-08-03 13:02 ` Li Wang
2019-08-08 9:27 ` Cyril Hrubis
2019-08-01 9:26 ` [LTP] [RFC PATCH 3/9] syscalls/preadv01: Make use of " Cyril Hrubis
2019-08-01 9:26 ` [LTP] [RFC PATCH 4/9] syscalls/accept4_01: " Cyril Hrubis
2019-08-01 9:26 ` [LTP] [RFC PATCH 5/9] syscalls/add_key04: " Cyril Hrubis
2019-08-01 9:26 ` [LTP] [RFC PATCH 6/9] syscalls/adjtimex: " Cyril Hrubis
2019-08-01 9:26 ` [LTP] [RFC PATCH 7/9] syscalls/clock_getres01: " Cyril Hrubis
2019-08-01 9:26 ` [LTP] [RFC PATCH 8/9] syscalls/clock_settime01: " Cyril Hrubis
2019-08-01 9:26 ` [LTP] [RFC PATCH 9/9] syscalls/sendmmsg01: " Cyril Hrubis
2019-08-06 9:47 ` [LTP] [PATCH v3 0/4] eBPF tests using guarded buffers API Richard Palethorpe
2019-08-06 9:47 ` [LTP] [PATCH v3 1/4] BPF: Essential headers for map creation Richard Palethorpe
2019-08-06 9:47 ` [LTP] [PATCH v3 2/4] BPF: Sanity check creating and updating maps Richard Palethorpe
2019-08-06 9:47 ` [LTP] [PATCH v3 3/4] BPF: Essential headers for a basic program Richard Palethorpe
2019-08-06 9:47 ` [LTP] [PATCH v3 4/4] BPF: Sanity check creating a program Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhkjbr5r.fsf@rpws.prws.suse.cz \
--to=rpalethorpe@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.