All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: <yhchuang@realtek.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 6/6] rtw88: more descriptions about LPS
Date: Fri, 03 May 2019 14:01:25 +0300	[thread overview]
Message-ID: <87zho3kdiy.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1556879502-16211-7-git-send-email-yhchuang@realtek.com> (yhchuang@realtek.com's message of "Fri, 3 May 2019 18:31:42 +0800")

<yhchuang@realtek.com> writes:

> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>
> The LPS represents Leisure Power Save. When enabled, firmware will be in
> charge of turning radio off between beacons. Also firmware should turn
> on the radio when beacon is coming, and the data queued should be
> transmitted in TBTT period.
>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
> ---
>  drivers/net/wireless/realtek/rtw88/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/main.c
> b/drivers/net/wireless/realtek/rtw88/main.c
> index f447361..6953013 100644
> --- a/drivers/net/wireless/realtek/rtw88/main.c
> +++ b/drivers/net/wireless/realtek/rtw88/main.c
> @@ -20,7 +20,7 @@ EXPORT_SYMBOL(rtw_debug_mask);
>  module_param_named(support_lps, rtw_fw_support_lps, bool, 0644);
>  module_param_named(debug_mask, rtw_debug_mask, uint, 0644);
>  
> -MODULE_PARM_DESC(support_lps, "Set Y to enable LPS support");
> +MODULE_PARM_DESC(support_lps, "Set Y to enable Leisure Power Save
> support, turn radio off between beacons");

I think it would help to add:

", to turn radio off between beacons"

-- 
Kalle Valo

  reply	other threads:[~2019-05-03 11:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-03 10:31 [PATCH 0/6] rtw88: minor fixes from suggestions during review yhchuang
2019-05-03 10:31 ` [PATCH 1/6] rtw88: add license for Makefile yhchuang
2019-05-03 11:03   ` Kalle Valo
2019-05-03 11:05     ` Tony Chuang
2019-05-03 10:31 ` [PATCH 2/6] rtw88: pci: use ieee80211_ac_numbers instead of 0-3 yhchuang
2019-05-03 10:31 ` [PATCH 3/6] rtw88: pci: check if queue mapping exceeds size of ac_to_hwq yhchuang
2019-05-03 10:31 ` [PATCH 4/6] rtw88: fix unassigned rssi_level in rtw_sta_info yhchuang
2019-05-03 10:31 ` [PATCH 5/6] rtw88: mac: remove dangerous while (1) yhchuang
2019-05-03 10:48   ` Johannes Berg
2019-05-03 10:52     ` Tony Chuang
2019-05-03 11:07   ` Kalle Valo
2019-05-03 11:22     ` Tony Chuang
2019-05-03 11:26       ` Kalle Valo
2019-05-03 10:31 ` [PATCH 6/6] rtw88: more descriptions about LPS yhchuang
2019-05-03 11:01   ` Kalle Valo [this message]
2019-05-03 11:04     ` Tony Chuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zho3kdiy.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=yhchuang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.