From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AE85C43381 for ; Mon, 1 Apr 2019 12:04:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25F9020883 for ; Mon, 1 Apr 2019 12:04:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726942AbfDAMEW (ORCPT ); Mon, 1 Apr 2019 08:04:22 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:38763 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726565AbfDAMEW (ORCPT ); Mon, 1 Apr 2019 08:04:22 -0400 Received: by mail-ed1-f66.google.com with SMTP id q14so7972981edr.5 for ; Mon, 01 Apr 2019 05:04:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=Ivh/n6lRX6Vj1TslAjqhvYztxU8zs6avjIlsxtRcNlo=; b=dCAnQ9J5cT6sBwB3dfSNUbzMlpAKtGSNwNXmjZjJM3iDDsfObPopg1ro6NBms+5rCE u7oncKBiIRJgJDtNLXhInqxUQ5DWtJsBhCKOs1uyBNtwj+zv8iWqv93271diIGGI1OO2 7tLjtLyO+6UHO65BxNLCzdxUfmhxS6szV/S6aKUpLmm7gCnKHmPf4DcSels+dLwJNyPC bUXyWpPtVfAbV14e/Lzl8lXJnAJkEaWAsydq3/ya2Pqb2xgsAn9Jb8sIOwYx+VBokRCh bLY6Xf/X9Bw+DGmJ+FfOU0ygs/2rPdM6JPn34G8kftDEQJEYwyFCI7OBn4Theu7TNI7k 4t9A== X-Gm-Message-State: APjAAAUqXXohhtpF5X+IW317f/I9S1DKj3Zq5mr6LdnPyluUisB7UTK4 iUplSQYUgd2IfFuZtU5OW8/Tsw== X-Google-Smtp-Source: APXvYqzkUy8qwcvCfJfEIxPvm86W19qDKtIh20WDR0Vl3Fx280ZVNOYGl11xZh3FYWkRvqZelqoBlw== X-Received: by 2002:a50:8bb4:: with SMTP id m49mr43549454edm.28.1554120260717; Mon, 01 Apr 2019 05:04:20 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id r3sm1875143ejb.55.2019.04.01.05.04.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Apr 2019 05:04:19 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 41C9718200F; Mon, 1 Apr 2019 14:04:19 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Gautam Ramakrishnan , jhs@mojatatu.com Cc: davem@davemloft.net, netdev@vger.kernel.org, Gautam Ramakrishnan , "Mohit P . Tahiliani" , "Sachin D . Patil" , Mohit Bhasi , "V . Saicharan" , Leslie Monis , Dave Taht Subject: Re: [RFC net-next 0/2] net: sched: add Flow Queue PIE AQM In-Reply-To: <20190331174005.5841-1-gautamramk@gmail.com> References: <20190331174005.5841-1-gautamramk@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 01 Apr 2019 14:04:19 +0200 Message-ID: <87zhpaorss.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Gautam Ramakrishnan writes: > Flow Queue PIE packet scheduler > > This patch series implements the Flow Queue Proportional > Integral Controller (FQ-PIE) active queue management > algorithm. It is an enhancement over the PIE algorithm. > It integrates the PIE aqm with a deficit round robin > scheme. > > It is implemented over RFC 8033 aligned version of PIE. > In this patch, Little's law is used for queue delay > estimation like PIE. This patch doesn't yet have the > timestamp based queue delay estimator like freebsd, that > Dave Taht thinks is better. > > We are looking for suggestions on cleanups and > improvements for this patch. Is the fq_ part basically identical to fq_codel? Might make sense to share some code in that case; might not be a trivial refactoring, though... -Toke