From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 01/17] drm/vc4: Fix memory leak during gpu reset. Date: Fri, 01 Mar 2019 14:43:44 -0800 Message-ID: <87zhqe6wrj.fsf@anholt.net> References: <20190301125627.7285-1-maarten.lankhorst@linux.intel.com> <20190301125627.7285-2-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: In-Reply-To: <20190301125627.7285-2-maarten.lankhorst@linux.intel.com> Sender: stable-owner@vger.kernel.org To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, Maarten Lankhorst , stable@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org --=-=-= Content-Type: text/plain Maarten Lankhorst writes: > __drm_atomic_helper_crtc_destroy_state does not free memory, it only > cleans it up. Fix this by calling the functions own destroy function. Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlx5taAACgkQtdYpNtH8 nujWIQ/+MQWb6/1MiXdpScKuf8xd6VWd5ZoEObZ3tqXIqiq+Oaazge5BgCTMOm8v vXED+d6AcwEbztL8R3h1krXUOUZFHi2SX++/3XKpqPlKiARABMRKHtbVT4U6Gjm0 HgXDD8zrGLpMdFhxLmPm+RvQYmWedhhg0Vmg/snMHM/nrVnWVKDMITc2vNtpW/3J V/exXjqwp040JF8WOLueZGSpCZJ+pZphrlDZG/B93wv5RgOrlN86wX8xkGWL3zi6 RJU5oIWag4nxH6ICdQrnCz9SnognMcG0qDEKjV6ChTQO/v5DNtJZL9ZvRttbaU7c 66CkhUld7isIUpRuaSaizTdXuFi9vVhDj/Qeeys4x23cPC1rHkgc4cFEjMydO816 hajXiv5Nt4p72Vl89OZ0IRhAWrI+QkQk9JJ8ztONnUGKneuPbC5gWIgHuJcWm/dJ +g6RZgNT3AjfzMPRSDrK2kCcQNTQRKDyPLQpErzHXFG1y2OAnmLXYPBCjjG6j+v6 +46/pM86/a/JeZRwHUG3GJOywwzev/CpkZfg6pLCIUTCd4z2EoCCow7OisG1JLZF xwPIrE7/IFKKisxKdkp76pymE3K5/ZkgBQNA7228ps0m0mMmMc7Vy6NBpDeIe5zL 7IQzfC9SQST5ddVWRj2jKPK+9LwOhi2A5VTrc5dYERfeUrsbM7U= =Olrx -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EBE5C43381 for ; Fri, 1 Mar 2019 22:43:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D53E120840 for ; Fri, 1 Mar 2019 22:43:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726806AbfCAWnr (ORCPT ); Fri, 1 Mar 2019 17:43:47 -0500 Received: from anholt.net ([50.246.234.109]:45650 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726693AbfCAWnr (ORCPT ); Fri, 1 Mar 2019 17:43:47 -0500 Received: from localhost (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 4063710A2DB8; Fri, 1 Mar 2019 14:43:46 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at anholt.net Received: from anholt.net ([127.0.0.1]) by localhost (kingsolver.anholt.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Sa6Kr_vEYXf5; Fri, 1 Mar 2019 14:43:45 -0800 (PST) Received: from eliezer.anholt.net (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 4E4E710A2BCE; Fri, 1 Mar 2019 14:43:45 -0800 (PST) Received: by eliezer.anholt.net (Postfix, from userid 1000) id E2FD22FE464E; Fri, 1 Mar 2019 14:43:44 -0800 (PST) From: Eric Anholt To: Maarten Lankhorst , dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, Maarten Lankhorst , stable@vger.kernel.org Subject: Re: [PATCH 01/17] drm/vc4: Fix memory leak during gpu reset. In-Reply-To: <20190301125627.7285-2-maarten.lankhorst@linux.intel.com> References: <20190301125627.7285-1-maarten.lankhorst@linux.intel.com> <20190301125627.7285-2-maarten.lankhorst@linux.intel.com> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Fri, 01 Mar 2019 14:43:44 -0800 Message-ID: <87zhqe6wrj.fsf@anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org --=-=-= Content-Type: text/plain Maarten Lankhorst writes: > __drm_atomic_helper_crtc_destroy_state does not free memory, it only > cleans it up. Fix this by calling the functions own destroy function. Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlx5taAACgkQtdYpNtH8 nujWIQ/+MQWb6/1MiXdpScKuf8xd6VWd5ZoEObZ3tqXIqiq+Oaazge5BgCTMOm8v vXED+d6AcwEbztL8R3h1krXUOUZFHi2SX++/3XKpqPlKiARABMRKHtbVT4U6Gjm0 HgXDD8zrGLpMdFhxLmPm+RvQYmWedhhg0Vmg/snMHM/nrVnWVKDMITc2vNtpW/3J V/exXjqwp040JF8WOLueZGSpCZJ+pZphrlDZG/B93wv5RgOrlN86wX8xkGWL3zi6 RJU5oIWag4nxH6ICdQrnCz9SnognMcG0qDEKjV6ChTQO/v5DNtJZL9ZvRttbaU7c 66CkhUld7isIUpRuaSaizTdXuFi9vVhDj/Qeeys4x23cPC1rHkgc4cFEjMydO816 hajXiv5Nt4p72Vl89OZ0IRhAWrI+QkQk9JJ8ztONnUGKneuPbC5gWIgHuJcWm/dJ +g6RZgNT3AjfzMPRSDrK2kCcQNTQRKDyPLQpErzHXFG1y2OAnmLXYPBCjjG6j+v6 +46/pM86/a/JeZRwHUG3GJOywwzev/CpkZfg6pLCIUTCd4z2EoCCow7OisG1JLZF xwPIrE7/IFKKisxKdkp76pymE3K5/ZkgBQNA7228ps0m0mMmMc7Vy6NBpDeIe5zL 7IQzfC9SQST5ddVWRj2jKPK+9LwOhi2A5VTrc5dYERfeUrsbM7U= =Olrx -----END PGP SIGNATURE----- --=-=-=--