From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH 1/1] Makefile: add prove and coverage-prove targets
Date: Tue, 29 Jan 2019 22:03:46 +0100 [thread overview]
Message-ID: <87zhrj2n2l.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20190129160030.GA7083@sigill.intra.peff.net>
On Tue, Jan 29 2019, Jeff King wrote:
> On Tue, Jan 29, 2019 at 06:56:08AM -0800, Derrick Stolee via GitGitGadget wrote:
>
>> From: Derrick Stolee <dstolee@microsoft.com>
>>
>> When running the test suite for code coverage using
>> 'make coverage-test', a single test failure stops the
>> test suite from completing. This leads to significant
>> undercounting of covered blocks.
>>
>> Add two new targets to the Makefile:
>>
>> * 'prove' runs the test suite using 'prove'.
>>
>> * 'coverage-prove' compiles the source using the
>> coverage flags, then runs the test suite using
>> 'prove'.
>>
>> These targets are modeled after the 'test' and
>> 'coverage-test' targets.
>
> I think these are reasonable to have (and I personally much prefer
> "prove" to the raw "make test" output anyway).
I wonder if anyone would mind if we removed the non-prove path.
When I added it in 5099b99d25 ("test-lib: Adjust output to be valid TAP
format", 2010-06-24) there were still some commonly shipped OS's that
had a crappy old "prove", but now almost a decade later that's not a
practical problem, and it's installed by default with perl, and we
already depend on perl for the tests.
I don't feel strongly about it, but it would allow us to prune some
login in the test library / Makefile.
Maybe something for a show of hands at the contributor summit?
next prev parent reply other threads:[~2019-01-29 21:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 14:56 [PATCH 0/1] Makefile: add prove and coverage-prove targets Derrick Stolee via GitGitGadget
2019-01-29 14:56 ` [PATCH 1/1] " Derrick Stolee via GitGitGadget
2019-01-29 15:20 ` Johannes Schindelin
2019-01-29 15:58 ` SZEDER Gábor
2019-01-29 16:37 ` Derrick Stolee
2019-01-29 16:49 ` Jeff King
2019-01-29 17:34 ` SZEDER Gábor
2019-01-29 18:10 ` Derrick Stolee
2019-01-29 20:49 ` Derrick Stolee
2019-01-29 21:58 ` SZEDER Gábor
2019-01-29 16:00 ` Jeff King
2019-01-29 16:35 ` Derrick Stolee
2019-01-29 16:46 ` Jeff King
2019-01-29 21:03 ` Ævar Arnfjörð Bjarmason [this message]
2019-01-29 22:38 ` Jeff King
2019-01-30 12:20 ` Johannes Schindelin
2019-01-30 13:08 ` Ævar Arnfjörð Bjarmason
2019-01-30 18:42 ` Johannes Schindelin
2019-01-30 19:32 ` Ævar Arnfjörð Bjarmason
2019-01-31 7:23 ` Johannes Schindelin
2019-01-29 17:05 ` [PATCH v2 0/1] " Derrick Stolee via GitGitGadget
2019-01-29 17:05 ` [PATCH v2 1/1] Makefile: add coverage-prove target Derrick Stolee via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhrj2n2l.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.