From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ioan-Adrian Ratiu Subject: Re: [RFC][PATCH] Revert "ARM: dts: bcm2837: Fix polarity of wifi reset GPIOs" Date: Sun, 27 Jan 2019 22:33:24 +0200 Message-ID: <87zhrl96y3.fsf@ni.com> References: <20190127202813.29493-1-adi@adirat.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Return-path: In-Reply-To: <20190127202813.29493-1-adi@adirat.com> Sender: linux-kernel-owner@vger.kernel.org To: Stefan Wahren Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org List-Id: devicetree@vger.kernel.org Link to the full 4.19.18 config I'm using: https://drive.google.com/open?id=1ZI3MeGB2fkYMsEjzGQYXUk2wqr0h9h7R On Sun, 27 Jan 2019, Ioan-Adrian Ratiu wrote: > This reverts commit bea8a160c621d19f7f78b13e14e03f4b8e44cd4b. > > Contrary to what the commit message says, on my rpi 3 b v1.2 changing > the polarity causes the exact behaviour this commit intends to fix, as > described at the referenced link below (wlan0 disapears). > > With reset-gpios = ... GPIO_ACTIVE_HIGH, brcmfmac errors in dmesg: > > [ 7.977512] brcmfmac: brcmf_sdio_bus_sleep: error while changing bus sleep state -110 > [ 7.977623] brcmfmac: brcmf_sdio_txfail: sdio error, abort command and terminate frame > [ 7.978007] brcmfmac: brcmf_sdio_txfail: sdio error, abort command and terminate frame > [ 7.978377] brcmfmac: brcmf_sdio_txfail: sdio error, abort command and terminate frame > [ 7.978724] brcmfmac: brcmf_sdio_dpc: failed backplane access over SDIO, halting operation > [ 7.978734] brcmfmac: brcmf_proto_bcdc_query_dcmd: brcmf_proto_bcdc_msg failed w/status -110 > [ 7.978747] brcmfmac: brcmf_cfg80211_get_channel: chanspec failed (-110) > [ 7.982817] brcmfmac: brcmf_sdio_bus_sleep: error while changing bus sleep state -110 > [ 7.982880] brcmfmac: brcmf_sdio_txfail: sdio error, abort command and terminate frame > [ 7.983255] brcmfmac: brcmf_sdio_txfail: sdio error, abort command and terminate frame > > The only solution I currently have is to revert and everything works > as expected and as before changing the polarity. > > Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911443 > Signed-off-by: Ioan-Adrian Ratiu > --- > arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts | 2 +- > arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts > index 93762244be7f..4adb85e66be3 100644 > --- a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts > +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts > @@ -31,7 +31,7 @@ > > wifi_pwrseq: wifi-pwrseq { > compatible = "mmc-pwrseq-simple"; > - reset-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>; > + reset-gpios = <&expgpio 1 GPIO_ACTIVE_HIGH>; > }; > }; > > diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts > index 89e6fd547c75..c318bcbc6ba7 100644 > --- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts > +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts > @@ -26,7 +26,7 @@ > > wifi_pwrseq: wifi-pwrseq { > compatible = "mmc-pwrseq-simple"; > - reset-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>; > + reset-gpios = <&expgpio 1 GPIO_ACTIVE_HIGH>; > }; > }; > > -- > 2.20.1