From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJdQD-0001HX-Kb for qemu-devel@nongnu.org; Mon, 05 Nov 2018 06:51:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJdQA-0007sX-80 for qemu-devel@nongnu.org; Mon, 05 Nov 2018 06:51:57 -0500 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:33799) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gJdQ9-000563-Gf for qemu-devel@nongnu.org; Mon, 05 Nov 2018 06:51:54 -0500 Received: by mail-wr1-x443.google.com with SMTP id j26-v6so9204747wre.1 for ; Mon, 05 Nov 2018 03:51:40 -0800 (PST) References: <20181104112424.18663-1-stefanha@redhat.com> <20181104112424.18663-2-stefanha@redhat.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <20181104112424.18663-2-stefanha@redhat.com> Date: Mon, 05 Nov 2018 11:51:36 +0000 Message-ID: <87zhuneo8n.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 1/8] README: use 'https://' instead of 'git://' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, eblake@redhat.com, cohuck@redhat.com, Paolo Bonzini , Fam Zheng , Peter Maydell , Markus Armbruster , Jeff Cody , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Daniel Berrange , "Michael S. Tsirkin" Stefan Hajnoczi writes: > When you clone the repository without previous commit history, 'git://' > doesn't protect from man-in-the-middle attacks. HTTPS is more secure > since the client verifies the server certificate. > > Reported-by: Jann Horn > Reviewed-by: Daniel P. Berrang=C3=A9 > Signed-off-by: Stefan Hajnoczi Reviewed-by: Alex Benn=C3=A9e > --- > README | 4 ++-- > pc-bios/README | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/README b/README > index 49a9fd09cd..441c33eb2f 100644 > --- a/README > +++ b/README > @@ -54,7 +54,7 @@ Submitting patches >=20=20 > The QEMU source code is maintained under the GIT version control system. >=20=20 > - git clone git://git.qemu.org/qemu.git > + git clone https://git.qemu.org/git/qemu.git >=20=20 > When submitting patches, one common approach is to use 'git > format-patch' and/or 'git send-email' to format & send the mail to the > @@ -70,7 +70,7 @@ the QEMU website >=20=20 > The QEMU website is also maintained under source control. >=20=20 > - git clone git://git.qemu.org/qemu-web.git > + git clone https://git.qemu.org/git/qemu-web.git > https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/ >=20=20 > A 'git-publish' utility was created to make above process less > diff --git a/pc-bios/README b/pc-bios/README > index 90f0fa7aa7..b572e9eb00 100644 > --- a/pc-bios/README > +++ b/pc-bios/README > @@ -23,7 +23,7 @@ > legacy x86 software to communicate with an attached serial console as > if a video card were attached. The master sources reside in a subvers= ion > repository at http://sgabios.googlecode.com/svn/trunk. A git mirror is > - available at git://git.qemu.org/sgabios.git. > + available at https://git.qemu.org/git/sgabios.git. >=20=20 > - The PXE roms come from the iPXE project. Built with BANNER_TIME 0. > Sources available at http://ipxe.org. Vendor:Device ID -> ROM mapping: > @@ -40,7 +40,7 @@ >=20=20 > - The u-boot binary for e500 comes from the upstream denx u-boot project= where > it was compiled using the qemu-ppce500 target. > - A git mirror is available at: git://git.qemu.org/u-boot.git > + A git mirror is available at: https://git.qemu.org/git/u-boot.git > The hash used to compile the current version is: 2072e72 >=20=20 > - Skiboot (https://github.com/open-power/skiboot/) is an OPAL --=20 Alex Benn=C3=A9e