From: Juan Quintela <quintela@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tests/migration-test: Turn kvm_hv message into a g_debug message
Date: Wed, 22 Aug 2018 12:10:49 +0200 [thread overview]
Message-ID: <87zhxe4spi.fsf@trasno.org> (raw)
In-Reply-To: <1533203376-25621-1-git-send-email-thuth@redhat.com> (Thomas Huth's message of "Thu, 2 Aug 2018 11:49:36 +0200")
Thomas Huth <thuth@redhat.com> wrote:
> When running "make check" on a non-POWER host, there is currently an ugly
> line in the output like this:
>
> [...]
> GTESTER check-qtest-nios2
> GTESTER check-qtest-or1k
> GTESTER check-qtest-ppc64
> Skipping test: kvm_hv not available Skipping test: kvm_hv not available Skipping test: kvm_hv not available Skipping test: kvm_hv not available GTESTER check-qtest-ppcemb
> GTESTER check-qtest-ppc
> GTESTER check-qtest-riscv32
> GTESTER check-qtest-riscv64
> [...]
>
> Move the check to the beginning of the main function instead, so that
> we do not have to test the condition again and again for each test,
> and better use g_test_message() instead of g_print() here, like it is
> also done in ufd_version_check() already.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
prev parent reply other threads:[~2018-08-22 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 9:49 [Qemu-devel] [PATCH] tests/migration-test: Turn kvm_hv message into a g_debug message Thomas Huth
2018-08-02 9:52 ` Thomas Huth
2018-08-22 10:10 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhxe4spi.fsf@trasno.org \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.