From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fppW9-0000F7-JZ for qemu-devel@nongnu.org; Wed, 15 Aug 2018 02:42:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fppW5-0000W4-NG for qemu-devel@nongnu.org; Wed, 15 Aug 2018 02:42:53 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:42490 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fppW5-0000VI-F2 for qemu-devel@nongnu.org; Wed, 15 Aug 2018 02:42:49 -0400 From: Markus Armbruster References: <1534258018-22859-1-git-send-email-thuth@redhat.com> <1534258018-22859-3-git-send-email-thuth@redhat.com> <87a7pou95a.fsf@dusky.pond.sub.org> <50453f7e-ef0e-bff4-e229-728b51017c62@redhat.com> Date: Wed, 15 Aug 2018 08:42:47 +0200 In-Reply-To: <50453f7e-ef0e-bff4-e229-728b51017c62@redhat.com> (Thomas Huth's message of "Wed, 15 Aug 2018 07:56:59 +0200") Message-ID: <87zhxonna0.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 2/6] tests/device-introspection: Check that the qom-tree and qtree do not change List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: "Michael S. Tsirkin" , Juan Quintela , qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathie?= =?utf-8?Q?u-Daud=C3=A9?= , Paolo Bonzini , "Dr. David Alan Gilbert" Thomas Huth writes: > On 08/14/2018 07:53 PM, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> Introspection should not change the qom-tree / qtree, so we should check >>> this in the device-introspect-test, too. This patch helped to find lots >>> of instrospection bugs during the QEMU v3.0 soft/hard-freeze period in the >>> last two months. >> >> Clever idea. >> >>> Signed-off-by: Thomas Huth >>> --- >>> tests/device-introspect-test.c | 23 +++++++++++++++++++---- >>> 1 file changed, 19 insertions(+), 4 deletions(-) >>> >>> diff --git a/tests/device-introspect-test.c b/tests/device-introspect-test.c >>> index 0b4f221..5b7ec05 100644 >>> --- a/tests/device-introspect-test.c >>> +++ b/tests/device-introspect-test.c >>> @@ -103,7 +103,14 @@ static QList *device_type_list(bool abstract) >>> static void test_one_device(const char *type) >>> { >>> QDict *resp; >>> - char *help, *qom_tree; >>> + char *help; >>> + char *qom_tree_start, *qom_tree_end; >>> + char *qtree_start, *qtree_end; >>> + >>> + g_debug("Testing device '%s'", type); >> >> This is only the second use of g_debug() in tests/. What are you trying >> to accomplish? > > When the test crashes, I need a way to determine the device which caused > the crash. To avoid that I've then got to insert fprintf statements > manually here and recompile, the g_debug() seems to be a good solution, > since you can enable its output by setting some environment variable (I > use G_MESSAGES_DEBUG=all and G_MESSAGES_PREFIXED=none). I see. However, I'm unlikely to remember these GLib arcana when I run into test failures. > Or do you see a better way to provide a possibility to determine the > device that caused a crash? g_test_message() and --verbose. Less arcane, because device-introspect-test --help points to --verbose, and --verbose does the natural thing, namely printing more about what it's being done. Another option would be to split test_device_intro_concrete() into one test case per device. main() would have to enumerate devices so it can register the test cases. Vaguely similar to how qmp-test enumerates query commands and registers their tests. Probably not worth the bother now.