All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Wireless <linux-wireless@vger.kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mt76x0: build driver only as module
Date: Fri, 03 Aug 2018 12:19:20 +0300	[thread overview]
Message-ID: <87zhy36c4n.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20180803091401.GB10284@redhat.com> (Stanislaw Gruszka's message of "Fri, 3 Aug 2018 11:14:01 +0200")

Stanislaw Gruszka <sgruszka@redhat.com> writes:

> There are various symbols that conflicts with mt7601u.
> Due to that kernel will not build with allyesconfig.
> For now limit the driver to be build only as module.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>

Thanks for the quick patch!

> --- a/drivers/net/wireless/mediatek/mt76/Kconfig
> +++ b/drivers/net/wireless/mediatek/mt76/Kconfig
> @@ -11,7 +11,7 @@ config MT76x2_COMMON
>  
>  config MT76x0U
>  	tristate "MediaTek MT76x0U (USB) support"
> -	depends on MAC80211
> +	depends on MAC80211 && m

But this feels like an ugly hack to me. Isn't there a better way to fix
this? (I don't have time to investigate the error in detail right now.)

-- 
Kalle Valo

  reply	other threads:[~2018-08-03  9:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03  9:14 [PATCH] mt76x0: build driver only as module Stanislaw Gruszka
2018-08-03  9:19 ` Kalle Valo [this message]
2018-08-03  9:28   ` Stanislaw Gruszka
2018-08-03 10:09     ` Stanislaw Gruszka
     [not found]       ` <20180803100939.GE10284-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-08-03 10:31         ` Kalle Valo
2018-08-03 10:31           ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhy36c4n.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.