From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH 07/11] drm/i915: Tidy i915_gem_suspend()
Date: Tue, 10 Jul 2018 13:01:41 +0300
Message-ID: <87zhyzs92y.fsf@gaia.fi.intel.com>
References: <20180709130208.11730-1-chris@chris-wilson.co.uk>
 <20180709130208.11730-7-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 670356E8D1
 for <intel-gfx@lists.freedesktop.org>; Tue, 10 Jul 2018 10:02:37 +0000 (UTC)
In-Reply-To: <20180709130208.11730-7-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gSW4gdGhl
IG5leHQgcGF0Y2gsIHdlIHdpbGwgbWFrZSBhIGZhaXJseSBtaW5vciBjaGFuZ2UgdG8gZmx1c2gK
PiBvdXRzdGFuZGluZyByZXNldHMgYmVmb3JlIHN1c3BlbmQuIEluIG9yZGVyIHRvIGtlZXAgY2h1
cm4gdG8gYSBtaW5pbXVtCj4gaW4gdGhhdCBmdW5jdGlvbmFsIHBhdGNoLCB3ZSBmaXggdXAgdGhl
IGNvbW1lbnRzIGFuZCBjb2Rpbmcgc3R5bGUgbm93Lgo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMg
V2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+CgpSZXZpZXdlZC1ieTogTWlrYSBLdW9w
cGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dw
dS9kcm0vaTkxNS9pOTE1X2dlbS5jIHwgNTAgKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t
LS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCAyNCBkZWxldGlvbnMoLSkK
Pgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGluZGV4IGI3MzBhNTNiNDI2Yi4uNmExYmI4OGI1
NzMwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysg
Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gQEAgLTUwMjksMzIgKzUwMjksMzIg
QEAgdm9pZCBpOTE1X2dlbV9zYW5pdGl6ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkK
PiAgCW11dGV4X3VubG9jaygmaTkxNS0+ZHJtLnN0cnVjdF9tdXRleCk7Cj4gIH0KPiAgCj4gLWlu
dCBpOTE1X2dlbV9zdXNwZW5kKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAr
aW50IGk5MTVfZ2VtX3N1c3BlbmQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4gIHsK
PiAtCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSAmZGV2X3ByaXYtPmRybTsKPiAgCWludCByZXQ7
Cj4gIAo+ICAJR0VNX1RSQUNFKCJcbiIpOwo+ICAKPiAtCWludGVsX3J1bnRpbWVfcG1fZ2V0KGRl
dl9wcml2KTsKPiAtCWludGVsX3N1c3BlbmRfZ3RfcG93ZXJzYXZlKGRldl9wcml2KTsKPiArCWlu
dGVsX3J1bnRpbWVfcG1fZ2V0KGk5MTUpOwo+ICsJaW50ZWxfc3VzcGVuZF9ndF9wb3dlcnNhdmUo
aTkxNSk7Cj4gIAo+IC0JbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICsJbXV0ZXhf
bG9jaygmaTkxNS0+ZHJtLnN0cnVjdF9tdXRleCk7Cj4gIAo+IC0JLyogV2UgaGF2ZSB0byBmbHVz
aCBhbGwgdGhlIGV4ZWN1dGluZyBjb250ZXh0cyB0byBtYWluIG1lbW9yeSBzbwo+ICsJLyoKPiAr
CSAqIFdlIGhhdmUgdG8gZmx1c2ggYWxsIHRoZSBleGVjdXRpbmcgY29udGV4dHMgdG8gbWFpbiBt
ZW1vcnkgc28KPiAgCSAqIHRoYXQgdGhleSBjYW4gc2F2ZWQgaW4gdGhlIGhpYmVybmF0aW9uIGlt
YWdlLiBUbyBlbnN1cmUgdGhlIGxhc3QKPiAgCSAqIGNvbnRleHQgaW1hZ2UgaXMgY29oZXJlbnQs
IHdlIGhhdmUgdG8gc3dpdGNoIGF3YXkgZnJvbSBpdC4gVGhhdAo+IC0JICogbGVhdmVzIHRoZSBk
ZXZfcHJpdi0+a2VybmVsX2NvbnRleHQgc3RpbGwgYWN0aXZlIHdoZW4KPiArCSAqIGxlYXZlcyB0
aGUgaTkxNS0+a2VybmVsX2NvbnRleHQgc3RpbGwgYWN0aXZlIHdoZW4KPiAgCSAqIHdlIGFjdHVh
bGx5IHN1c3BlbmQsIGFuZCBpdHMgaW1hZ2UgaW4gbWVtb3J5IG1heSBub3QgbWF0Y2ggdGhlIEdQ
VQo+ICAJICogc3RhdGUuIEZvcnR1bmF0ZWx5LCB0aGUga2VybmVsX2NvbnRleHQgaXMgZGlzcG9z
YWJsZSBhbmQgd2UgZG8KPiAgCSAqIG5vdCByZWx5IG9uIGl0cyBzdGF0ZS4KPiAgCSAqLwo+IC0J
aWYgKCFpOTE1X3Rlcm1pbmFsbHlfd2VkZ2VkKCZkZXZfcHJpdi0+Z3B1X2Vycm9yKSkgewo+IC0J
CXJldCA9IGk5MTVfZ2VtX3N3aXRjaF90b19rZXJuZWxfY29udGV4dChkZXZfcHJpdik7Cj4gKwlp
ZiAoIWk5MTVfdGVybWluYWxseV93ZWRnZWQoJmk5MTUtPmdwdV9lcnJvcikpIHsKPiArCQlyZXQg
PSBpOTE1X2dlbV9zd2l0Y2hfdG9fa2VybmVsX2NvbnRleHQoaTkxNSk7Cj4gIAkJaWYgKHJldCkK
PiAgCQkJZ290byBlcnJfdW5sb2NrOwo+ICAKPiAtCQlyZXQgPSBpOTE1X2dlbV93YWl0X2Zvcl9p
ZGxlKGRldl9wcml2LAo+ICsJCXJldCA9IGk5MTVfZ2VtX3dhaXRfZm9yX2lkbGUoaTkxNSwKPiAg
CQkJCQkgICAgIEk5MTVfV0FJVF9JTlRFUlJVUFRJQkxFIHwKPiAgCQkJCQkgICAgIEk5MTVfV0FJ
VF9MT0NLRUQgfAo+ICAJCQkJCSAgICAgSTkxNV9XQUlUX0ZPUl9JRExFX0JPT1NULAo+IEBAIC01
MDYyLDMzICs1MDYyLDM1IEBAIGludCBpOTE1X2dlbV9zdXNwZW5kKHN0cnVjdCBkcm1faTkxNV9w
cml2YXRlICpkZXZfcHJpdikKPiAgCQlpZiAocmV0ICYmIHJldCAhPSAtRUlPKQo+ICAJCQlnb3Rv
IGVycl91bmxvY2s7Cj4gIAo+IC0JCWFzc2VydF9rZXJuZWxfY29udGV4dF9pc19jdXJyZW50KGRl
dl9wcml2KTsKPiArCQlhc3NlcnRfa2VybmVsX2NvbnRleHRfaXNfY3VycmVudChpOTE1KTsKPiAg
CX0KPiAtCW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICsJbXV0ZXhfdW5sb2Nr
KCZpOTE1LT5kcm0uc3RydWN0X211dGV4KTsKPiAgCj4gLQlpbnRlbF91Y19zdXNwZW5kKGRldl9w
cml2KTsKPiArCWludGVsX3VjX3N1c3BlbmQoaTkxNSk7Cj4gIAo+IC0JY2FuY2VsX2RlbGF5ZWRf
d29ya19zeW5jKCZkZXZfcHJpdi0+Z3B1X2Vycm9yLmhhbmdjaGVja193b3JrKTsKPiAtCWNhbmNl
bF9kZWxheWVkX3dvcmtfc3luYygmZGV2X3ByaXYtPmd0LnJldGlyZV93b3JrKTsKPiArCWNhbmNl
bF9kZWxheWVkX3dvcmtfc3luYygmaTkxNS0+Z3B1X2Vycm9yLmhhbmdjaGVja193b3JrKTsKPiAr
CWNhbmNlbF9kZWxheWVkX3dvcmtfc3luYygmaTkxNS0+Z3QucmV0aXJlX3dvcmspOwo+ICAKPiAt
CS8qIEFzIHRoZSBpZGxlX3dvcmsgaXMgcmVhcm1pbmcgaWYgaXQgZGV0ZWN0cyBhIHJhY2UsIHBs
YXkgc2FmZSBhbmQKPiArCS8qCj4gKwkgKiBBcyB0aGUgaWRsZV93b3JrIGlzIHJlYXJtaW5nIGlm
IGl0IGRldGVjdHMgYSByYWNlLCBwbGF5IHNhZmUgYW5kCj4gIAkgKiByZXBlYXQgdGhlIGZsdXNo
IHVudGlsIGl0IGlzIGRlZmluaXRlbHkgaWRsZS4KPiAgCSAqLwo+IC0JZHJhaW5fZGVsYXllZF93
b3JrKCZkZXZfcHJpdi0+Z3QuaWRsZV93b3JrKTsKPiArCWRyYWluX2RlbGF5ZWRfd29yaygmaTkx
NS0+Z3QuaWRsZV93b3JrKTsKPiAgCj4gLQkvKiBBc3NlcnQgdGhhdCB3ZSBzdWNlc3NmdWxseSBm
bHVzaGVkIGFsbCB0aGUgd29yayBhbmQKPiArCS8qCj4gKwkgKiBBc3NlcnQgdGhhdCB3ZSBzdWNj
ZXNzZnVsbHkgZmx1c2hlZCBhbGwgdGhlIHdvcmsgYW5kCj4gIAkgKiByZXNldCB0aGUgR1BVIGJh
Y2sgdG8gaXRzIGlkbGUsIGxvdyBwb3dlciBzdGF0ZS4KPiAgCSAqLwo+IC0JV0FSTl9PTihkZXZf
cHJpdi0+Z3QuYXdha2UpOwo+IC0JaWYgKFdBUk5fT04oIWludGVsX2VuZ2luZXNfYXJlX2lkbGUo
ZGV2X3ByaXYpKSkKPiAtCQlpOTE1X2dlbV9zZXRfd2VkZ2VkKGRldl9wcml2KTsgLyogbm8gaG9w
ZSwgZGlzY2FyZCBldmVyeXRoaW5nICovCj4gKwlXQVJOX09OKGk5MTUtPmd0LmF3YWtlKTsKPiAr
CWlmIChXQVJOX09OKCFpbnRlbF9lbmdpbmVzX2FyZV9pZGxlKGk5MTUpKSkKPiArCQlpOTE1X2dl
bV9zZXRfd2VkZ2VkKGk5MTUpOyAvKiBubyBob3BlLCBkaXNjYXJkIGV2ZXJ5dGhpbmcgKi8KPiAg
Cj4gLQlpbnRlbF9ydW50aW1lX3BtX3B1dChkZXZfcHJpdik7Cj4gKwlpbnRlbF9ydW50aW1lX3Bt
X3B1dChpOTE1KTsKPiAgCXJldHVybiAwOwo+ICAKPiAgZXJyX3VubG9jazoKPiAtCW11dGV4X3Vu
bG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+IC0JaW50ZWxfcnVudGltZV9wbV9wdXQoZGV2X3By
aXYpOwo+ICsJbXV0ZXhfdW5sb2NrKCZpOTE1LT5kcm0uc3RydWN0X211dGV4KTsKPiArCWludGVs
X3J1bnRpbWVfcG1fcHV0KGk5MTUpOwo+ICAJcmV0dXJuIHJldDsKPiAgfQo+ICAKPiAtLSAKPiAy
LjE4LjAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50
ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz
Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==