From: Markus Armbruster <armbru@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v9 7/7] monitor: add lock to protect mon_fdsets
Date: Thu, 07 Jun 2018 16:38:33 +0200 [thread overview]
Message-ID: <87zi06slue.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20180529055755.12404-8-peterx@redhat.com> (Peter Xu's message of "Tue, 29 May 2018 13:57:55 +0800")
Peter Xu <peterx@redhat.com> writes:
> Introduce a new global big lock for mon_fdsets. Take it where needed.
>
> The monitor_fdset_get_fd() handling is a bit tricky: now we need to call
> qemu_mutex_unlock() which might pollute errno, so we need to make sure
> the correct errno be passed up to the callers. To make things simpler,
> we let monitor_fdset_get_fd() return the -errno directly when error
> happens, then in qemu_open() we move it back into errno.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
prev parent reply other threads:[~2018-06-07 14:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 5:57 [Qemu-devel] [PATCH v9 0/7] monitor: let Monitor be thread safe Peter Xu
2018-05-29 5:57 ` [Qemu-devel] [PATCH v9 1/7] monitor: rename out_lock to mon_lock Peter Xu
2018-06-07 14:24 ` Markus Armbruster
2018-05-29 5:57 ` [Qemu-devel] [PATCH v9 2/7] monitor: protect mon->fds with mon_lock Peter Xu
2018-05-29 5:57 ` [Qemu-devel] [PATCH v9 3/7] monitor: more comments on lock-free elements Peter Xu
2018-05-30 16:26 ` Stefan Hajnoczi
2018-06-07 14:26 ` Markus Armbruster
2018-05-29 5:57 ` [Qemu-devel] [PATCH v9 4/7] monitor: fix comment for monitor_lock Peter Xu
2018-05-30 16:29 ` Stefan Hajnoczi
2018-06-07 14:27 ` Markus Armbruster
2018-05-29 5:57 ` [Qemu-devel] [PATCH v9 5/7] monitor: remove event_clock_type Peter Xu
2018-05-30 16:35 ` Stefan Hajnoczi
2018-05-31 4:11 ` Peter Xu
2018-05-31 8:23 ` Stefan Hajnoczi
2018-05-31 8:30 ` Peter Xu
2018-06-07 14:32 ` Markus Armbruster
2018-06-08 3:54 ` Peter Xu
2018-05-29 5:57 ` [Qemu-devel] [PATCH v9 6/7] monitor: move init global earlier Peter Xu
2018-05-30 16:37 ` Stefan Hajnoczi
2018-06-07 14:33 ` Markus Armbruster
2018-05-29 5:57 ` [Qemu-devel] [PATCH v9 7/7] monitor: add lock to protect mon_fdsets Peter Xu
2018-05-30 16:39 ` Stefan Hajnoczi
2018-06-07 14:38 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi06slue.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.