All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, lvivier@redhat.com, dgilbert@redhat.com,
	peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH v7 1/8] qemu-sockets: Export SocketAddress_to_str
Date: Tue, 08 May 2018 09:49:37 +0200	[thread overview]
Message-ID: <87zi1aa8oe.fsf@secure.laptop> (raw)
In-Reply-To: <20180413115451.GD16263@redhat.com> ("Daniel P. Berrangé"'s message of "Fri, 13 Apr 2018 12:54:51 +0100")

Daniel P. Berrangé <berrange@redhat.com> wrote:
> On Wed, Apr 04, 2018 at 01:27:24PM +0200, Juan Quintela wrote:
>> Migration code needs that function in hmp.c (so we need to export it),
>> and it needs it on tests/migration-test.c, so we need to move it to a
>> place where it is compiled into the test framework.
>
> This code really does not belong in qemu-sockets.h - the syntax being
> printed here is the chardev specific syntax, hence those is_listen and
> is_telnet parameters. If we want a way to string-ify SocketAddress then
> it should be a generic format, not the chardev format.

Hi

Dropeed.  Don't make sense to try to generalize it for two users.  Just
copy to hmp.c one simplified copy.

Thanks, Juan.

  reply	other threads:[~2018-05-08  7:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-04 11:27 [Qemu-devel] [PATCH v7 0/8] Add make check tests for Migration Juan Quintela
2018-04-04 11:27 ` [Qemu-devel] [PATCH v7 1/8] qemu-sockets: Export SocketAddress_to_str Juan Quintela
2018-04-13 11:54   ` Daniel P. Berrangé
2018-05-08  7:49     ` Juan Quintela [this message]
2018-04-04 11:27 ` [Qemu-devel] [PATCH v7 2/8] tests: Add migration precopy test Juan Quintela
2018-04-04 11:27 ` [Qemu-devel] [PATCH v7 3/8] tests: Add migration xbzrle test Juan Quintela
2018-04-04 11:27 ` [Qemu-devel] [PATCH v7 4/8] migration: Create socket-address parameter Juan Quintela
2018-04-12 13:09   ` Dr. David Alan Gilbert
2018-04-13 12:02     ` Daniel P. Berrangé
2018-05-08  7:51       ` Juan Quintela
2018-05-08  7:50     ` Juan Quintela
2018-04-13 12:01   ` Daniel P. Berrangé
2018-05-08  8:02     ` Juan Quintela
2018-04-04 11:27 ` [Qemu-devel] [PATCH v7 5/8] tests: Migration ppc now inlines its program Juan Quintela
2018-04-04 11:27 ` [Qemu-devel] [PATCH v7 6/8] tests: Add basic migration precopy tcp test Juan Quintela
2018-04-04 11:27 ` [Qemu-devel] [PATCH v7 7/8] migration: Add multifd test Juan Quintela
2018-04-04 11:27 ` [Qemu-devel] [PATCH v7 8/8] [RFH] tests: Add migration compress threads tests Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zi1aa8oe.fsf@secure.laptop \
    --to=quintela@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.