From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH] drm/vc4: Add support for plane alpha
Date: Fri, 20 Apr 2018 16:45:15 -0700
Message-ID: <87zi1xa1dg.fsf@anholt.net>
References: <20180420230503.9629-1-stschake@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1745820776=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from anholt.net (anholt.net [50.246.234.109])
 by gabe.freedesktop.org (Postfix) with ESMTP id 56B6B6E074
 for <dri-devel@lists.freedesktop.org>; Fri, 20 Apr 2018 23:45:17 +0000 (UTC)
In-Reply-To: <20180420230503.9629-1-stschake@gmail.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
Cc: airlied@linux.ie, linux-rpi-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Stefan Schake <stschake@gmail.com>
List-Id: dri-devel@lists.freedesktop.org

--===============1745820776==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain

Stefan Schake <stschake@gmail.com> writes:

> The HVS supports mixing fixed alpha with per-pixel alpha or
> setting a fixed plane alpha in case there is no per-pixel information.
> This allows us to support the generic DRM plane alpha property.

Don't we need to set needs_bg_fill based on alpha != OPAQUE, as well?

Other than that, looks good to me.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlrae4sACgkQtdYpNtH8
nujvaQ//W4Qg85TB1R6wQUe/KxEuuHx+XWwOr2K0lz/p7nPpbUbH7l/8/kBitFfe
gBFf4DOHfn/sFe9nQQDYBlhsWJmEp8S+df4g/Jv/XioVkS+GqytigJ5rWrqbh1uK
+qN9xo0s85D8uFBZHFXwUwN2QvSCrTS7L7zHrHXm/aZBdAPa3+DwnfOYRvSjr8+R
vXteYRQlauygkRN3Fc7v0k/OKNPRUhkExk7DqKVZfBG7nR/tQdw6ly0YztqAnVKi
b50GhG7zSmBSG5z5cv9CUK1VW6FTNljj13Gmmrni4yzjp+pEyiQNXQZVGz1Gv92Q
Gi3+T+D+IzbyNQmr7ASGsVwVnTvHSztDnbYvzaN8Z2ddam08TBDV/UQrEpVJ+HNj
mc15racUIKLwBuU7FpsSSYD2D4rCClHoMrehn4MWWos7jG9iI6WViRlTBpFuUcA2
DeBvXaiw6eFqGnXftFYyiMKVmCjfjw1Q5zUh1PfoxTql9m7J6pPMFrf6+CS4LR2n
fiZFNbJ2QVa6fKrSTz/ON0VZg27qXTfbYJLRFNbq46BCuQpTAs7XgGcrMjrf23+h
kVpzQKkpehzfypo8qzyrK7wl+0jf+8TIOtKB05lphZr2hOcL5RRa7FX8P9P5r3l6
WhBroJzhFVreQB0/Pe/qyDE/KckfkZh+3pPHaN6XH5Q5kuFNF2E=
=kLuk
-----END PGP SIGNATURE-----
--=-=-=--

--===============1745820776==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

--===============1745820776==--