From: "Aurélien Aptel" <aaptel@suse.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Steve French <sfrench@samba.org>
Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Subject: Re: [PATCH] CIFS: fix sha512 check in cifs_crypto_secmech_release
Date: Mon, 19 Feb 2018 18:27:32 +0100 [thread overview]
Message-ID: <87zi4428l7.fsf@suse.com> (raw)
In-Reply-To: <20180219171113.GA16636@embeddedgus>
"Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
> It seems this is a copy-paste error and that the proper variable to use
> in this particular case is _sha512_ instead of _md5_.
*sigh* I re-read this a lot yet still missed it. Minor memory leak
fixed, good coverity catch and thanks for the fix!
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2018-02-19 17:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 17:11 [PATCH] CIFS: fix sha512 check in cifs_crypto_secmech_release Gustavo A. R. Silva
2018-02-19 17:27 ` Aurélien Aptel [this message]
2018-02-19 18:13 ` Gustavo A. R. Silva
2018-02-19 22:09 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi4428l7.fsf@suse.com \
--to=aaptel@suse.com \
--cc=garsilva@embeddedor.com \
--cc=gustavo@embeddedor.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.