From: Andi Kleen <ak@linux.intel.com>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
darrick.wong@oracle.com, Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: Re: [PATCH v5 1/2] Return bytes transferred for partial direct I/O
Date: Sat, 20 Jan 2018 18:11:08 -0800 [thread overview]
Message-ID: <87zi58rmf7.fsf@linux.intel.com> (raw)
In-Reply-To: <20180119005741.32058-1-rgoldwyn@suse.de> (Goldwyn Rodrigues's message of "Thu, 18 Jan 2018 18:57:40 -0600")
Goldwyn Rodrigues <rgoldwyn@suse.de> writes:
> From: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> In case direct I/O encounters an error midway, it returns the error.
> Instead it should be returning the number of bytes transferred so far.
It's likely there's a lot of code in user space that does
if (write(..., N) < 0) handle error
With your change it would need to be
if (write(..., N) != N) handle error
How much code is actually doing that?
I can understand it fixes your artifical test suite, but it seems to me your
change has a high potential to break a lot of existing user code
in subtle ways. So it seems to be a bad idea.
-Andi
next prev parent reply other threads:[~2018-01-21 2:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 0:57 [PATCH v5 1/2] Return bytes transferred for partial direct I/O Goldwyn Rodrigues
2018-01-19 0:57 ` [PATCH 2/2] xfs: remove assert to check bytes returned Goldwyn Rodrigues
2018-01-19 3:57 ` Dave Chinner
2018-01-19 4:23 ` Raphael Carvalho
2018-01-19 4:51 ` Dave Chinner
2018-01-19 2:13 ` [PATCH v5 1/2] Return bytes transferred for partial direct I/O Al Viro
2018-01-19 3:59 ` Dave Chinner
2018-01-19 6:31 ` Darrick J. Wong
2018-01-19 6:33 ` Al Viro
2018-01-20 19:47 ` Al Viro
2018-01-21 2:57 ` Goldwyn Rodrigues
2018-01-21 2:11 ` Andi Kleen [this message]
2018-01-21 2:23 ` Goldwyn Rodrigues
2018-01-21 3:07 ` Jens Axboe
2018-01-21 12:06 ` Goldwyn Rodrigues
2018-01-22 18:08 ` Andi Kleen
2018-01-22 19:10 ` Andreas Dilger
2018-01-22 19:13 ` Jens Axboe
2018-01-23 3:18 ` Goldwyn Rodrigues
2018-01-23 3:28 ` Jens Axboe
2018-01-23 6:35 ` Matthew Wilcox
2018-01-25 18:01 ` Goldwyn Rodrigues
2018-01-24 0:19 ` Andreas Dilger
2018-01-22 22:25 ` Elliott, Robert (Persistent Memory)
2018-01-22 22:25 ` Elliott, Robert (Persistent Memory)
2018-01-22 23:14 ` Jens Axboe
2018-01-22 23:24 ` Bart Van Assche
2018-01-22 23:24 ` Bart Van Assche
2018-01-22 23:27 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi58rmf7.fsf@linux.intel.com \
--to=ak@linux.intel.com \
--cc=darrick.wong@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rgoldwyn@suse.com \
--cc=rgoldwyn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.