From: Jani Nikula <jani.nikula@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 1/6] drm/i915: Introduce intel_ddi_dp_level.
Date: Wed, 09 Aug 2017 15:20:48 +0300 [thread overview]
Message-ID: <87zib9szj3.fsf@intel.com> (raw)
In-Reply-To: <20170808142106.28534-1-rodrigo.vivi@intel.com>
On Tue, 08 Aug 2017, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> +static uint32_t intel_ddi_dp_level(struct intel_dp *intel_dp)
Sorry to pick on specifically this patch when there continue to be
offenders all over the place... but shouldn't we prefer the kernel types
over standard C types? Not that checkpatch is an authority here, but
with --strict it complains about using e.g. uint32_t.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-08-09 12:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 14:21 [PATCH 1/6] drm/i915: Introduce intel_ddi_dp_level Rodrigo Vivi
2017-08-08 14:21 ` [PATCH 2/6] drm/i915: Align vswing sequences with old ddi buffer registers Rodrigo Vivi
2017-08-08 14:21 ` [PATCH 3/6] drm/i915/cnl: Move voltage check into ddi buf trans functions Rodrigo Vivi
2017-08-08 14:21 ` [PATCH 4/6] drm/i915/cnl: Move ddi buf trans related functions up Rodrigo Vivi
2017-08-08 14:21 ` [PATCH 5/6] drm/i915/cnl: Fix DDI hdmi level selection Rodrigo Vivi
2017-08-08 14:21 ` [PATCH 6/6] drm/i915/cnl: Fix DP max voltage Rodrigo Vivi
2017-08-08 15:29 ` ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Introduce intel_ddi_dp_level Patchwork
2017-08-09 12:20 ` Jani Nikula [this message]
2017-08-09 17:22 ` [PATCH 1/6] " Vivi, Rodrigo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zib9szj3.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.