From: Kalle Valo <kvalo@codeaurora.org>
To: linux-wireless@vger.kernel.org
Cc: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
Subject: Re: [PATCH 8/8] qtnfmac: implement scan timeout
Date: Fri, 30 Jun 2017 08:36:57 +0300 [thread overview]
Message-ID: <87zicq9gue.fsf@codeaurora.org> (raw)
In-Reply-To: <20170629164903.adst7rihexlrb643@bars> (Sergey Matyukevich's message of "Thu, 29 Jun 2017 19:49:04 +0300")
Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> writes:
> On Tue, Jun 27, 2017 at 08:27:37PM +0300, Kalle Valo wrote:
>>
>> External Email
>>
>>
>> Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> writes:
>>
>> > Userspace tools may hang on scan in the case when scan completion event
>> > is not returned by firmware. This patch implements the scan timeout
>> > to avoid such situation.
>> >
>> > Signed-off-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
>>
>> [...]
>>
>> > +static __always_inline void qtnf_wmac_lock(struct qtnf_wmac *mac)
>> > +{
>> > + mutex_lock(&mac->mac_lock);
>> > +}
>> > +
>> > +static __always_inline void qtnf_wmac_unlock(struct qtnf_wmac *mac)
>> > +{
>> > + mutex_unlock(&mac->mac_lock);
>> > +}
>>
>> Why? These look pointless to me.
>
> Could you please clarify a bit. You mean, locking/unlocking directly instead of
> using inline wrappers ?
Yeah, adding unnecessary abstractions is very much frowned upon.
--
Kalle Valo
next prev parent reply other threads:[~2017-06-30 5:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 19:55 [PATCH 0/8] qtnfmac: add more features to driver Sergey Matyukevich
2017-06-20 19:55 ` [PATCH 1/8] qtnfmac: updates and fixes for regulatory support Sergey Matyukevich
2017-06-27 17:20 ` Kalle Valo
2017-06-29 16:43 ` Sergey Matyukevich
2017-06-20 19:55 ` [PATCH 2/8] qtnfmac: cleanup and fixes preparing AP_VLAN support Sergey Matyukevich
2017-06-27 17:21 ` Kalle Valo
2017-06-29 16:46 ` Sergey Matyukevich
2017-06-20 19:55 ` [PATCH 3/8] qtnfmac: implement AP_VLAN iftype support Sergey Matyukevich
2017-06-27 17:35 ` Kalle Valo
2017-07-01 8:45 ` Sergey Matyukevich
2017-09-05 13:45 ` Johannes Berg
2017-09-05 14:20 ` VLAN/bridge "compression" in wifi (was: Re: [PATCH 3/8] qtnfmac: implement AP_VLAN iftype support) Johannes Berg
2017-09-05 14:20 ` Johannes Berg
2017-09-06 15:45 ` Sergey Matyukevich
2017-09-06 15:45 ` Sergey Matyukevich
2017-09-07 6:45 ` Johannes Berg
2017-09-06 16:22 ` [PATCH 3/8] qtnfmac: implement AP_VLAN iftype support Sergey Matyukevich
2017-06-20 19:55 ` [PATCH 4/8] qtnfmac: implement cfg80211 dump_survey handler Sergey Matyukevich
2017-06-20 19:55 ` [PATCH 5/8] qtnfmac: enable reporting the current operating channel Sergey Matyukevich
2017-06-20 19:59 ` Johannes Berg
2017-06-20 20:09 ` Sergey Matyukevich
2017-06-20 20:17 ` Johannes Berg
2017-06-27 17:30 ` Kalle Valo
2017-06-20 19:55 ` [PATCH 6/8] qtnfmac: move current channel info from vif to mac Sergey Matyukevich
2017-06-20 19:55 ` [PATCH 7/8] qtnfmac: implement cfg80211 channel_switch handler Sergey Matyukevich
2017-06-27 17:29 ` Kalle Valo
2017-06-20 19:55 ` [PATCH 8/8] qtnfmac: implement scan timeout Sergey Matyukevich
2017-06-27 17:27 ` Kalle Valo
2017-06-29 16:49 ` Sergey Matyukevich
2017-06-30 5:36 ` Kalle Valo [this message]
2017-07-25 11:56 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zicq9gue.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.