Re: [PATCH 1/3] drm/i915/guc: Remove stale comment for q_fail

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 18 May 2017, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
> This member was dropped long time ago.
>
> Fixes: 774439e1 ("drm/i915/guc: re-optimise i915_guc_client layout")

For future reference, please only use Fixes: to indicate actual bugs
fixed. I use the tag to track fixes that need to be backported, stale
comments or typo fixes or whatnot need not, and excessive Fixes: use
leads to noise for me. That said, when in doubt, err on the side of
adding one.

Thanks,
Jani.


> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_uc.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uc.h b/drivers/gpu/drm/i915/intel_uc.h
> index 7618b71..8d52a37 100644
> --- a/drivers/gpu/drm/i915/intel_uc.h
> +++ b/drivers/gpu/drm/i915/intel_uc.h
> @@ -59,8 +59,6 @@ struct drm_i915_gem_request;
>   *                available in the work queue (note, the queue is shared,
>   *                not per-engine). It is OK for this to be nonzero, but
>   *                it should not be huge!
> - *   q_fail: failed to enqueue a work item. This should never happen,
> - *           because we check for space beforehand.
>   *   b_fail: failed to ring the doorbell. This should never happen, unless
>   *           somehow the hardware misbehaves, or maybe if the GuC firmware
>   *           crashes? We probably need to reset the GPU to recover.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx