All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, mreitz@redhat.com, dgilbert@redhat.com,
	stefanha@redhat.com, famz@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] block: Fix anonymous BBs in blk_root_inactivate()
Date: Tue, 23 May 2017 18:36:14 +0200	[thread overview]
Message-ID: <87zie37cox.fsf@secure.mitica> (raw)
In-Reply-To: <1495548064-10926-2-git-send-email-kwolf@redhat.com> (Kevin Wolf's message of "Tue, 23 May 2017 16:01:01 +0200")

Kevin Wolf <kwolf@redhat.com> wrote:
> blk->name isn't an array, but a pointer that can be NULL. Checking for
> an anonymous BB must involve a NULL check first, otherwise we get
> crashes.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

  parent reply	other threads:[~2017-05-23 16:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-23 14:01 [Qemu-devel] [PATCH 0/4] Block migration (migrate -b) fixes Kevin Wolf
2017-05-23 14:01 ` [Qemu-devel] [PATCH 1/4] block: Fix anonymous BBs in blk_root_inactivate() Kevin Wolf
2017-05-23 15:30   ` Eric Blake
2017-05-23 16:36   ` Juan Quintela [this message]
2017-05-23 14:01 ` [Qemu-devel] [PATCH 2/4] migration: Inactivate images after .save_live_complete_precopy() Kevin Wolf
2017-05-23 15:36   ` Eric Blake
2017-05-24 11:34   ` Juan Quintela
2017-05-23 14:01 ` [Qemu-devel] [PATCH 3/4] migration/block: Clean up BBs in block_save_complete() Kevin Wolf
2017-05-23 15:41   ` Eric Blake
2017-05-23 14:01 ` [Qemu-devel] [PATCH 4/4] qemu-iotests: Block migration test Kevin Wolf
2017-05-23 15:46   ` Eric Blake
2017-05-23 16:18     ` Kevin Wolf
2017-05-23 16:29       ` Eric Blake
2017-05-24  6:23 ` [Qemu-devel] [PATCH 0/4] Block migration (migrate -b) fixes Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zie37cox.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.