All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Tomasz Papież" <tmszpp@gmail.com>, "David Airlie" <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: PROBLEM: EDID regression results in color banding on Lenovo G50 series laptops [fix proposition]
Date: Tue, 09 May 2017 10:50:50 +0300	[thread overview]
Message-ID: <87ziem8o4l.fsf@intel.com> (raw)
In-Reply-To: <aedceba6-f3d8-3377-6dd8-398603d5aef2@gmail.com>

On Mon, 08 May 2017, Tomasz Papież <tmszpp@gmail.com> wrote:
> Since the introduction of kernel 4.8 I've been experiencing color 
> banding on my Lenovo G50-80 notebook. I also had reports of the same 
> symptoms on the G50-70 model.
>
> I figured out that the problem had been introduced by commit 
> 210a021dab639694600450c14b877bf3e3240adc

commit 210a021dab639694600450c14b877bf3e3240adc
Author: Mario Kleiner <mario.kleiner.de@gmail.com>
Date:   Wed Jul 6 12:05:48 2016 +0200

    drm/edid: Set 8 bpc color depth for displays with "DFP 1.x compliant TMDS".

Cc: Mario.


>
> The G50-80's LCD panel supports 6bpc, but is now set to 8bpc,
> and the system probably falls back to 6bpc
> without any dithering, which result in heavily banded gradients.
>
> I fixed it for myself by adding an EDID quirk for that particular LCD 
> panel (see the attached patch). It's unknown to me, however, if there 
> are any other panels affected by the issue, so maybe a more general
> solution might be desirable.
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index fad3d44e4642..ee3124bcae87 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -147,6 +147,9 @@ static const struct edid_quirk {
>  	/* Medion MD 30217 PG */
>  	{ "MED", 0x7b8, EDID_QUIRK_PREFER_LARGE_75 },
>  
> +	/* Fix for Lenovo G50 */
> +	{ "SDC", 18514, EDID_QUIRK_FORCE_6BPC },
> +
>  	/* Panel in Samsung NP700G7A-S01PL notebook reports 6bpc */
>  	{ "SEC", 0xd033, EDID_QUIRK_FORCE_8BPC },
>  
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-05-09  7:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-08 16:24 PROBLEM: EDID regression results in color banding on Lenovo G50 series laptops [fix proposition] Tomasz Papież
2017-05-09  7:50 ` Jani Nikula [this message]
2017-05-15 16:49   ` Mario Kleiner
2017-05-15 21:37     ` [PATCH] EDID quirk for Lenovo G50-80 (force 6bpc) Tomasz Papież

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ziem8o4l.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=tmszpp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.