From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Manish Narani <manish.narani@xilinx.com>, git-dev@xilinx.com
Cc: anirudh@xilinx.com, Roger Quadros <rogerq@ti.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] Revert "usb: gadget: uvc: Add missing call for additional setup data"
Date: Tue, 11 Apr 2017 09:59:49 +0300 [thread overview]
Message-ID: <87zifnctui.fsf@linux.intel.com> (raw)
In-Reply-To: <1491891125-25721-1-git-send-email-mnarani@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 979 bytes --]
Hi,
Manish Narani <manish.narani@xilinx.com> writes:
> From: Roger Quadros <rogerq@ti.com>
>
> This reverts commit 4fbac5206afd01b717d4bdc58793d471f3391b4b.
>
> This commit breaks g_webcam when used with uvc-gadget [1].
>
> The user space application (e.g. uvc-gadget) is responsible for
> sending response to UVC class specific requests on control endpoint
> in uvc_send_response() in uvc_v4l2.c.
>
> The bad commit was causing a duplicate response to be sent with
> incorrect response data thus causing UVC probe to fail at the host
> and broken control transfer endpoint at the gadget.
>
> [1] - git://git.ideasonboard.org/uvc-gadget.git
>
> Cc: <stable@vger.kernel.org> # v4.9+
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
this is not how you send patches to stable. Please read
stable-kernel-rules.rst
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-04-11 7:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 6:12 [PATCH] Revert "usb: gadget: uvc: Add missing call for additional setup data" Manish Narani
2017-04-11 6:59 ` Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-03-02 8:44 Roger Quadros
2017-03-02 10:49 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zifnctui.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=anirudh@xilinx.com \
--cc=git-dev@xilinx.com \
--cc=manish.narani@xilinx.com \
--cc=rogerq@ti.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.