From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, lvivier@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 0/3] Fix QemuOpts regression on bogus keys
Date: Wed, 22 Mar 2017 16:58:01 +0100 [thread overview]
Message-ID: <87zigdfgmu.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20170322144525.18964-1-eblake@redhat.com> (Eric Blake's message of "Wed, 22 Mar 2017 09:45:22 -0500")
Eric Blake <eblake@redhat.com> writes:
> Reported to me off-list by Laurent Vivier, who found the
> problem while working on https://bugzilla.redhat.com/1433193;
> now split into https://bugzilla.redhat.com/show_bug.cgi?id=1434666.
> Broken since 2.7, but the fix is a one-liner (pointing out my
> embarrassing mistake of mis-converting a pre-decrement operator);
> as a bug fix, it still qualifies for 2.9 in spite of hard freeze,
> on the other hand, as the regression was not introduced in 2.9,
> I also understand if it is postponed.
>
> v1 was here:
> https://lists.gnu.org/archive/html/qemu-devel/2017-03/msg04072.html
> v2 was here:
> https://lists.gnu.org/archive/html/qemu-devel/2017-03/msg04275.html
>
> Since then:
> - more commit message tweaks
> - drop a spurious hunk from the test in commit 3
Reviewed-by: Markus Armbruster <armbru@redhat.com>
prev parent reply other threads:[~2017-03-22 15:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 14:45 [Qemu-devel] [PATCH v3 0/3] Fix QemuOpts regression on bogus keys Eric Blake
2017-03-22 14:45 ` [Qemu-devel] [PATCH v3 1/3] tests: Expose regression in QemuOpts visitor Eric Blake
2017-03-22 14:45 ` [Qemu-devel] [PATCH v3 2/3] qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts Eric Blake
2017-03-22 15:02 ` Laurent Vivier
2017-03-23 15:37 ` [Qemu-devel] Possible regression (was: Re: [PATCH v3 2/3] qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts) Richard W.M. Jones
2017-03-23 15:48 ` [Qemu-devel] Possible regression Eric Blake
2017-03-23 16:06 ` Markus Armbruster
2017-03-23 16:11 ` Eric Blake
2017-03-22 14:45 ` [Qemu-devel] [PATCH v3 3/3] qapi: Fix QemuOpts visitor regression on unvisited input Eric Blake
2017-03-22 15:58 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zigdfgmu.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.