From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) Subject: Re: [GIT PULL] namespace related fixes for 4.10-rc3 Date: Wed, 11 Jan 2017 12:23:18 +1300 Message-ID: <87ziiyijo9.fsf@xmission.com> References: <87d1fzzbc2.fsf@xmission.com> <20170107062952.GH1555@ZenIV.linux.org.uk> <20170107064012.GI1555@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170107064012.GI1555-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org> (Al Viro's message of "Sat, 7 Jan 2017 06:40:13 +0000") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Al Viro Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Containers , Linus Torvalds , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: containers.vger.kernel.org Al Viro writes: > On Sat, Jan 07, 2017 at 06:29:52AM +0000, Al Viro wrote: >> On Sat, Jan 07, 2017 at 06:30:05PM +1300, Eric W. Biederman wrote: >> >> > Eric W. Biederman (3): >> > mnt: Protect the mountpoint hashtable with mount_lock >> ACK >> >> > mnt: Tuck mounts under others instead of creating shadow/side mounts. >> >> NAK; you have reintroduced put_mountpoint() outside of mount lock in there >> and you've got seriously confused umount side of the things. > > PS: details are in my reply (admittedly, sent only ~20 minutes > before your pull request) to your patch. Check Message-ID > <20170107050644.GA12074-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org> I suspect that was sent while I was composing my pull request, and the locking around put_mountpoint I did fail to catch during my rebase. I will finish our conversation about that before I resend that patch. > My apologies for not getting to it yesterday (the patch was posted a couple of > days ago, AFAICS) - I'd been off-net since Wednesday, just got back > ;-/ You and Ram Pai had said reasonably pleasant things about a previous version of that patch. Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out01.mta.xmission.com ([166.70.13.231]:44168 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756867AbdAJX1T (ORCPT ); Tue, 10 Jan 2017 18:27:19 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Al Viro Cc: Linus Torvalds , Linux Containers , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <87d1fzzbc2.fsf@xmission.com> <20170107062952.GH1555@ZenIV.linux.org.uk> <20170107064012.GI1555@ZenIV.linux.org.uk> Date: Wed, 11 Jan 2017 12:23:18 +1300 In-Reply-To: <20170107064012.GI1555@ZenIV.linux.org.uk> (Al Viro's message of "Sat, 7 Jan 2017 06:40:13 +0000") Message-ID: <87ziiyijo9.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [GIT PULL] namespace related fixes for 4.10-rc3 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Al Viro writes: > On Sat, Jan 07, 2017 at 06:29:52AM +0000, Al Viro wrote: >> On Sat, Jan 07, 2017 at 06:30:05PM +1300, Eric W. Biederman wrote: >> >> > Eric W. Biederman (3): >> > mnt: Protect the mountpoint hashtable with mount_lock >> ACK >> >> > mnt: Tuck mounts under others instead of creating shadow/side mounts. >> >> NAK; you have reintroduced put_mountpoint() outside of mount lock in there >> and you've got seriously confused umount side of the things. > > PS: details are in my reply (admittedly, sent only ~20 minutes > before your pull request) to your patch. Check Message-ID > <20170107050644.GA12074@ZenIV.linux.org.uk> I suspect that was sent while I was composing my pull request, and the locking around put_mountpoint I did fail to catch during my rebase. I will finish our conversation about that before I resend that patch. > My apologies for not getting to it yesterday (the patch was posted a couple of > days ago, AFAICS) - I'd been off-net since Wednesday, just got back > ;-/ You and Ram Pai had said reasonably pleasant things about a previous version of that patch. Eric