From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Thu, 05 Jan 2017 11:29:48 +0100 Subject: [PATCH 1/5] ARM: dts: armada388-clearfog: add phy reset gpio-hog In-Reply-To: <20170105101620.GR14217@n2100.armlinux.org.uk> (Russell King's message of "Thu, 5 Jan 2017 10:16:20 +0000") References: <871swig5b3.fsf@free-electrons.com> <20170105101620.GR14217@n2100.armlinux.org.uk> Message-ID: <87zij5dckj.fsf@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Russell King, On jeu., janv. 05 2017, Russell King - ARM Linux wrote: > On Wed, Jan 04, 2017 at 05:26:08PM +0100, Gregory CLEMENT wrote: >> Hi Russell, >> >> On lun., janv. 02 2017, Russell King wrote: >> >> >> It would be nice to have some word here about this patch. Especially why >> we need it now. I guess it is for being less dependent on the >> initialization done by the bootloader but maybe you have other reasons. > > I'm not sure I follow. This is adding it to the new platform, not the > old one. I guess I should've rolled this into the patch creating the > clearfog-base dts file, and this question wouldn't have come up. > Indeed I missed the fact that it was on the new board as all the other patches were related to the common part. Do you agree that I squash this patch into the "ARM: dts: armada388-clearfog: add base model DTS file" patch? Thanks, Gregory >> >> > Signed-off-by: Russell King >> > --- >> > arch/arm/boot/dts/armada-388-clearfog-base.dts | 15 +++++++++++++++ >> > 1 file changed, 15 insertions(+) >> > >> > diff --git a/arch/arm/boot/dts/armada-388-clearfog-base.dts b/arch/arm/boot/dts/armada-388-clearfog-base.dts >> > index f86e1876fb38..da788ea40717 100644 >> > --- a/arch/arm/boot/dts/armada-388-clearfog-base.dts >> > +++ b/arch/arm/boot/dts/armada-388-clearfog-base.dts >> > @@ -74,7 +74,17 @@ >> > phy = <&phy1>; >> > }; >> > >> > +&gpio0 { >> > + phy1_reset { >> > + gpio-hog; >> > + gpios = <19 GPIO_ACTIVE_LOW>; >> > + output-low; >> > + line-name = "phy1-reset"; >> > + }; >> > +}; >> > + >> > &mdio { >> > + pinctrl-0 = <&mdio_pins µsom_phy_clk_pins &clearfog_phy_pins>; >> > phy1: ethernet-phy at 1 { >> > /* >> > * Annoyingly, the marvell phy driver configures the LED >> > @@ -87,6 +97,11 @@ >> > }; >> > >> > &pinctrl { >> > + /* phy1 reset */ >> > + clearfog_phy_pins: clearfog-phy-pins { >> > + marvell,pins = "mpp19"; >> > + marvell,function = "gpio"; >> > + }; >> > rear_button_pins: rear-button-pins { >> > marvell,pins = "mpp44"; >> > marvell,function = "gpio"; >> > -- >> > 2.7.4 >> > >> >> -- >> Gregory Clement, Free Electrons >> Kernel, drivers, real-time and embedded Linux >> development, consulting, training and support. >> http://free-electrons.com > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 1/5] ARM: dts: armada388-clearfog: add phy reset gpio-hog Date: Thu, 05 Jan 2017 11:29:48 +0100 Message-ID: <87zij5dckj.fsf@free-electrons.com> References: <871swig5b3.fsf@free-electrons.com> <20170105101620.GR14217@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170105101620.GR14217@n2100.armlinux.org.uk> (Russell King's message of "Thu, 5 Jan 2017 10:16:20 +0000") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Russell King - ARM Linux Cc: Mark Rutland , Andrew Lunn , Jason Cooper , devicetree@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org Hi Russell King, On jeu., janv. 05 2017, Russell King - ARM Linux wrote: > On Wed, Jan 04, 2017 at 05:26:08PM +0100, Gregory CLEMENT wrote: >> Hi Russell, >> >> On lun., janv. 02 2017, Russell King wrote: >> >> >> It would be nice to have some word here about this patch. Especially why >> we need it now. I guess it is for being less dependent on the >> initialization done by the bootloader but maybe you have other reasons. > > I'm not sure I follow. This is adding it to the new platform, not the > old one. I guess I should've rolled this into the patch creating the > clearfog-base dts file, and this question wouldn't have come up. > Indeed I missed the fact that it was on the new board as all the other patches were related to the common part. Do you agree that I squash this patch into the "ARM: dts: armada388-clearfog: add base model DTS file" patch? Thanks, Gregory >> >> > Signed-off-by: Russell King >> > --- >> > arch/arm/boot/dts/armada-388-clearfog-base.dts | 15 +++++++++++++++ >> > 1 file changed, 15 insertions(+) >> > >> > diff --git a/arch/arm/boot/dts/armada-388-clearfog-base.dts b/arch/arm/boot/dts/armada-388-clearfog-base.dts >> > index f86e1876fb38..da788ea40717 100644 >> > --- a/arch/arm/boot/dts/armada-388-clearfog-base.dts >> > +++ b/arch/arm/boot/dts/armada-388-clearfog-base.dts >> > @@ -74,7 +74,17 @@ >> > phy = <&phy1>; >> > }; >> > >> > +&gpio0 { >> > + phy1_reset { >> > + gpio-hog; >> > + gpios = <19 GPIO_ACTIVE_LOW>; >> > + output-low; >> > + line-name = "phy1-reset"; >> > + }; >> > +}; >> > + >> > &mdio { >> > + pinctrl-0 = <&mdio_pins µsom_phy_clk_pins &clearfog_phy_pins>; >> > phy1: ethernet-phy@1 { >> > /* >> > * Annoyingly, the marvell phy driver configures the LED >> > @@ -87,6 +97,11 @@ >> > }; >> > >> > &pinctrl { >> > + /* phy1 reset */ >> > + clearfog_phy_pins: clearfog-phy-pins { >> > + marvell,pins = "mpp19"; >> > + marvell,function = "gpio"; >> > + }; >> > rear_button_pins: rear-button-pins { >> > marvell,pins = "mpp44"; >> > marvell,function = "gpio"; >> > -- >> > 2.7.4 >> > >> >> -- >> Gregory Clement, Free Electrons >> Kernel, drivers, real-time and embedded Linux >> development, consulting, training and support. >> http://free-electrons.com > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com