From: NeilBrown <neilb@suse.com>
To: Shaohua Li <shli@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-raid@vger.kernel.org
Subject: Re: [md PATCH 0/5] Stop using bi_phys_segments as a counter
Date: Wed, 23 Nov 2016 13:08:38 +1100 [thread overview]
Message-ID: <87zikraqxl.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20161122080127.rv4kgmeyluyfyxnd@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
On Tue, Nov 22 2016, Shaohua Li wrote:
>
> I still don't like we have no control when to do endio, but don't have better
> idea either. These patches work for raid5, but we need to find similar tricky
> way to workaround raid1/raid10, which reuse bi_phys_segments too. Probably it's
> time MD allocates additional data and attaches to bio. Adding a counter will
> solve the issue in a consistency/clean way for raid1/10/5.
For raid1/raid10 we could do a very similar thing. There is an
awkwardness in raid1 w.r.t waiting for bi_phys_segments to reach 1, but
that might disappear if Coly's resync changes go through.
Alternately it might make sense to use bio_split so there is one r1_bio
per bio.
I might try the raid10 version and see what it looks like.
Thanks,
NeilBrown
>
> Thanks,
> Shaohua
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]
next prev parent reply other threads:[~2016-11-23 2:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 1:19 [md PATCH 0/5] Stop using bi_phys_segments as a counter NeilBrown
2016-11-21 1:19 ` [md PATCH 4/5] md/raid5: call bio_endio() directly rather than queuing for later NeilBrown
2016-11-21 1:19 ` [md PATCH 2/5] md/raid5: use md_write_start to count stripes, not bios NeilBrown
2016-11-21 1:19 ` [md PATCH 3/5] md/raid5: simplfy delaying of writes while metadata is updated NeilBrown
2016-11-21 1:19 ` [md PATCH 1/5] md: optimize md_write_start() slightly NeilBrown
2016-11-21 1:19 ` [md PATCH 5/5] md/raid5: use bio_inc_remaining() instead of repurposing bi_phys_segments as a counter NeilBrown
2016-11-21 2:32 ` [md PATCH 6/5] md/raid5: remove over-loading of ->bi_phys_segments NeilBrown
2016-11-21 14:01 ` [md PATCH 0/5] Stop using bi_phys_segments as a counter Christoph Hellwig
2016-11-21 23:43 ` Shaohua Li
2016-11-22 0:25 ` NeilBrown
2016-11-22 1:02 ` Shaohua Li
2016-11-22 2:19 ` NeilBrown
2016-11-22 8:01 ` Shaohua Li
2016-11-23 2:08 ` NeilBrown [this message]
2016-11-23 8:45 ` Christoph Hellwig
2016-11-24 0:31 ` NeilBrown
2017-02-06 8:56 ` Christoph Hellwig
2017-02-06 21:41 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zikraqxl.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=hch@lst.de \
--cc=linux-raid@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.