diff for duplicates of <87zim8wip4.fsf@intel.com> diff --git a/a/1.txt b/N1/1.txt index b083747..af1b90b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,7 +3,7 @@ On Thu, 13 Oct 2016, walter harms <wharms@bfs.de> wrote: >> We want to read 3 bytes here, but because the parenthesis are in the >> wrong place we instead read: >> ->> sizeof(intel_dp->edp_dpcd) = sizeof(intel_dp->edp_dpcd) +>> sizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dpcd) >> >> which is one byte. >> @@ -23,9 +23,9 @@ Cc: <drm-intel-fixes@lists.freedesktop.org> >> /* Read the eDP Display control capabilities registers */ >> if ((intel_dp->dpcd[DP_EDP_CONFIGURATION_CAP] & DP_DPCD_DISPLAY_CONTROL_CAPABLE) && >> drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV, ->> - intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd) = +>> - intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd) == >> - sizeof(intel_dp->edp_dpcd))) ->> + intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) = +>> + intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) == >> + sizeof(intel_dp->edp_dpcd)) > > @@ -35,7 +35,7 @@ Cc: <drm-intel-fixes@lists.freedesktop.org> > > if (intel_dp->dpcd[DP_EDP_CONFIGURATION_CAP] & DP_DPCD_DISPLAY_CONTROL_CAPABLE) > { -> size_t size=sizeof(intel_dp->edp_dpcd); /* = EDP_DISPLAY_CTL_CAP_SIZE */ +> size_t size=sizeof(intel_dp->edp_dpcd); /* == EDP_DISPLAY_CTL_CAP_SIZE */ > int ret; > > ret=drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV,intel_dp->edp_dpcd,size); @@ -55,3 +55,7 @@ Jani. -- Jani Nikula, Intel Open Source Technology Center +_______________________________________________ +dri-devel mailing list +dri-devel@lists.freedesktop.org +https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/a/content_digest b/N1/content_digest index 8d724db..f44fe7d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\057FF5380.1080704@bfs.de\0" "From\0Jani Nikula <jani.nikula@linux.intel.com>\0" "Subject\0Re: [patch] drm/i915: fix a read size argument\0" - "Date\0Thu, 13 Oct 2016 12:13:11 +0000\0" + "Date\0Thu, 13 Oct 2016 15:13:11 +0300\0" "To\0wharms@bfs.de" " Dan Carpenter <dan.carpenter@oracle.com>\0" "Cc\0intel-gfx@lists.freedesktop.org" @@ -18,7 +18,7 @@ ">> We want to read 3 bytes here, but because the parenthesis are in the\n" ">> wrong place we instead read:\n" ">> \n" - ">> \tsizeof(intel_dp->edp_dpcd) = sizeof(intel_dp->edp_dpcd)\n" + ">> \tsizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dpcd)\n" ">> \n" ">> which is one byte.\n" ">> \n" @@ -38,9 +38,9 @@ ">> \t/* Read the eDP Display control capabilities registers */\n" ">> \tif ((intel_dp->dpcd[DP_EDP_CONFIGURATION_CAP] & DP_DPCD_DISPLAY_CONTROL_CAPABLE) &&\n" ">> \t drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV,\n" - ">> -\t\t\t intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd) =\n" + ">> -\t\t\t intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd) ==\n" ">> -\t\t\t sizeof(intel_dp->edp_dpcd)))\n" - ">> +\t\t\t intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) =\n" + ">> +\t\t\t intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) ==\n" ">> +\t\t\t sizeof(intel_dp->edp_dpcd))\n" ">\n" ">\n" @@ -50,7 +50,7 @@ ">\n" "> if (intel_dp->dpcd[DP_EDP_CONFIGURATION_CAP] & DP_DPCD_DISPLAY_CONTROL_CAPABLE)\n" "> {\n" - "> size_t size=sizeof(intel_dp->edp_dpcd); /* = EDP_DISPLAY_CTL_CAP_SIZE */\n" + "> size_t size=sizeof(intel_dp->edp_dpcd); /* == EDP_DISPLAY_CTL_CAP_SIZE */\n" "> int ret;\t\n" ">\n" "> ret=drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV,intel_dp->edp_dpcd,size);\t\n" @@ -69,6 +69,10 @@ "\n" "\n" "-- \n" - Jani Nikula, Intel Open Source Technology Center + "Jani Nikula, Intel Open Source Technology Center\n" + "_______________________________________________\n" + "dri-devel mailing list\n" + "dri-devel@lists.freedesktop.org\n" + https://lists.freedesktop.org/mailman/listinfo/dri-devel -fe61f8a7394868aa0fcfedbdad19c29a36f32db9abeb7765ac870ecaf6d6463b +ba15baf13cb919b367faed346268264db4a9fd4e944bc8bdd3f5616c2231fd3f
diff --git a/a/1.txt b/N2/1.txt index b083747..0c99016 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -3,7 +3,7 @@ On Thu, 13 Oct 2016, walter harms <wharms@bfs.de> wrote: >> We want to read 3 bytes here, but because the parenthesis are in the >> wrong place we instead read: >> ->> sizeof(intel_dp->edp_dpcd) = sizeof(intel_dp->edp_dpcd) +>> sizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dpcd) >> >> which is one byte. >> @@ -23,9 +23,9 @@ Cc: <drm-intel-fixes@lists.freedesktop.org> >> /* Read the eDP Display control capabilities registers */ >> if ((intel_dp->dpcd[DP_EDP_CONFIGURATION_CAP] & DP_DPCD_DISPLAY_CONTROL_CAPABLE) && >> drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV, ->> - intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd) = +>> - intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd) == >> - sizeof(intel_dp->edp_dpcd))) ->> + intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) = +>> + intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) == >> + sizeof(intel_dp->edp_dpcd)) > > @@ -35,7 +35,7 @@ Cc: <drm-intel-fixes@lists.freedesktop.org> > > if (intel_dp->dpcd[DP_EDP_CONFIGURATION_CAP] & DP_DPCD_DISPLAY_CONTROL_CAPABLE) > { -> size_t size=sizeof(intel_dp->edp_dpcd); /* = EDP_DISPLAY_CTL_CAP_SIZE */ +> size_t size=sizeof(intel_dp->edp_dpcd); /* == EDP_DISPLAY_CTL_CAP_SIZE */ > int ret; > > ret=drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV,intel_dp->edp_dpcd,size); diff --git a/a/content_digest b/N2/content_digest index 8d724db..a5fef46 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,15 +2,17 @@ "ref\057FF5380.1080704@bfs.de\0" "From\0Jani Nikula <jani.nikula@linux.intel.com>\0" "Subject\0Re: [patch] drm/i915: fix a read size argument\0" - "Date\0Thu, 13 Oct 2016 12:13:11 +0000\0" + "Date\0Thu, 13 Oct 2016 15:13:11 +0300\0" "To\0wharms@bfs.de" " Dan Carpenter <dan.carpenter@oracle.com>\0" - "Cc\0intel-gfx@lists.freedesktop.org" - kernel-janitors@vger.kernel.org - linux-kernel@vger.kernel.org + "Cc\0Daniel Vetter <daniel.vetter@intel.com>" + " Ville Syrj\303\244l\303\244 <ville.syrjala@linux.intel.com>" + David Airlie <airlied@linux.ie> + intel-gfx@lists.freedesktop.org dri-devel@lists.freedesktop.org - drm-intel-fixes@lists.freedesktop.org - " Daniel Vetter <daniel.vetter@intel.com>\0" + linux-kernel@vger.kernel.org + kernel-janitors@vger.kernel.org + " drm-intel-fixes@lists.freedesktop.org\0" "\00:1\0" "b\0" "On Thu, 13 Oct 2016, walter harms <wharms@bfs.de> wrote:\n" @@ -18,7 +20,7 @@ ">> We want to read 3 bytes here, but because the parenthesis are in the\n" ">> wrong place we instead read:\n" ">> \n" - ">> \tsizeof(intel_dp->edp_dpcd) = sizeof(intel_dp->edp_dpcd)\n" + ">> \tsizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dpcd)\n" ">> \n" ">> which is one byte.\n" ">> \n" @@ -38,9 +40,9 @@ ">> \t/* Read the eDP Display control capabilities registers */\n" ">> \tif ((intel_dp->dpcd[DP_EDP_CONFIGURATION_CAP] & DP_DPCD_DISPLAY_CONTROL_CAPABLE) &&\n" ">> \t drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV,\n" - ">> -\t\t\t intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd) =\n" + ">> -\t\t\t intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd) ==\n" ">> -\t\t\t sizeof(intel_dp->edp_dpcd)))\n" - ">> +\t\t\t intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) =\n" + ">> +\t\t\t intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) ==\n" ">> +\t\t\t sizeof(intel_dp->edp_dpcd))\n" ">\n" ">\n" @@ -50,7 +52,7 @@ ">\n" "> if (intel_dp->dpcd[DP_EDP_CONFIGURATION_CAP] & DP_DPCD_DISPLAY_CONTROL_CAPABLE)\n" "> {\n" - "> size_t size=sizeof(intel_dp->edp_dpcd); /* = EDP_DISPLAY_CTL_CAP_SIZE */\n" + "> size_t size=sizeof(intel_dp->edp_dpcd); /* == EDP_DISPLAY_CTL_CAP_SIZE */\n" "> int ret;\t\n" ">\n" "> ret=drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV,intel_dp->edp_dpcd,size);\t\n" @@ -71,4 +73,4 @@ "-- \n" Jani Nikula, Intel Open Source Technology Center -fe61f8a7394868aa0fcfedbdad19c29a36f32db9abeb7765ac870ecaf6d6463b +91bb8dd094bbba0ae9f513d82b5a39c71da7b8437ec9400ff53f649a64579adf
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.