From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
"Stable \[ 4 . 8+ \]" <stable@vger.kernel.org>,
Julia Lawall <Julia.Lawall@lip6.fr>
Subject: Re: [PATCH] rtlwifi: Fix regression caused by commit d86e64768859
Date: Wed, 12 Oct 2016 19:54:22 +0300 [thread overview]
Message-ID: <87zim9cxtt.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20161010233211.13519-1-Larry.Finger@lwfinger.net> (Larry Finger's message of "Mon, 10 Oct 2016 18:32:11 -0500")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"),
> the configuration struct for most of the drivers was changed to be
> constant. The problem is that five of the modified drivers need to be
> able to update the firmware name based on the exact model of the card.
> As the file names were stored in one of the members of that struct,
> these drivers would fail with a kernel BUG splat when they tried to
> update the firmware name.
>
> Rather than reverting the previous commit, I used a suggestion by
> Johannes Berg and made the firmware file name pointers be local to
> the routines that update the software variables.
>
> The configuration struct of rtl8192cu, which was not touched in the
> previous patch, is now constantfied.
>
> Fixes: d86e64768859 ("rtlwifi: rtl818x: constify local structures")
> Suggested-by: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Stable [4.8+] <stable@vger.kernel.org>
> Cc: Julia Lawall <Julia.Lawall@lip6.fr>
I got warnings and after a quick look they look valid but not sure:
drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c: In function 'rtl92c_init_sw_vars':
drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c:179:6: warning: 'fw_name' may be used uninitialized in this function [-Wuninitialized]
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c: In function 'rtl8723e_init_sw_vars':
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c:187:6: warning: 'fw_name' may be used uninitialized in this function [-Wuninitialized]
(Sending manually for the second time as I don't see my first mail
anywhere.)
--
Kalle Valo
next prev parent reply other threads:[~2016-10-12 16:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 23:32 [PATCH] rtlwifi: Fix regression caused by commit d86e64768859 Larry Finger
2016-10-12 7:53 ` Kalle Valo
2016-10-12 15:39 ` Larry Finger
2016-10-12 16:45 ` Kalle Valo
2016-10-12 16:54 ` Kalle Valo [this message]
2016-10-12 18:53 ` [PATCH] " Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zim9cxtt.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Julia.Lawall@lip6.fr \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.